https://codereview.chromium.org/106453003/diff/60001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/106453003/diff/60001/src/hydrogen.cc#newcode8791
src/hydrogen.cc:8791: ?
HAllocationMode(isolate()->heap()->GetPretenureMode())
On 2013/12/11 08:15:29, mvstanton wrote:
Maybe FLAG_allocation_site_pretenuring should be involved in this
decision? So,
if the flag is on, then either go with the allocation site or
NOT_TENURED if the
site isn't found. If the flag is off, then you won't be have a site,
then the
global mode makes sense.
Done.
https://codereview.chromium.org/106453003/diff/60001/src/ic.h
File src/ic.h (right):
https://codereview.chromium.org/106453003/diff/60001/src/ic.h#newcode857
src/ic.h:857: bool CanCreateAllocationMementos() const {
On 2013/12/11 08:15:29, mvstanton wrote:
Change Can to Could, because Should and Could are better matched than
Should and
Can.
Done.
https://codereview.chromium.org/106453003/diff/60001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/106453003/diff/60001/src/objects-inl.h#newcode1364
src/objects-inl.h:1364: type <= FIRST_NONSTRING_TYPE;
On 2013/12/11 08:15:29, mvstanton wrote:
Shouldn't it be < instead of <=? My impression is you want to allow
tracking of
strings.
Done.
https://codereview.chromium.org/106453003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
