Right on, LGTM, with these conditions :)
1) Rebase against the other CL you created in response to earlier feedback,
and
include the asserts provided by that CL, uploading here.
2) Since likely I'll steward this CL into the tree after you leave, do a few
extra tests on it. I'd propose:
a) Run our webkit, mozilla and test262 suites.
b) Run make check on ARM or ia32 without snapshot
c) Build chrome with this change, verify the browser runs and also run the
webkit tests.
That way we could front-load some work.
Thanks!
--Michael
https://codereview.chromium.org/106453003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
