On Wed, 6 May 2026 19:14:30 GMT, Chris Plummer <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> commits since the last revision:
>>
>> - Merge
>> - review: minor spec tweaks
>> - review: minor test tweaks: more checks, remove unneded code, add a
>> comment with assumption
>> - review: use non-identity object instead of value object
>> - review: add explaining comment to new test
>> - fix build error in new test on Windows
>> - review: 1. minor tweaks for spec wording; 2. add note about preview
>> features
>> - 8382702: [lworld] Define VMObjectAlloc behavior for value objects
>
> test/hotspot/jtreg/serviceability/jvmti/valhalla/SampledObjectAllocValue/libSampledObjectAllocValue.cpp
> line 49:
>
>> 47: Java_SampledObjectAllocValue_enableEvents(JNIEnv* jni, jclass klass,
>> jthread thread, jclass tested_class) {
>> 48: if (events_counter != 0) {
>> 49: fatal(jni, "SampledObjectAlloc events counter shouldn be zero");
>
> Suggestion:
>
> fatal(jni, "SampledObjectAlloc events counter should be zero");
Thanks, fixed.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2386#discussion_r3197463835
