On Wed, 6 May 2026 19:11:12 GMT, Chris Plummer <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >> commits since the last revision: >> >> - Merge >> - review: minor spec tweaks >> - review: minor test tweaks: more checks, remove unneded code, add a >> comment with assumption >> - review: use non-identity object instead of value object >> - review: add explaining comment to new test >> - fix build error in new test on Windows >> - review: 1. minor tweaks for spec wording; 2. add note about preview >> features >> - 8382702: [lworld] Define VMObjectAlloc behavior for value objects > > src/hotspot/share/prims/jvmti.xml line 13997: > >> 13995: for some or all of their methods can send this event. >> 13996: When preview features are enabled and an allocated object has >> no identity, >> 13997: <code>null</code> is passed for the <paramlink >> id="object"></paramlink> parameter. > > Suggestion: > > When preview features are enabled and the allocated object has no > identity, > <code>null</code> is passed for the <paramlink id="object"></paramlink> > parameter. Thanks, fixed now. I was thinking about the same but was not sure. :) > src/hotspot/share/prims/jvmti.xml line 14044: > >> 14042: <description> >> 14043: JNI local reference to the object that was allocated. >> 14044: Null when preview features are enabled and an allocated >> object has no identity. > > Suggestion: > > Null when preview features are enabled and the allocated object > has no identity. Fixed now. > src/hotspot/share/prims/jvmti.xml line 14091: > >> 14089: <functionlink id="GetStackTrace"></functionlink>, a user can >> track which objects were allocated from which >> 14090: stack trace, and which are still live during the execution of >> the program. >> 14091: When preview features are enabled and an allocated object has >> no identity, > > Suggestion: > > When preview features are enabled and the allocated object has no > identity, Fixed now. > src/hotspot/share/prims/jvmti.xml line 14118: > >> 14116: <description> >> 14117: JNI local reference to the object that was allocated. >> 14118: Null when preview features are enabled and an allocated >> object has no identity. > > Suggestion: > > Null when preview features are enabled and the allocated object has > no identity. Fixed now. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2386#discussion_r3197499255 PR Review Comment: https://git.openjdk.org/valhalla/pull/2386#discussion_r3197508328 PR Review Comment: https://git.openjdk.org/valhalla/pull/2386#discussion_r3197516020 PR Review Comment: https://git.openjdk.org/valhalla/pull/2386#discussion_r3197511806
