On Wed, 6 May 2026 19:18:01 GMT, Chris Plummer <[email protected]> wrote:
> I wonder to what extent we should be replacing "value" with "non-identity". I
> noticed the JNI update did some cleanup in that regard, but technically it is
> only necessary for things the user is exposed to, not implementation or tests.
I agree, it should be for API's and spec wording only.
> test/hotspot/jtreg/serviceability/jvmti/valhalla/SampledObjectAllocValue/libSampledObjectAllocValue.cpp
> line 70:
>
>> 68: }
>> 69: if (!is_test_class(jvmti, jni, klass)) {
>> 70: return; // interested in tested value class only
>
> Suggestion:
>
> return; // interested in tested non-identity class only
Per our discussion, such changes should not impact impl and tests. But I'll
change it if you want.
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/2386#issuecomment-4392061893
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2386#discussion_r3197439325
