On Thu, 7 May 2026 17:20:22 GMT, Dan Smith <[email protected]> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   review: minor tweaks in spec and comments
>
> src/hotspot/share/prims/jvmti.xml line 13996:
> 
>> 13994:       Virtual machines which are incapable of bytecode instrumentation
>> 13995:       for some or all of their methods can send this event.
>> 13996:       When preview features are enabled and the allocated object has 
>> no identity,
> 
> I would consider saying "is a value object" here. (Depending on what's more 
> relevant: this operation depends on identity, and there's none here; or value 
> objects are a corner case where this operation behaves differently?)
> 
> (Similar throughout.)

(Guess we're already Closed, it may be fine as is.)

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2386#discussion_r3203427900

Reply via email to