On Wed, 6 May 2026 19:13:43 GMT, Chris Plummer <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> commits since the last revision:
>>
>> - Merge
>> - review: minor spec tweaks
>> - review: minor test tweaks: more checks, remove unneded code, add a
>> comment with assumption
>> - review: use non-identity object instead of value object
>> - review: add explaining comment to new test
>> - fix build error in new test on Windows
>> - review: 1. minor tweaks for spec wording; 2. add note about preview
>> features
>> - 8382702: [lworld] Define VMObjectAlloc behavior for value objects
>
> src/hotspot/share/prims/jvmtiExport.cpp line 1140:
>
>> 1138: public:
>> 1139: JvmtiObjectAllocEventMark(JavaThread *thread, oop obj) :
>> JvmtiClassEventMark(thread, oop_to_klass(obj)) {
>> 1140: _jobj = obj->is_inline() ? nullptr : (jobject)to_jobject(obj); //
>> nullptr for value objects
>
> Suggestion:
>
> _jobj = obj->is_inline() ? nullptr : (jobject)to_jobject(obj); //
> nullptr for non-identity objects
Thanks, fixed now. However, it was not necessary per our discussion below. :)
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2386#discussion_r3197530127
