On Wed, 6 May 2026 10:02:32 GMT, Serguei Spitsyn <[email protected]> wrote:

>> This PR implements two JVMTI enhancements: 
>> [8382702](https://bugs.openjdk.org/browse/JDK-8382702) and 
>> [8381063](https://bugs.openjdk.org/browse/JDK-8381063)
>> 
>> The update includes the following changes:
>>  - add spec clarifications for `VMObjectAlloc` and `SampledObjectAlloc` 
>> related to value object allocations
>>  - pass `nullptr` for `jobject` parameter of `VMObjectAlloc` and 
>> `SampledObjectAlloc` event callbacks
>>  - add test coverage with value object allocations for both event callbacks
>> 
>> Testing:
>>  - Test locally with newly added tests
>>  - Run mach5 tiers 1-6
>>  
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Serguei Spitsyn has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains eight additional 
> commits since the last revision:
> 
>  - Merge
>  - review: minor spec tweaks
>  - review: minor test tweaks: more checks, remove unneded code, add a comment 
> with assumption
>  - review: use non-identity object instead of value object
>  - review: add explaining comment to new test
>  - fix build error in new test on Windows
>  - review: 1. minor tweaks for spec wording; 2. add note about preview 
> features
>  - 8382702: [lworld] Define VMObjectAlloc behavior for value objects

I believe, all review comments have been addressed now.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/2386#issuecomment-4392299585

Reply via email to