Felipe Contreras wrote: > On Thu, Dec 31, 2020 at 2:44 AM Christian Brabandt <[email protected]> wrote: > > On Mi, 30 Dez 2020, Felipe Contreras wrote: > > > > > On Wed, Dec 30, 2020 at 6:30 PM Tony Mechelynck > > > <[email protected]> wrote: > > > > > > > > Like Yegappan said, many contributors are mentioned under ":help > > > > credits". > > > > > > I wouldn't say 65 is "many". You can easily find 1843 contributors of git. > > > > I am not sure why you keep mentioning git here. > > Because they do give attribution to each and every single contributor. > So they show it's possible.
This discussion is getting long. Merging PRs using git (which would give credit) is only one way to do it. It's not a must. I assume that PRs are not merged directly using git because Bram often wants to modify changes suggested by contributors. Not sure how additional changes could be done if we were to merge PRs. Bram would have to ask the contributor to make changes until the PR is good enough, but that would take more time and keep CI more busy. Or is there a better way? Bram is the BDFL (Benevolent Dictator For Life) of Vim, as opposed to neovim which is more maintained by a community. Both ways have their pros and cons. Maintenance by a BDFL can ensure a more consistent vision, at the cost of having a bottleneck. Bram has created Vim and has consistently maintained it for decades. It's his project, so he deserves to choose how it's maintained. That said, it's true that changes do not alway get credited, even in the core of vim (not just runtime files). Personally, I don't mind too much, but I can understand that it may upset some people. For example, the following change could have credited Dhiraj Mishra for discovering the bug: === commit 5e1f22ff614821b8fc7294c9dd22765acd403aeb (tag: v8.2.1972) Author: Bram Moolenaar <[email protected]> Date: Tue Nov 10 18:23:52 2020 +0100 patch 8.2.1972: crash when recreating nested fold Problem: Crash when recreating nested fold. Solution: Check for empty growarray. (closes #7278) === In some other cases, missing credit can be because the full name of the contributor is not known (besides his github login name). For runtime files, it's more complex as explained in other replies already. Personally, I think that changes in runtime files could be submitted in with smaller granularity now that we use git, which could then give credit to each change in the git commit, as opposed to updating runtime files every 2 weeks or so with a single commit which includes many changes. But again, it's up to the BDFL :-) Regards Dominique -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CAON-T_hnWJYCkm%2BcwAgohHRbqu4n8inOQmFYiheXWeJYn5TzwQ%40mail.gmail.com.
