On 04/10/2013 11:29 PM, Lucas Meneghel Rodrigues wrote:
On 09/04/13 11:46 PM, Feng Yang wrote:
Github may cannot access in china sometimes. This used to happen
before,
may happens again late. So I want to say that github is not stable
for us.
Well, I'd guess this is a normal outage, like every other site
experiences. Sometimes the github pages and repos have some momentary
trouble, but in this regard, it is still pretty good.
github is not stable not because github issue, but it may blocked by the
Great Fire Wall (GFW) in china.
So we need have another way works, if we want people in china can always
work with our code repo.
Seems email never blocked before.
So Ok, let's say the GWF is on a bad mood and you can't access github.
Then it's OK to send the patches to the ML. Is that OK? You just put
on the cover letter of the patch "Today we can't access github, so
we're sending this through the ML", and we'd be fine.
It is ok for me. I just want to make sure we can always send patches to
upstream tree. BTW, Do we really need add "Today we can't access
github, so we're sending this through the ML"? It seems strange. :-)
send patch with emails has some disadvantage as you list. But it also
have some point make me still use it:
1. Full history is saved in emails. From Archives of the email
list, I
can know all the information happened on this patch, such as the
difference between difference version and why we need a new
version... .
With github seems some information will lost.
The information of the pull requests is still available, no history is
lost, commands in patches always keep their story.
2. With email all the patches will come to my client automatically. I
can comment and test the patch locally. At least I know the patch and
will review the patch summary. Does github can works in this way? If
we have to login web page to review patches. I think some people will
just ignore pull request. Less people care the patches, I think
this is
not what we want.
Once you are subscribed to the project, you'll get notified over email
of the new patches. Downloading is also very easy, a lot easier than
saving the patches from a mail client. You just do:
curl https://github.com/autotest/autotest/pull/621.patch | git am
And test the patch and do whatever you want with it. That's *it*. I
don't get to be constantly irritated with badly formated patches as
well.
For patchwork I always use command like:
for i in 49756 49757 49758 49759 49760 49761 49762 49763 49764 49765; do
/usr/code/patchwork/apps/patchwork/bin/pjw patch mbox -r $i | git am &&
echo $i|| git am --abort; done
or utils/check_patch.py -p 49758, or curl http:/patchwork-mailbox-url
| git am. It's lovely if you work for Red Hat, not so lovely for
external maintainers.
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
