Follow-up Comment #1, patch #3186 (project wesnoth):
I said elsewhere that I would check this patch against the issues that patch
#3133 addresses. In the process, I came up with what may be a nice little test
scenario for this patch.
For the nominal purpose of comparing this to my patch, all one has to do is
run this test scenario and move the leader to the indicated hut (before moving
other units). In the current implementation and in this patch, nothing special
happens. With my patch, an allied unit is spotted.
For the purposes of testing this patch, there are some other things that can
be done in the test scenario. Perhaps the most telling is to (before moving
the leader) move the three non-mounted dwarves as far to the left as possible,
make sure preferences are set to not interrupt movement upon sighting an ally,
then move the leader to the hut. Movement is jerky (the moving unit actually
backtracks at times) as events fire, and the sighted event fires multiple
times.
On the more technical side, when compiling this patch, I got a warning about
an unused parameter:
src/actions.cpp:2447: warning: unused parameter ‘show_move’
Not coincidentally, this patch does not respect the "Skip AI moves"
preference.
(file #15405)
_______________________________________________________
Additional Item Attachment:
File name: 01_Movethrough.cfg Size:3 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?3186>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
