Perhaps I'm suffering from late night drowziness, but if I look at ResourceModel, I don't see the need for wrapping the object.
The assignment is purely for getting the component. I think a better interface name would be INeedMyComponentModel. So resourcemodel.wrapOnAssignment(Component component) would become: public void wrapOnAssignment(Component component) { setComponent(component); } This saves the extra model (== memory). But I might be wrong of course. Martijn On 9/15/06, Johan Compagner <[EMAIL PROTECTED]> wrote: > i don't think we can remove it completely. At specific points i have to know > if the model > i have now in the componet is a wrap model so that i can do things or call > the getNestedModel() > that method getNestedModel() can be removed from IModel if it where me and > added to IWrapModel > > johan > > > > On 9/15/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > > > The outcome of this statement is unclear... Should the IWrapModel go? > It is still there (woogle is down, so I can't search the irc logs, to > find if there was a conclusion) > > Martijn > > On 6/22/06, Igor Vaynberg < [EMAIL PROTECTED]> wrote: > > johan, you are back? > > > > my gut tells me we should start with IModel and then if we run into a > > situation that realy really requires us to know about the wrapper we > should > > introduce iwrapmodel back. > > > > -Igor > > > > > > > > On 6/22/06, Johan Compagner <[EMAIL PROTECTED]> wrote: > > > > > > > no compound is inheritable > > > > And i still don't know if that should really returns a IWrapModel thing or > > just a IModel > > The question is do we really need to know if it is a wrap model in some > > cases. > > Don't know. > > > > johan > > > > > > > > On 6/22/06, Matej Knopp < [EMAIL PROTECTED]> wrote: > > > Btw., ICompoundModel is no longer used, is it? > > > > > > Matej Knopp wrote: > > > > public interface IInheritableModel<T> extends IModel<T> > > > > { > > > > <C> IModel<C> wrapOnInhertance(Component<C> component); > > > > } > > > > > > > > But maybe it makes sense to have a "Marker" interface for inherited > > models. > > > > > > > > -Matej > > > > > > > > Eelco Hillenius wrote: > > > >> getNestedModel was what we plussed on, right? I'm not sure how you > can > > > >> do without IWrapModel though. It's used in several wrapOnxx methods, > > > >> and it's used to keep the parameterized type. I didn't look at it in > a > > > >> lot of detail though, so Igor/ Johan will know that better. > > > >> > > > >> Eelco > > > >> > > > >> > > > >> > > > >> On 6/22/06, Matej Knopp < [EMAIL PROTECTED] > wrote: > > > >>> I also think we should get rid of getNestedModel and IWrapModel. > > > >>> Anyone objects? > > > >>> > > > >>> -Matej > > > >>> > > > >>> Martijn Dashorst wrote: > > > >>>> +1 for 2.0 > > > >>>> > > > >>>> less is more. > > > >>>> > > > >>>> Martijn > > > >>>> > > > >>>> On 6/21/06, Eelco Hillenius <[EMAIL PROTECTED] > wrote: > > > >>>>> If we can can rid of it, all the better. I don't think the > semantics > > > >>>>> are great, and they are covered through other means now. If we > > remove > > > >>>>> getNestedModel, we should also remove > > > >>>>> wicket.Component#sameRootModel(wicket.Component ) and > > > >>>>> wicket.Component#sameRootModel (IModel) and update the > documentation. > > > >>>>> > > > >>>>> Eelco > > > >>>>> > > > >>>>> > > > >>>>> On 6/21/06, Igor Vaynberg < [EMAIL PROTECTED]> wrote: > > > >>>>>> i am also thinking of moving getNestedModel into a separate > > interface > > > >>>>>> because not all models have nested models, and im not even sure > we > > need it > > > >>>>>> period so removing it completely is also an option imho > > > >>>>>> > > > >>>>>> thoughts? > > > >>>>>> > > > >>>>>> -igor > > > >>>>>> > > > >>>>>> > > > >>>>>> > > > >>>>>> On 6/21/06, Matej Knopp < [EMAIL PROTECTED] > wrote: > > > >>>>>>> I'm looking bit deeper and it seems that the semantics of > > IWrapModel is > > > >>>>>>> slightly different than I though, so just silently ignore the > > question :) > > > >>>>>>> > > > >>>>>>> Matej Knopp wrote: > > > >>>>>>>> Sorry, I meant getNestedModel of course (as there's no such > thing > > as > > > >>>>>>>> getWrappedModel). > > > >>>>>>>> > > > >>>>>>>> Matej Knopp wrote: > > > >>>>>>>>> Hi, > > > >>>>>>>>> > > > >>>>>>>>> I'm going through the big model change in 2.0 and I noticed > that > > now we > > > >>>>>>>>> have IWrapModel, but IModel still contains getWrappedModel(). > > > >>>>>>>>> > > > >>>>>>>>> Wouldn't it be cleaner if the getWrappedModel was a member of > > > >>>>>> IWrapModel? > > > >>>>>>>>> -Matej > > > >>>>>>>>> > > > >>>>>>>>> > > > >>>>>>>>> > _______________________________________________ > > > >>>>>>>>> Wicket-develop mailing list > > > >>>>>>>>> Wicket-develop@lists.sourceforge.net > > > >>>>>>>>> > > > >>>>>> > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > >>>>>>>> > _______________________________________________ > > > >>>>>>>> Wicket-develop mailing list > > > >>>>>>>> Wicket-develop@lists.sourceforge.net > > > >>>>>>>> > > > >>>>>> > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > >>>>>>> _______________________________________________ > > > >>>>>>> Wicket-develop mailing list > > > >>>>>>> Wicket-develop@lists.sourceforge.net > > > >>>>>>> > > > >>>>>> > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > >>>>>> > > > >>>>>> > > > >>>>>> > > > >>>>>> _______________________________________________ > > > >>>>>> Wicket-develop mailing list > > > >>>>>> Wicket-develop@lists.sourceforge.net > > > >>>>>> > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > >>>>>> > > > >>>>>> > > > >>>>>> > > > >>>>> _______________________________________________ > > > >>>>> Wicket-develop mailing list > > > >>>>> Wicket-develop@lists.sourceforge.net > > > >>>>> > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > >>>>> > > > >>> All the advantages of Linux Managed Hosting--Without the Cost and > > Risk! > > > >>> Fully trained technicians. The highest number of Red Hat > > certifications in > > > >>> the hosting industry. Fanatical Support. Click to learn more > > > >>> > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 > > > >>> _______________________________________________ > > > >>> Wicket-develop mailing list > > > >>> Wicket-develop@lists.sourceforge.net > > > >>> > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > >>> > > > >> All the advantages of Linux Managed Hosting--Without the Cost and > Risk! > > > >> Fully trained technicians. The highest number of Red Hat > certifications > > in > > > >> the hosting industry. Fanatical Support. Click to learn more > > > >> > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 > > > >> _______________________________________________ > > > >> Wicket-develop mailing list > > > >> Wicket-develop@lists.sourceforge.net > > > >> > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > >> > > > > > > > > > > > > All the advantages of Linux Managed Hosting--Without the Cost and > Risk! > > > > Fully trained technicians. The highest number of Red Hat > certifications > > in > > > > the hosting industry. Fanatical Support. Click to learn more > > > > > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 > > > > _______________________________________________ > > > > Wicket-develop mailing list > > > > Wicket-develop@lists.sourceforge.net > > > > > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > > > > > > > All the advantages of Linux Managed Hosting--Without the Cost and Risk! > > > Fully trained technicians. The highest number of Red Hat certifications > in > > > the hosting industry. Fanatical Support. Click to learn more > > > > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 > > > _______________________________________________ > > > Wicket-develop mailing list > > > Wicket-develop@lists.sourceforge.net > > > > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > > > Using Tomcat but need to do more? Need to support web services, security? > > Get stuff done quickly with pre-integrated technology to make your job > > easier > > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > > > > > > > _______________________________________________ > > Wicket-develop mailing list > > Wicket-develop@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > > > > > > Using Tomcat but need to do more? Need to support web services, security? > > Get stuff done quickly with pre-integrated technology to make your job > > easier > > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > > > > > _______________________________________________ > > Wicket-develop mailing list > > Wicket-develop@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > > > -- > Download Wicket 1.2.2 now! New Ajax components: Tree, TreeTable and > ModalWindow > -- http://wicketframework.org > > ------------------------------------------------------------------------- > > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job > easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > _______________________________________________ > Wicket-develop mailing list > Wicket-develop@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job > easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > _______________________________________________ > Wicket-develop mailing list > Wicket-develop@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > -- Download Wicket 1.2.2 now! New Ajax components: Tree, TreeTable and ModalWindow -- http://wicketframework.org ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop