User "Krinkle" posted a comment on MediaWiki.r91518.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91518#c21693
Commit summary:
(bug 6100; follow-up to r91315) Being bold and removing $wgBetterDirectionality
(and dependent wfUILang) in core, as most or all work is finished.
Also:
* Introduce classes mw-float-end, mw-float-start so we don't have to use inline
css depending on wfUILang()/$wgLang (see HistoryPage and
SpecialFileDuplicateSearch)
* Add direction mark to protection log
* Remove specialpageattributes as it is obsoleted by this commit (also fixes
bug 28572)
* Add two direction marks in wfSpecialList, which makes ltr links on rtl wiki
(and vice versa) display nicely as well (only on those special pages however)
* Revert r91340 partially: use mw-content-ltr/rtl class anyway in shared.css.
Both ways have their [dis]advantages...
* Set the direction of input fields by default to the content language
direction (except buttons etc.) in shared.css
Comment:
Regarding the [{{ViewVC|trunk/phase3/skins/common/shared.css|91517|91518}}
changes to shared.css in this commit]
What is the point of having selectors like these:
<pre>
.foo-ltr,
.foo-rtl .foo-ltr {
something: for ltr userlang;
}
</pre>
A lot of the power of CSS comes down to assigning priority/points to each
selector and using those for each element separately. A more specific selector
always has a higher value. For that reason, afaik, there is no reason to have
both here, just <code>.foo-ltr</code> is sufficient.
Check the
[http://translatewiki.net/wiki/User:Krinkle/i18n-css-selectors?withCSS=MediaWiki:Gadget-i18n-selector-highlighting.css
demo on translatewiki.net] showing nested elements like this without the need
to 'override' that styling.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
