User "SPQRobin" posted a comment on MediaWiki.r91518. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91518#c22480 Commit summary:
(bug 6100; follow-up to r91315) Being bold and removing $wgBetterDirectionality (and dependent wfUILang) in core, as most or all work is finished. Also: * Introduce classes mw-float-end, mw-float-start so we don't have to use inline css depending on wfUILang()/$wgLang (see HistoryPage and SpecialFileDuplicateSearch) * Add direction mark to protection log * Remove specialpageattributes as it is obsoleted by this commit (also fixes bug 28572) * Add two direction marks in wfSpecialList, which makes ltr links on rtl wiki (and vice versa) display nicely as well (only on those special pages however) * Revert r91340 partially: use mw-content-ltr/rtl class anyway in shared.css. Both ways have their [dis]advantages... * Set the direction of input fields by default to the content language direction (except buttons etc.) in shared.css Comment: Nobody who used MediaWiki with the RTL improvements ever made an issue about special pages, history pages and log snippets being "broken". (Even then, a lot of the work is done, not just a small fraction. It's way better than it was before.) History lists and log entries are mostly in the user languages, with only the edit summary being in the content language (presumably). It does not make sense to align these lists to the content direction, this would be incorrect for the text in the user language. Having it aligned to the user language direction is in my POV a usability advantage as well. It should rather be the improvements in HTML5 that should be implemented in browsers. From a MediaWiki perspective, we have good bidi support. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
