User "SPQRobin" posted a comment on MediaWiki.r91518. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91518#c22327 Commit summary:
(bug 6100; follow-up to r91315) Being bold and removing $wgBetterDirectionality (and dependent wfUILang) in core, as most or all work is finished. Also: * Introduce classes mw-float-end, mw-float-start so we don't have to use inline css depending on wfUILang()/$wgLang (see HistoryPage and SpecialFileDuplicateSearch) * Add direction mark to protection log * Remove specialpageattributes as it is obsoleted by this commit (also fixes bug 28572) * Add two direction marks in wfSpecialList, which makes ltr links on rtl wiki (and vice versa) display nicely as well (only on those special pages however) * Revert r91340 partially: use mw-content-ltr/rtl class anyway in shared.css. Both ways have their [dis]advantages... * Set the direction of input fields by default to the content language direction (except buttons etc.) in shared.css Comment: The .foo-ltr .foo-rtl is needed for the CSS to override the .foo-ltr CSS. I added list items to your page, so that you can see that. The whole page has a "mw-content-ltr" class, which gets the styling. When using a "mw-content-rtl" class within that page (when a certain page is RTL but wgContLang is LTR, such as on translatewiki), the styling of .mw-content-ltr .mw-content-rtl is used. You can see that on the third level (ltr > rtl > ltr), the list does not display properly because there is no .mw-content-ltr .mw-content-rtl .mw-content-ltr (which is not needed obviously, as you should use the first level). This should probably remain until we can properly [[bugzilla:28970|mark the page language/direction]]. (Even then, it may be useful to have RTL text within a LTR page and vice versa). I know I added relatively much CSS, but I did not find a good way to do it otherwise. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
