User "Amire80" posted a comment on MediaWiki.r91518. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91518#c22612 Commit summary:
(bug 6100; follow-up to r91315) Being bold and removing $wgBetterDirectionality (and dependent wfUILang) in core, as most or all work is finished. Also: * Introduce classes mw-float-end, mw-float-start so we don't have to use inline css depending on wfUILang()/$wgLang (see HistoryPage and SpecialFileDuplicateSearch) * Add direction mark to protection log * Remove specialpageattributes as it is obsoleted by this commit (also fixes bug 28572) * Add two direction marks in wfSpecialList, which makes ltr links on rtl wiki (and vice versa) display nicely as well (only on those special pages however) * Revert r91340 partially: use mw-content-ltr/rtl class anyway in shared.css. Both ways have their [dis]advantages... * Set the direction of input fields by default to the content language direction (except buttons etc.) in shared.css Comment: I just looked at all the special pages at TranslateWiki with Hebrew as my interface and i didn't find practically any huge problems. I only found minor problems at these pages: * The first three items at http://translatewiki.net/wiki/Special:UncategorizedTemplates are a bit broken. (although http://translatewiki.net/wiki/Special:UnusedTemplates is OK.) This is low priority. * http://translatewiki.net/wiki/Special:Properties - low priority. * http://translatewiki.net/wiki/Special:Categories - normal priority. * http://translatewiki.net/wiki/Special:Templates - normal priority. * http://translatewiki.net/wiki/Special:BlockList - some edit summaries are broken on Firefox, but better on Chrome, thanks to dir="auto". That is good enough. * http://translatewiki.net/wiki/Special:ActiveUsers - it's broken locally on TranslateWiki, but fine on a clean install. * http://translatewiki.net/wiki/Special:RecentChanges - somewhat broken here and there, but generally readable. dir="auto" is the way to go for summaries. So either i am misunderstanding something or the current problems are really minor. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
