User "Catrope" posted a comment on MediaWiki.r91518. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91518#c22517 Commit summary:
(bug 6100; follow-up to r91315) Being bold and removing $wgBetterDirectionality (and dependent wfUILang) in core, as most or all work is finished. Also: * Introduce classes mw-float-end, mw-float-start so we don't have to use inline css depending on wfUILang()/$wgLang (see HistoryPage and SpecialFileDuplicateSearch) * Add direction mark to protection log * Remove specialpageattributes as it is obsoleted by this commit (also fixes bug 28572) * Add two direction marks in wfSpecialList, which makes ltr links on rtl wiki (and vice versa) display nicely as well (only on those special pages however) * Revert r91340 partially: use mw-content-ltr/rtl class anyway in shared.css. Both ways have their [dis]advantages... * Set the direction of input fields by default to the content language direction (except buttons etc.) in shared.css Comment: <blockquote> History lists and log entries are mostly in the user languages, with only the edit summary being in the content language (presumably). It does not make sense to align these lists to the content direction, this would be incorrect for the text in the user language. Having it aligned to the user language direction is in my POV a usability advantage as well. </blockquote> That's not what Tim was suggesting. If I read his comment, and the surrounding sentiment on IRC at the time, correctly, what he meant was that the directionality of the interface as a whole is correct, it's just that things like edit summaries need to be wrapped in spans that give them the directionality of the content language, not of the user language. Other things that need content language directionality but don't currently have it are page titles (most special pages have the content directionality for the text box where you can type page titles, but display the titles in user directionality where they appear in lists etc. Whatlinkshere is a good example of this inconsistent behavior) and user names (except IPs, maybe? What's the "right" way to display an IP address in an RTL language? I see how things could get very confusing if they're displayed the wrong way around). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
