User "Tim Starling" posted a comment on MediaWiki.r91518. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91518#c22431 Commit summary:
(bug 6100; follow-up to r91315) Being bold and removing $wgBetterDirectionality (and dependent wfUILang) in core, as most or all work is finished. Also: * Introduce classes mw-float-end, mw-float-start so we don't have to use inline css depending on wfUILang()/$wgLang (see HistoryPage and SpecialFileDuplicateSearch) * Add direction mark to protection log * Remove specialpageattributes as it is obsoleted by this commit (also fixes bug 28572) * Add two direction marks in wfSpecialList, which makes ltr links on rtl wiki (and vice versa) display nicely as well (only on those special pages however) * Revert r91340 partially: use mw-content-ltr/rtl class anyway in shared.css. Both ways have their [dis]advantages... * Set the direction of input fields by default to the content language direction (except buttons etc.) in shared.css Comment: Setting a correct direction on elements that contain RTL text is what this project is all about. If you set the wrong direction, the effect ranges from nothing at all to total unreadable breakage, depending on the text that the element contains. The first things to go are the punctuation characters, they are like canaries. Because you can't tell what direction most of the elements have just by looking at them, to test this feature, I had to develop a special debugging tool to indicate text direction. I committed it just now to extensions/RTLDebug. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
