https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13950

Stig Bjørlykke <s...@bjorlykke.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |s...@bjorlykke.org

--- Comment #7 from Stig Bjørlykke <s...@bjorlykke.org> ---
(In reply to Mike Baker from comment #0)
> The first error
> References a dissector named dsmcc_dissector.lua, and line 40 has the
> following lua code:
> ServerInteractiveSessionRequest.fields.sessionId =
> ProtoField.bytes("dsmcc.sessionId", "sessionId", base.HEX, nil, nil)
> 
> Referencing the following LUA API link, base.HEX appears to be valid:
> https://www.wireshark.org/docs/wsdg_html_chunked/lua_module_Proto.html

You should look at the correct method in the documentation:
11.6.7.20. ProtoField.bytes

The documentation for ProtoField.new is a bit more generic but should be
updated to reflect the changes for ftypes.BYTES (and ftypes.UINT_BYTES).


Backward compatibility is important in our Lua implementation, and I understand
why it's reasonable to use base.HEX for ProtoField.bytes.  I will add support
for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___________________________________________________________________________
Sent via:    Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
             mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

Reply via email to