On 05/08/2013 19:54, Edson W. R. Pereira wrote:
Hi Edson,
John,

On Mon, Aug 5, 2013 at 3:03 PM, John Nogatch <[email protected] <mailto:[email protected]>> wrote:


    2. Detector.cpp:44:95: error: no matching function for call to
    'min(long long unsigned int, size_t)'
       As a work-around, I inserted a cast, but it would be better if both
    expressions were of type size_t.
      qint64 framesAccepted (std::min (maxSize / sizeof (jt9com_.d2[0]),
    (long long unsigned int) framesAcceptable));
       Even after that cast is inserted on line 44, gcc warns about
    line 46:
         if (framesAccepted < maxSize / sizeof (jt9com_.d2[0]))
    Detector.cpp: In member function 'virtual qint64
    Detector::writeData(const char*, qint64)':
    Detector.cpp:46:55: warning: comparison between signed and unsigned
    integer expressions [-Wsign-compare]


I had to do the same change here.

Bill, may I suggest we use the native Qt functions in QtGlobals (min, max, rand, etc) as much as possible instead of using the STL? This will help us keep the code tidy.

http://qt-project.org/doc/qt-5.1/qtcore/qtglobal.html

Will do. I'm too used to using standard C++ library, on auto pilot.

73,

-- Edson
73
Bill
G4WJS.
_______________________________________________
Wsjt-devel mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/wsjt-devel

Reply via email to