On 22/10/2016 20:19, Black Michael wrote:
This is a complete patch for remembering power levels for transmit and
tune separately.
Option placed in the Radio tab (seemed to make sense since it does
affect the rig operation).
Updated the user guide and also have a new snapshot of the RadioTab.
Hi Mike,
several issues with that proposed patch.
Breaking a UI layout is a temporary situation, you must have all widgets
and layouts within other widgets or layouts otherwise the UI will not
display correctly when being resized nor on different operating systems,
window managers, font sizes, or screen resolutions. Breaking a layout is
not really required unless you are going to change the type of the
layouts and it is usually much more work to rebuild the layouts after
breaking than it is to drag and drop around existing and new widgets or
layouts.
I would suggest that this proposal should use the audio tab for any
settings widgets for power. This is better as it does not increase the
overall size of the Settings dialog and is probably more relevant there
anyway.
You can save and restore a QHash object instance to the QSettings
container, there is no need to break it down into component elements.
Having said that it does require some extra work to register the
required meta-type with Qt so it may be easier to stick to types that
QSettings already understands which is anything that can be represented
as a QVariant. QVariant has a conversion to QHash<QString, QVariant> and
also to QMap<QString, QVariant> either of which are basically drop in
replacements for your QHash<QString, int> data structures.
I see no reason for using global variables for the data structures
above. Global variables have no place in C++ applications.
I don't think finding the current power setting 10 times per second is
warranted i.e. in the MainWindow::guiUpdate() slot, Qt is event driven
and you should find a way to do the required work only when needed e.g.
when the band is changed or the "Pwr" slider is moved.
The tool tip for the "Pwr" attenuation setting seems to have been removed.
We always leave the "Settings->General" tab as the default selected tab,
you do that by selecting it before saving any Designer changes to the
Settings UI file.
That's all I have had time to review but I think this needs more work
before being acceptable.
73
Bill
G4WJS.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel
