Hi Mike,
some comments in line below.
On 24/10/2016 23:39, Black Michael wrote:
2nd attempt addressing your points.
Thanks fro reworking that, I see that Joe has committed your patch with
some minor amendments.
I think the layout on the Audio tab is OK. You'll want to
double-check that one for sure as I find multiple layouts quite confusing.
The layout was still broken. It is a bit complicated getting a handle on
how to build a UI using layout managers and widgets. When you do get it
right you know it because everything suddenly starts to behave sensibly
when you resize the outer window. Another clue is that there should be
no need for explicit positions or sizes of widgets except in exceptional
circumstances.
In this case you had not assigned a layout to the group box you added to
contain the two power setting check boxes. Qt Designer will
automatically add a layout to a widget when you right click the widget
and select the appropriate "Lay out" context menu item. If no layout is
assigned then all four of Horizontal, Vertical, Form and Grid will be
available, if one is greyed out then it that type of layout is already
assigned. For the group box in question you had free hand positioned the
two check boxes, once a horizontal layout for the group box widget is
set, the contents then get laid out automatically. The key point here is
that explicit positioning is very unlikely to be correct when any of
platform, window manager, screen resolution, window size or font is
changed. As I stated before, all widgets should be managed by a layout
manager and all widgets that contain other widgets should have a layout
manager into which contained widgets or other layouts are added.
All seems to behave well for me.
Not for me. When resizing the settings window I saw the main tab panel
not resizing in sync and widgets on the right were being occluded by the
window right hand edge. Some of this may have been due to Joe's attempts
to fix up the broken layouts.
I also corrected the tab ordering to a reasonably intuitive sequence
following the positional flow of the widgets within the various top
level tabs. This is usually needed when maintaining widgets, it is a bit
tedious but at least Qt Designer allows you to start of from the first
incorrectly sequenced item and continue to the last item.
One thing noted is that tuning stop is called twice (was driving me
nuts until figured that one out). I put some logic in so it only
executes once per state change.
With event driven code it is pretty common for events to be triggered
multiple times, event handlers (slots in Qt terminology) where possible
should be written in a stateless way with respect to inputs so that
multiple calls do not have undesired side effects.
73
Bill
G4WJS.
------------------------------------------------------------------------------
The Command Line: Reinvented for Modern Developers
Did the resurgence of CLI tooling catch you by surprise?
Reconnect with the command line and become more productive.
Learn the new .NET and ASP.NET CLI. Get your free copy!
http://sdm.link/telerik
_______________________________________________
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel
