On 15/08/2019 16:19, Wieczorkiewicz, Pawel wrote:
Hi Lars, Julien,

Hi,

Thanks for the pointers, I will read them up and follow the recommendations with my future contributions.
Sorry for the mess…

But, let me ask first before reading the wikis, how do you prefer submitting series that contain patches belonging to 2 distinct repos (e.g. xen and livepatch-build-tools)?

I can see two ways:

1) One series per project and mention in the cover letter that modifications are required in another project (with link/title). 2) Combine all the patches in one series and tag them differently. I.e [XEN] [LIVEPATCH].

1) is preferable if you have a lot of patches in each repo. 2) can be handy if you have only a couple of patches for one repo.

Cheers,


Best Regards,
Pawel Wieczorkiewicz



On 15. Aug 2019, at 16:58, Lars Kurth <lars.kurth....@gmail.com <mailto:lars.kurth....@gmail.com>> wrote:



On 15 Aug 2019, at 12:38, Julien Grall <julien.gr...@arm.com <mailto:julien.gr...@arm.com>> wrote:

Hi,

I am not going to answer on the patch itself but the process.

Any series (i.e more than one patch) should contain a cover letter with a rough summary of the goal of the series.

Furthermore, this 3 patches series has been received as 3 separate threads (i.e in-reply-to is missing). This is making difficult to know that all the patches belongs to the same series. In general, all patches are send as in-reply-to the cover letter. So all the patches sticks together in one thread.

The cover letter can be generated via git format-patch --cover-letter. Threading is done automatically with git-send-email when all the patches as passed in arguments.

For more details how to do it, you can read:

https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Sending_a_Patch_Series

Cheers,

Hi Pawel,

thank you for submitting the patch series.

We had a couple of new starters recently who followed a similar pattern to you. As a result of this, I recently updated the following docs

https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches - Definitions and general workflow The bit which saves the most work is https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Sending_a_Patch_Series As for Julien's comment on the threading: see the --thread and --cover-letter option as described in the Sending a Patch Series

https://wiki.xenproject.org/wiki/Managing_Xen_Patches_with_Git - Basic Git commands fitting into the workflow, including how to deal with reviews https://wiki.xenproject.org/wiki/Managing_Xen_Patches_with_StGit - Basic StGit commands fitting into the workflow, including how to deal with reviews I have not had time to play with git series yet. If anyone in your team uses it let me know

In any case: if you follow the instructions the entire submission process and dealing with review comments becomes much easier.

As a newcomer, to contributing to Xen, I would greatly appreciate if you could let me know of any issues with the docs, such that we can fix them

Regards
Lars







Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879



--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to