[ 
https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115458#comment-16115458
 ] 

Hadoop QA commented on YARN-6933:
---------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  5s{color} 
| {color:red} YARN-6933 does not apply to YARN-3926. Rebase required? Wrong 
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | YARN-6933 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12880525/YARN-6933-YARN-3926.001.patch
 |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/16720/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() 
> are duplicating work
> -----------------------------------------------------------------------------------------------
>
>                 Key: YARN-6933
>                 URL: https://issues.apache.org/jira/browse/YARN-6933
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: YARN-3926
>            Reporter: Daniel Templeton
>            Assignee: Manikandan R
>              Labels: newbie++
>         Attachments: YARN-6933-YARN-3926.001.patch
>
>
> Both are used to check that the mandatory resources were not redefined.  Only 
> one check is needed.  I would recommend dropping {{DISALLOWED_RESOURCES}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to