[
https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129145#comment-16129145
]
Manikandan R commented on YARN-6933:
------------------------------------
[~sunilg] Currently {{ResourceUtils#checkMandatoryResources}} does 2 checks -
units and resource type (for ex, countable) only if {{resourceInformationMap}}
has MEMORY_MB and VCORES. Otherwise, not. Given that we don't want to define
the constants, Is doing resource type check for "memory" good enough only when
map has this key? Inaddition, do we need to add "memory" in
{{addMandatoryResources()}} method if it is not there like other params? In
general, Are we treating "memory" as mandatory resources?
> ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources()
> are duplicating work
> -----------------------------------------------------------------------------------------------
>
> Key: YARN-6933
> URL: https://issues.apache.org/jira/browse/YARN-6933
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: YARN-3926
> Reporter: Daniel Templeton
> Assignee: Manikandan R
> Labels: newbie++
> Attachments: YARN-6933-YARN-3926.001.patch,
> YARN-6933-YARN-3926.002.patch, YARN-6933-YARN-3926.003.patch
>
>
> Both are used to check that the mandatory resources were not redefined. Only
> one check is needed. I would recommend dropping {{DISALLOWED_RESOURCES}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
