[
https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115805#comment-16115805
]
Manikandan R commented on YARN-6933:
------------------------------------
[[email protected]] Thanks.
{quote}You should also be able to delete DISALLOWED_NAMES, since that was the
only place it was used{quote}
Ok, will do.
{quote}Why the change in the test file? I should expect that setting the units
to nothing for memory would be an error, since memory expects "Mi" as the
units.{quote}
{{checkMandatoryResources}} does this check only for "memory-mb" and "vcores"
resources. I thought purpose of {code}String[] mem3 = { "memory", "" };{code}
test case is to ensure DISALLOWED_NAMES check functionality because it was
failing there only. However, I modified the test case input to "memory-mb" to
cover your case. or Am i missing anything?
Rebased my working copy and attached patch for review.
> ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources()
> are duplicating work
> -----------------------------------------------------------------------------------------------
>
> Key: YARN-6933
> URL: https://issues.apache.org/jira/browse/YARN-6933
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: YARN-3926
> Reporter: Daniel Templeton
> Assignee: Manikandan R
> Labels: newbie++
> Attachments: YARN-6933-YARN-3926.001.patch,
> YARN-6933-YARN-3926.002.patch
>
>
> Both are used to check that the mandatory resources were not redefined. Only
> one check is needed. I would recommend dropping {{DISALLOWED_RESOURCES}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
