[
https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126094#comment-16126094
]
Manikandan R commented on YARN-6933:
------------------------------------
[~sunilg] Thanks for the review.
1. I was under the impression only memory-mb and vcores are mandatory
resources. Will do check even for "memory". Need to define constant in
{{ResourceInformation}}. Shall I define "M" as default for "memory"?
2. Yes, will need to fix.
3. vcores default unit is empty string (""). It is intentional pass to produce
the error case.
4. Yes, we will need to do changes in junits accordingly.
> ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources()
> are duplicating work
> -----------------------------------------------------------------------------------------------
>
> Key: YARN-6933
> URL: https://issues.apache.org/jira/browse/YARN-6933
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: YARN-3926
> Reporter: Daniel Templeton
> Assignee: Manikandan R
> Labels: newbie++
> Attachments: YARN-6933-YARN-3926.001.patch,
> YARN-6933-YARN-3926.002.patch, YARN-6933-YARN-3926.003.patch
>
>
> Both are used to check that the mandatory resources were not redefined. Only
> one check is needed. I would recommend dropping {{DISALLOWED_RESOURCES}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
