[ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131872#comment-16131872 ]
Manikandan R commented on YARN-6933: ------------------------------------ [~sunilg] Thanks for very detailed explanation. Uploaded a new patch which will not allow "memory" resource from both users and admin configuration. Since {{checkMandatoryResources}} being called from {{getNodeResourceInformation}} method, even if admin configures "memory" as part of node resources, it will not be allowed. 1. Taken care 2. I was wrong here in my last response. It has been kept intentionally to ensure below block is working fine {code} if (resourceInformationMap.containsKey(resourceName)) { throw new YarnRuntimeException( "Error in config, key '" + resourceName + "' specified twice"); } {code} 3. vcores default unit is empty string (""). Passing as "G" is intentional to produce the error case. 4. Taken care > ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() > are duplicating work > ----------------------------------------------------------------------------------------------- > > Key: YARN-6933 > URL: https://issues.apache.org/jira/browse/YARN-6933 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Affects Versions: YARN-3926 > Reporter: Daniel Templeton > Assignee: Manikandan R > Labels: newbie++ > Attachments: YARN-6933-YARN-3926.001.patch, > YARN-6933-YARN-3926.002.patch, YARN-6933-YARN-3926.003.patch, > YARN-6933-YARN-3926.004.patch > > > Both are used to check that the mandatory resources were not redefined. Only > one check is needed. I would recommend dropping {{DISALLOWED_RESOURCES}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org