On 2013-02-08 19:04:41, Ignas Anikevičius wrote: > On 8 February 2013 18:04, Sebastian Ramacher <sebasti...@pwmt.org> wrote: > > On 2013-02-08 18:02:27, Sebastian Ramacher wrote: > >> > From a99e05179420ad27c0dce54b3661602615e530de Mon Sep 17 00:00:00 2001 > >> > From: "Ignas Anikevicius (gns_ank)" <anikevic...@gmail.com> > >> > Date: Fri, 8 Feb 2013 14:17:38 +0000 > >> > Subject: [PATCH 3/4] Remove g_thread_init from main.c > >> > > >> > g_thread_init is no longer needed as glib is taking care of it > >> > automatically. > >> > >> For which versions of glib is this the case? If that's not true for all > >> versions, an #if block around the g_thread_init call with a version check > >> would be more appropriate. > > > > Okay, so that's only 2.31 and newer. I'll add the version checks around > > it. > > Just checked it, only glib 2.32 onwards is supported according to the > README [1]. So is the if block really necessary? The same is for > master. [2]
Neither the code nor the build system enforce glib >= 2.32. I'm not going to break compatibility with older glib versions just because of a call to a deprecated function that's a no-op in newer versions of glib. Regards -- Sebastian Ramacher
signature.asc
Description: Digital signature
_______________________________________________ zathura mailing list zathura@lists.pwmt.org http://lists.pwmt.org/mailman/listinfo/zathura