-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Chris Withers wrote:
> Florent Guillaume wrote:
> 
>>>> Specifically, in CMFCatalogAware.reindexObjectSecurity (recently
>>>> introduced by Florent Guillaume if I recall), it assumes getObject()
>>>> will return None in a failure.
>>>
>>>
>>> Yes, see http://www.zope.org/Collectors/CMF/337 which I'm about to fix.
> 
> 
> This is a bad fix IMNSHO :-(
> 
> Why was getObject not returning an object?
> 
> That condition has been accepted for far too long and, reading the rest
> of the thread here, seems to be a bug in this case.
> 
> Furthermore, rather than effectively re-implementing getObject in CMF
> code, why didn't we just catch the exceptions that are now being raised?
> 
> Anyone mind if I revert this checking?

Yes, I mind.

Chris, you need to get off this hobby horse.  Florent's fix was correct
for the *new* model which has 'getObject' raising (a model you profess
to *like*).

Bugs in the catalog itself, in BTrees, in the CMF, or in third-party
software can leave cruft in the catalog:  robust code *has* to deal with
that problem.


Tres.
- --
===============================================================
Tres Seaver                                [EMAIL PROTECTED]
Zope Corporation      "Zope Dealers"       http://www.zope.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCZmsTGqWXf00rNCgRAoSaAJ90RjyuGvkhpMdMzBHZzdbxGirauQCfecoN
wX6pHMBB5TSm8+YhM3ZJom4=
=WlUV
-----END PGP SIGNATURE-----
_______________________________________________
Zope-CMF maillist  -  Zope-CMF@lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

Reply via email to