As quoted from Andreas Hocevar <[EMAIL PROTECTED]>:
> > -MapPaneOL.prototype.getLayer = function(objRef,layerName) {
> > -  return objRef.model.map.getLayer(objRef.oLlayers[layerName].id);
> > +MapPaneOL.prototype.getLayer = function(objRef,layerId) {
> > +  if(objRef.oLlayers[layerId] && objRef.oLlayers[layerId].id) {
> > +    return objRef.model.map.getLayer(objRef.oLlayers[layerId].id);
> > +  } else {
> > +    return false;
> > +  }
> 
> Just saw that this was also in the code before your changes. There
> must be a thing I am missing, maybe you (or anyone else) can explain
> where this .id thing comes from.

svn blame/praise/annotate [pick your favourite] on trunk says:

  3607     rdewit MapPaneOL.prototype.getLayer = function(objRef,layerId) {
  3607     rdewit   if(objRef.oLlayers[layerId] && objRef.oLlayers[layerId].id) 
{
  3607     rdewit     return 
objRef.model.map.getLayer(objRef.oLlayers[layerId].id);
  3607     rdewit   } else {
  3607     rdewit     return false;
  3607     rdewit   }

and svn blame -r3606 says:

  2956     steven MapPaneOL.prototype.getLayer = function(objRef,layerName) {
  2956     steven   return 
objRef.model.map.getLayer(objRef.oLlayers[layerName].id);

which to me indicates that the change in this function was indeed
introduced by Roald.  As long as this function is backwards compatible
with the old behaviour this change is fine by me.

Regards,
-- 
-- Gertjan van Oosten, [EMAIL PROTECTED], West Consulting B.V., +31 15 2191 600

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
mapbuilder-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel

Reply via email to