Hi,

On Nov 22, 2007 1:49 PM, Roald de Wit (Sourceforge)
<[EMAIL PROTECTED]> wrote:
> However, just looking at what you wrote below would tell me that I have
> been slack in changing the reference to layerId where you see layerName in
> moveLayerDown. That surprises me since I put some effort into assuring
> that I did this everywhere. I must have overlooked it.

Sorry Roald, I was looking at the old code here, and I was referring
to the ".id" part. But after looking at it again two times, I now know
that this works (although it is bad code, but not your code). For
others, the piece of code in question is still qouted below this
posting.

Ok, to sum up: after testing you get a +1 from me for adding your
changes in the 1_5 branch, but I want the opinion of others on how to
handle Web Map Context (Context.js), where @id is not part of the
specification.

Regards,
Andreas.

> >> -MapPaneOL.prototype.getLayer = function(objRef,layerName) {
> >> -  return objRef.model.map.getLayer(objRef.oLlayers[layerName].id);
> >> +MapPaneOL.prototype.getLayer = function(objRef,layerId) {
> >> +  if(objRef.oLlayers[layerId] && objRef.oLlayers[layerId].id) {
> >> +    return objRef.model.map.getLayer(objRef.oLlayers[layerId].id);
> >> +  } else {
> >> +    return false;
> >> +  }
> >
> > Just saw that this was also in the code before your changes. There
> > must be a thing I am missing, maybe you (or anyone else) can explain
> > where this .id thing comes from. To me it looks like getLayer cannot
> > work because of this.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
mapbuilder-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel

Reply via email to