Hi Roald,
so you really want to have that baby in the 1.5 release. Here is a
detailled review.
lib/model/Context.js
The layer id was only introduced for OWSContext, not for Web Map
Context. So maybe Context.js should not be touched. If you revert
Context.js, and all examples still work, I would see this as a prove
that your changes are really backwards compatible.
lib/model/OWSContext.js
Looks good.
lib/widget/LayerControl.js
These are only rename changes and do not affect functionality. Good.
lib/widget/LayerControl.xsl
diff is hard to read, but looks good.
lib/widget/LayerControlSld.xsl
only renames and added fallback. Looks good.
lib/widget/MapPaneOL.js
-MapPaneOL.prototype.getLayer = function(objRef,layerName) {
- return objRef.model.map.getLayer(objRef.oLlayers[layerName].id);
+MapPaneOL.prototype.getLayer = function(objRef,layerId) {
+ if(objRef.oLlayers[layerId] && objRef.oLlayers[layerId].id) {
+ return objRef.model.map.getLayer(objRef.oLlayers[layerId].id);
+ } else {
+ return false;
+ }
I do not think that this will work. You never set
objRef.oLlayers[layerName].id. Please explain, maybe I am missing
something here.
-MapPaneOL.prototype.moveLayerUp = function(objRef, layerName) {
+MapPaneOL.prototype.moveLayerUp = function(objRef, layerId) {
var map=objRef.model.map;
- map.raiseLayer(objRef.oLlayers[layerName], 1);
+ map.raiseLayer(map.getLayer(objRef.oLlayers[layerId].id), 1);
Same here.
On Nov 22, 2007 6:31 AM, Roald de Wit <[EMAIL PROTECTED]> wrote:
> On Thu, 2007-11-22 at 02:09 +0100, Andreas Hocevar wrote:
> A similar thing holds for adding a layer that *has* an id. Although
> OWSContext.js assumes that adding a layer with the same id means
> replacing the old one with the new one (which seems logical).
I agree on that.
> > > Since MB 1.5 will ship with OL 2.5, is it desirable to have a GeoRSS
> > > example and therefore have a patched OL 2.5 with GeoRSS support in it?
> > -1, because we have an alternative. But I'm eager to see this in the trunk.
>
> Understandable, especially since it would force us to use a custom
> OL.js. If I want to get this working in the trunk, it would require a
> custom/unreleased version of OL.js there. Is that desirable? If so, then
> we might as well take the latest trunk version of OL.
We decided a long time ago to base the Mapbuilder release on a stable
release of OpenLayers. But if your patch can be applied to the 2.5
release, we could just add that patch. Anyway, I would like to hear
what exactly you have in mind WRT GeoRSS. Maybe you can point us to an
example url and the code you were creating/changing in Mapbuilder to
get it running.
Regards,
Andreas.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
mapbuilder-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel
