Hi Roald -- On Nov 22, 2007 1:12 AM, Roald de Wit <[EMAIL PROTECTED]> wrote: > It's not quite sure to me and Cameron whether or not it was agreed in > the last meeting to put my layerId changes into the 1.5 branch. Can you > please explicitly vote for or against it asap?
First of all, thanks for your great work! It was agreed to not add it to the branch. And thus the last merge from trunk to 1_5 did not contain this change. But if you want us to vote on that again, I would kindly ask you to explain a little bit on what you have done. At this point, I have too little information to vote. If I understand your code right, when parsing the context, you check for the id attribute of the layer, and if it is not found you fall back to the layer name. This will be backwards compatible, as long as there is no id attribute to the Layer/FeatureType in the context. Which is good. There is one thing you would definitely have to change: you changed the code in OwsContext.js to read out layers and feature types using a ResourceList/* xpath. This will break the new base layer code which is currently in trunk and will be in the release. You would have to change that back to ResourceList/Layer and ResourceList/FeatureType, or at least make sure to exclude ResourceList/BaseLayer. > Side note: > Our Lisasoft patch for GeoRSS has been committed to the trunk of OL and > will be part of OL 2.6. Congratulations on that, and also Congratulations on the positive feedback Chris gave you. > Since MB 1.5 will ship with OL 2.5, is it desirable to have a GeoRSS > example and therefore have a patched OL 2.5 with GeoRSS support in it? We already have a GeoRSS example (shipTracks), which transforms a GeoRSS feed to a FeatureCollection with xsl and uses GmlRendererOL to add it to the map. This also works with lines and polygons. If I understand your patch right, it improves OpenLayers.Format.GeoRSS, but OpenLayers.Layer.GeoRSS does not use this code. So I assume you create a OpenLayers.Layer.Vector layer with the features created from the feed using OpenLayers.Format.GeoRSS.read. Please correct me if I'm wrong. I don't know if you are aware that any vector layer will not let events through to layers below. So if you have a GeoRSS layer below some other vector layer, you will not be able to do mouseover and click actions on it. So layers with potential user interaction should always be on top of the layer stack. This is one thing that GmlRendererOL assures. But this is not directly related to your question. > This is new functionality and might be a little too fresh for 1.5. > Please vote for this one as well. -1, because we have an alternative. But I'm eager to see this in the trunk. Regards, Andreas. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ mapbuilder-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel
