Re: Review Request 29890: Refactored allocator interface to support general implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29890/#review68273 --- src/master/allocator.hpp https://reviews.apache.org/r/29890/#comment112707 This is the public API for ___ (fill blank) :) src/master/allocator.hpp https://reviews.apache.org/r/29890/#comment112706 Nit: Add explanatory comments ... or simply Document API calls. src/master/allocator.hpp https://reviews.apache.org/r/29890/#comment112708 'There is no need ...' src/master/allocator.hpp https://reviews.apache.org/r/29890/#comment112709 s/Extract/Move/ src/tests/cluster.hpp https://reviews.apache.org/r/29890/#comment112448 Why have both? src/tests/master_allocator_tests.cpp https://reviews.apache.org/r/29890/#comment112711 The destructor of the MesosAllocator will stop the process, right? How is this different from status quo, or are you trying to solve other problems mid-way? - Niklas Nielsen On Jan. 15, 2015, 9:17 a.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29890/ --- (Updated Jan. 15, 2015, 9:17 a.m.) Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-2213 https://issues.apache.org/jira/browse/MESOS-2213 Repository: mesos-git Description --- Introduce a basic Allocator interface that every allocator should implement. This interface does not require allocators to be based on libprocess process. For allocators they do implement allocation logic via an internal libprocess process, a special wrapper is provided. Allocator uses and tests are updated to use Allocator type instead of AllocatorProcess. Diffs - src/local/local.cpp 76e73a4 src/master/allocator.hpp 224569a src/master/hierarchical_allocator_process.hpp ccd37b4 src/master/main.cpp 193d53f src/tests/cluster.hpp 74cedb3 src/tests/hierarchical_allocator_tests.cpp 7c05123 src/tests/master_allocator_tests.cpp 2430622 src/tests/mesos.hpp 591134b src/tests/mesos.cpp 3b98c69 src/tests/resource_offers_tests.cpp d098e70 src/tests/slave_recovery_tests.cpp 809822e Diff: https://reviews.apache.org/r/29890/diff/ Testing --- make distcheck (Ubuntu, OS X) Thanks, Alexander Rukletsov
Re: Review Request 29926: Wrapped underlying process in Owned.
On Jan. 15, 2015, 11:43 a.m., Ben Mahler wrote: This is an extremely common pattern in the code, and so we should avoid doing it in an inconsistent manner. FWIW, we've yet to see leaks from this pattern, but if you want to make this change, let's do it as a broad sweep instead of introducing inconsistent code. :) Alexander Rukletsov wrote: I think this particular example is a canonical case for using `Owned`. I can file a JIRA to sweep the entire codebase, but I would keep this change. If we agree that using `Owned` is preferable here, IMO it's not worth it to postpone using it for consistency reason, though consistency is important. Did you guys reach consensus? If not, let's jump on a call and/or get some 3rd party input - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29926/#review68303 --- On Jan. 15, 2015, 8:58 a.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29926/ --- (Updated Jan. 15, 2015, 8:58 a.m.) Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-2213 https://issues.apache.org/jira/browse/MESOS-2213 Repository: mesos-git Description --- See summary. Diffs - src/allocation/allocator.hpp PRE-CREATION Diff: https://reviews.apache.org/r/29926/diff/ Testing --- make check (Ubuntu, OS X) Thanks, Alexander Rukletsov
Re: Review Request 29927: Added Allocator::ceaseAllocation() method.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29927/#review68468 --- Is this speculative or could you show that the behaviour changed with this patch in? - Niklas Nielsen On Jan. 15, 2015, 8:58 a.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29927/ --- (Updated Jan. 15, 2015, 8:58 a.m.) Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-2213 https://issues.apache.org/jira/browse/MESOS-2213 Repository: mesos-git Description --- Several tests have been reported flaky if allocator is not stopped explicitly in some cases. Since allocators are not tied to the AllocatorProcess any more, provide a method in Allocator to cease allocation. Diffs - src/allocation/allocator.hpp PRE-CREATION src/tests/master_allocator_tests.cpp 2430622 src/tests/mesos.hpp 591134b Diff: https://reviews.apache.org/r/29927/diff/ Testing --- make check (Ubuntu, OS X) Thanks, Alexander Rukletsov
Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2667
Hi guys, Do you know if your recent change broke the test? Niklas On 14 January 2015 at 01:09, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2667/changes Changes: [adam] Revised authenticator interface to allow for two fold implementations. [adam] Moved allocator specific declaration into allocator tests. -- [...truncated 9 lines...] I0114 09:10:08.714061 6564 auxprop.cpp:153] Skipping auxiliary property 'userPassword' since SASL_AUXPROP_OVERRIDE == false and value(s) already set I0114 09:10:08.714062 6555 auxprop.cpp:171] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I0114 09:10:08.714077 6564 auxprop.cpp:171] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I0114 09:10:08.714097 6555 auxprop.cpp:99] Request to lookup properties for user: 'test-principal' realm: 'penates.apache.org' server FQDN: ' penates.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: false I0114 09:10:08.714099 6564 auxprop.cpp:99] Request to lookup properties for user: 'test-principal' realm: 'penates.apache.org' server FQDN: ' penates.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: false I0114 09:10:08.714118 6555 auxprop.cpp:153] Skipping auxiliary property 'userPassword' since SASL_AUXPROP_OVERRIDE == false and value(s) already set I0114 09:10:08.714125 6564 auxprop.cpp:153] Skipping auxiliary property 'userPassword' since SASL_AUXPROP_OVERRIDE == false and value(s) already set I0114 09:10:08.714128 6555 auxprop.cpp:171] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I0114 09:10:08.714143 6564 auxprop.cpp:171] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I0114 09:10:08.714161 6555 auxprop.cpp:99] Request to lookup properties for user: 'test-principal' realm: 'penates.apache.org' server FQDN: ' penates.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: false I0114 09:10:08.714164 6564 auxprop.cpp:99] Request to lookup properties for user: 'test-principal' realm: 'penates.apache.org' server FQDN: ' penates.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: false I0114 09:10:08.714179 6555 auxprop.cpp:153] Skipping auxiliary property 'userPassword' since SASL_AUXPROP_OVERRIDE == false and value(s) already set I0114 09:10:08.714186 6564 auxprop.cpp:153] Skipping auxiliary property 'userPassword' since SASL_AUXPROP_OVERRIDE == false and value(s) already set I0114 09:10:08.714189 6555 auxprop.cpp:171] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I0114 09:10:08.714200 6564 auxprop.cpp:171] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I0114 09:10:08.894160 6564 auxprop.cpp:99] Request to lookup properties for user: 'test-principal' realm: 'penates.apache.org' server FQDN: ' penates.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: false I0114 09:10:08.894178 6564 auxprop.cpp:153] Skipping auxiliary property 'userPassword' since SASL_AUXPROP_OVERRIDE == false and value(s) already set I0114 09:10:08.894187 6564 auxprop.cpp:171] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I0114 09:10:08.714220 6555 auxprop.cpp:99] Request to lookup properties for user: 'test-principal' realm: 'penates.apache.org' server FQDN: ' penates.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: false I0114 09:10:08.894206 6564 auxprop.cpp:99] Request to lookup properties for user: 'test-principal' realm: 'penates.apache.org' server FQDN: ' penates.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: false I0114 09:10:08.894207 6555 auxprop.cpp:153] Skipping auxiliary property 'userPassword' since SASL_AUXPROP_OVERRIDE == false and value(s) already set I0114 09:10:08.894214 6564 auxprop.cpp:153] Skipping auxiliary property 'userPassword' since SASL_AUXPROP_OVERRIDE == false and value(s) already set I0114 09:10:08.894234 6555 auxprop.cpp:171] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I0114 09:10:08.894237 6564 auxprop.cpp:171] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I0114 09:10:08.894281 6564 auxprop.cpp:99] Request to lookup properties for user: 'test-principal' realm: 'penates.apache.org' server FQDN: ' penates.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: false I0114 09:10:08.894286 6555 auxprop.cpp:99] Request to lookup properties for user: 'test-principal' realm: 'penates.apache.org' server FQDN: ' penates.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE:
Re: Assigning an issue
Hi Abhishek, Added you as a contributor. Let me know if you have any trouble assigning tickets. Cheers, Niklas On 22 January 2015 at 13:21, Abhishek Chanda abhishek.li...@gmail.com wrote: Hi all, I am brand new to Mesos. Would like to assign https://issues.apache.org/jira/browse/MESOS-2210 to myself. Please add me as an contributor so that I can assign bugs in JIRA. Thanks
Re: Review Request 29925: Moved allocation related sources into a separate directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29925/#review69325 --- src/Makefile.am https://reviews.apache.org/r/29925/#comment113987 Sort alphabetically :) src/local/local.cpp https://reviews.apache.org/r/29925/#comment113988 Sort src/tests/hierarchical_allocator_tests.cpp https://reviews.apache.org/r/29925/#comment113992 s/\/\//\//g - Niklas Nielsen On Jan. 20, 2015, 10:06 a.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29925/ --- (Updated Jan. 20, 2015, 10:06 a.m.) Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-2213 https://issues.apache.org/jira/browse/MESOS-2213 Repository: mesos-git Description --- See summary. Diffs - src/Makefile.am 07bea1f src/local/local.cpp 76e73a4 src/master/allocation/allocator.hpp PRE-CREATION src/master/allocation/mesos/hierarchical.hpp PRE-CREATION src/master/allocation/sorter.hpp PRE-CREATION src/master/allocation/sorters/drf.hpp PRE-CREATION src/master/allocation/sorters/drf.cpp PRE-CREATION src/master/allocator.hpp 224569a src/master/drf_sorter.hpp e0ec58b src/master/drf_sorter.cpp 967c8aa src/master/hierarchical_allocator_process.hpp ccd37b4 src/master/main.cpp e5e76ce src/master/master.cpp e9dcca3 src/master/sorter.hpp 333c293 src/tests/cluster.hpp 74cedb3 src/tests/fault_tolerance_tests.cpp 5763486 src/tests/hierarchical_allocator_tests.cpp 7c05123 src/tests/master_allocator_tests.cpp 2430622 src/tests/master_authorization_tests.cpp 42ffe24 src/tests/master_slave_reconciliation_tests.cpp 04806ed src/tests/master_tests.cpp 678d27f src/tests/mesos.hpp 591134b src/tests/rate_limiting_tests.cpp 7f5ca25 src/tests/resource_offers_tests.cpp d098e70 src/tests/sorter_tests.cpp 56e5714 Diff: https://reviews.apache.org/r/29925/diff/ Testing --- make check (Ubuntu, OS X) Thanks, Alexander Rukletsov
Re: Review Request 29569: Refactored Once abstraction to not use Promise.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29569/#review69287 --- Ship it! 3rdparty/libprocess/include/process/once.hpp https://reviews.apache.org/r/29569/#comment113930 if (started !finished) ? Probably a noop, but for clarity. - Niklas Nielsen On Jan. 21, 2015, 9:57 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29569/ --- (Updated Jan. 21, 2015, 9:57 a.m.) Review request for mesos, Joris Van Remoortere and Niklas Nielsen. Repository: mesos-git Description --- The original once abstraction was implemented using promises, which made it unusable to initialize libprocess because libprocess must be initialized in order to use a Promise. This removes that requirement, but it also means that an actor blocking on a Once will no longer donate it's thread while it's waiting (since it doesn't wait on a Promise, which waits on a Latch, which waits on a ProcessBase, which donates the thread while waiting). Diffs - 3rdparty/libprocess/include/process/once.hpp e85b38205065b34d438f68a6441905eb2f90169c Diff: https://reviews.apache.org/r/29569/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 29540: Added an Address::family() function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29540/#review69289 --- Ship it! Ship It! - Niklas Nielsen On Jan. 1, 2015, 8:46 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29540/ --- (Updated Jan. 1, 2015, 8:46 p.m.) Review request for mesos, Dominic Hamon, Evelina Dumitrescu, Joris Van Remoortere, and Niklas Nielsen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/include/process/address.hpp PRE-CREATION Diff: https://reviews.apache.org/r/29540/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 29541: Added network::resolve and network::hostname.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29541/#review69292 --- 3rdparty/libprocess/include/process/network.hpp https://reviews.apache.org/r/29541/#comment113933 Want to add a todo that you don't support IPv6 yet? 3rdparty/libprocess/include/process/network.hpp https://reviews.apache.org/r/29541/#comment113934 You could perhaps hoist '(struct sockaddr_in*) (result-ai_addr)' into a variable so you limit the number of castings. 3rdparty/libprocess/include/process/network.hpp https://reviews.apache.org/r/29541/#comment113977 Aren't you missing a break here? - Niklas Nielsen On Jan. 21, 2015, 9:56 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29541/ --- (Updated Jan. 21, 2015, 9:56 a.m.) Review request for mesos, Dominic Hamon, Evelina Dumitrescu, Joris Van Remoortere, and Niklas Nielsen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/include/process/network.hpp PRE-CREATION 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf Diff: https://reviews.apache.org/r/29541/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 29890: Refactored allocator interface to support general implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29890/#review69317 --- Ship it! One naming nit - but otherwise looks good to go. src/master/allocator.hpp https://reviews.apache.org/r/29890/#comment113979 Don't we also want to change this to MesosAllocatorProcess and make the template handle 'template typename MesosAllocatorProcess' be the generalized 'AllocatorProcess' one? - Niklas Nielsen On Jan. 22, 2015, 8:55 a.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29890/ --- (Updated Jan. 22, 2015, 8:55 a.m.) Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-2213 https://issues.apache.org/jira/browse/MESOS-2213 Repository: mesos-git Description --- Introduce a basic Allocator interface that every allocator should implement. This interface does not require allocators to be based on libprocess process. For allocators they do implement allocation logic via an internal libprocess process, a special wrapper is provided. Allocator uses and tests are updated to use Allocator type instead of AllocatorProcess. Diffs - src/local/local.cpp 76e73a4 src/master/allocator.hpp 224569a src/master/hierarchical_allocator_process.hpp ccd37b4 src/master/main.cpp e5e76ce src/tests/cluster.hpp 74cedb3 src/tests/hierarchical_allocator_tests.cpp 7c05123 src/tests/master_allocator_tests.cpp 2430622 src/tests/mesos.hpp 591134b src/tests/mesos.cpp 5ed4df5 src/tests/resource_offers_tests.cpp d098e70 src/tests/slave_recovery_tests.cpp 809822e Diff: https://reviews.apache.org/r/29890/diff/ Testing --- make distcheck (Ubuntu, OS X) Thanks, Alexander Rukletsov
Re: Review Request 29932: Renamed test allocator actions for consistency.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29932/#review69320 --- Ship it! Ship It! - Niklas Nielsen On Jan. 20, 2015, 10:21 a.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29932/ --- (Updated Jan. 20, 2015, 10:21 a.m.) Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-2213 https://issues.apache.org/jira/browse/MESOS-2213 Repository: mesos-git Description --- See summary. Diffs - src/tests/master_allocator_tests.cpp 2430622 src/tests/mesos.hpp 591134b Diff: https://reviews.apache.org/r/29932/diff/ Testing --- make check (Ubuntu, OS X) Thanks, Alexander Rukletsov
Re: Review Request 30082: Cleaned up namespace hierarchy in allocation sources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30082/#review69321 --- Looks like a few empty files snuck into this patch - Niklas Nielsen On Jan. 20, 2015, 10:21 a.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30082/ --- (Updated Jan. 20, 2015, 10:21 a.m.) Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-2213 https://issues.apache.org/jira/browse/MESOS-2213 Repository: mesos-git Description --- See summary. Diffs - src/local/local.hpp 0aa50ef src/local/local.cpp 76e73a4 src/master/allocation/allocator.hpp PRE-CREATION src/master/allocation/mesos/allocator.hpp PRE-CREATION src/master/allocation/mesos/hierarchical.hpp PRE-CREATION src/master/allocation/sorter.hpp PRE-CREATION src/master/allocation/sorters/drf.hpp PRE-CREATION src/master/allocation/sorters/drf.cpp PRE-CREATION src/master/main.cpp e5e76ce src/master/master.hpp a8ce4d0 src/master/master.cpp e9dcca3 src/tests/cluster.hpp 74cedb3 src/tests/fault_tolerance_tests.cpp 5763486 src/tests/hierarchical_allocator_tests.cpp 7c05123 src/tests/master_allocator_tests.cpp 2430622 src/tests/master_authorization_tests.cpp 42ffe24 src/tests/master_tests.cpp 678d27f src/tests/mesos.hpp 591134b src/tests/mesos.cpp 3b98c69 src/tests/partition_tests.cpp fea7801 src/tests/rate_limiting_tests.cpp 7f5ca25 src/tests/resource_offers_tests.cpp d098e70 src/tests/slave_recovery_tests.cpp 809822e src/tests/sorter_tests.cpp 56e5714 Diff: https://reviews.apache.org/r/30082/diff/ Testing --- make check (OS X) Thanks, Alexander Rukletsov
Re: Review Request 29927: Implemented MasterAllocatorTest::StopAllocator() method.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29927/#review69318 --- One question below. Otherwise, looks good! :) src/tests/master_allocator_tests.cpp https://reviews.apache.org/r/29927/#comment113980 Can we to guard this so you capture dispatches to a 'stopped' allocator upfront? - Niklas Nielsen On Jan. 20, 2015, 10:10 a.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29927/ --- (Updated Jan. 20, 2015, 10:10 a.m.) Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-2213 https://issues.apache.org/jira/browse/MESOS-2213 Repository: mesos-git Description --- Several tests have been reported flaky if allocation is not ceased explicitly (see MESOS-1677). To stop allocation, an allocator instance should be destroyed. To facilitate this, store a pointer to a MockAllocator instance in the MasterAllocatorTest fixture and let a test case destroy it. Diffs - src/tests/master_allocator_tests.cpp 2430622 Diff: https://reviews.apache.org/r/29927/diff/ Testing --- make check (Ubuntu, OS X) Thanks, Alexander Rukletsov
Re: Review Request 29931: Extracted MesosAllocator into a separate file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29931/#review69322 --- Ship it! src/master/allocation/allocator.hpp https://reviews.apache.org/r/29931/#comment113984 Is this still relevant? The allocator only lives in the master and the containerizer and isolators similarily knows about the slave flags. If not, let's kill the comments referencing the master flags removal - Niklas Nielsen On Jan. 20, 2015, 10:16 a.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29931/ --- (Updated Jan. 20, 2015, 10:16 a.m.) Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-2213 https://issues.apache.org/jira/browse/MESOS-2213 Repository: mesos-git Description --- See summary. Diffs - src/Makefile.am 07bea1f src/master/allocation/allocator.hpp PRE-CREATION src/master/allocation/mesos/allocator.hpp PRE-CREATION src/master/allocation/mesos/hierarchical.hpp PRE-CREATION Diff: https://reviews.apache.org/r/29931/diff/ Testing --- make check (Ubuntu, OS X) Thanks, Alexander Rukletsov
Re: Review Request 29929: Cleaned up includes in allocation sources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29929/#review69323 --- Ship it! Another empty file 'src/master/allocation/mesos/hierarchical.hpp' sneaked it's way in. Can you do a scan of your patch chain and check for empty files? - Niklas Nielsen On Jan. 20, 2015, 10:12 a.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29929/ --- (Updated Jan. 20, 2015, 10:12 a.m.) Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-2213 https://issues.apache.org/jira/browse/MESOS-2213 Repository: mesos-git Description --- See summary. Diffs - src/local/local.cpp 76e73a4 src/master/allocation/allocator.hpp PRE-CREATION src/master/allocation/mesos/hierarchical.hpp PRE-CREATION src/master/main.cpp e5e76ce src/tests/master_tests.cpp 678d27f Diff: https://reviews.apache.org/r/29929/diff/ Testing --- make check (Ubuntu, OS X) Thanks, Alexander Rukletsov
Re: Review Request 29606: Exposed authentication headers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29606/#review68830 --- Ship it! Ship It! - Niklas Nielsen On Jan. 19, 2015, 2:52 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29606/ --- (Updated Jan. 19, 2015, 2:52 p.m.) Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. Bugs: MESOS-2096 https://issues.apache.org/jira/browse/MESOS-2096 Repository: mesos-git Description --- [10/10] Build Mesos Modules outside Mesos source tree. This allows authentication modules to be built outside the mesos source tree. Diffs - src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e src/authentication/authenticatee.hpp 361083b5e1ca5ab1a594b3108fb768626313a725 src/authentication/authenticator.hpp 460494a49ad7c71803507afe62005280d5929d41 src/authentication/cram_md5/authenticatee.hpp 5d35598f75f4d9a8c185cfd387e1085b3bf15395 src/authentication/cram_md5/authenticator.hpp d739a02d755c2729248291db8c274ad7e7dd4c6d src/examples/test_authentication_modules.cpp 6d32573d4e7817ddb62f3eb7aca2cf3f06d27c65 src/master/master.hpp a8ce4d023ddea36cb83a2dc7b95abd12342f345a src/master/master.cpp e9dcca3c92c94f3123519855e238bcef47eeece9 src/module/authenticatee.hpp bae37ced0b5da5dec2ff91d795cc8e75fd8900f2 src/module/authenticator.hpp 956233852c355f67b890479b7330d2d2f01dbaf3 src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2 src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268 src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6 src/tests/cram_md5_authentication_tests.cpp a356aa1fbcf5492b22e78bd4e7ee1d092f5cf736 Diff: https://reviews.apache.org/r/29606/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 29528: Added std::string overloads of Socket::recv/send.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29528/#review69239 --- Ship it! 3rdparty/libprocess/include/process/socket.hpp https://reviews.apache.org/r/29528/#comment113884 A list would be great to get a quick overview of the special powers of 'size' ;) Size value Meaning Absent Read as much as possible 0Read until EOF = 0What happens here? 0Read until N bytes has been read 3rdparty/libprocess/src/socket.cpp https://reviews.apache.org/r/29528/#comment113871 Can we every have an index that exceededs the original data size? Probably not, but continueing sending wouldn't make much sense either. We could guard against this by changing the test to 'index = data-size())' or throw an error if index is strictly larger. Feel free to drop is you have strong guarantees that this will never happen. - Niklas Nielsen On Jan. 21, 2015, 9:42 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29528/ --- (Updated Jan. 21, 2015, 9:42 a.m.) Review request for mesos, Joris Van Remoortere and Niklas Nielsen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f Diff: https://reviews.apache.org/r/29528/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 29531: Fix weird outputing when running configure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29531/#review69244 --- Ship it! Ship It! - Niklas Nielsen On Jan. 21, 2015, 9:43 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29531/ --- (Updated Jan. 21, 2015, 9:43 a.m.) Review request for mesos and Niklas Nielsen. Repository: mesos-git Description --- This used to print something like: checking for libdl ... yes found checking for somethingelse ... yes The 'found' is unnecessary because the macro will print 'yes' on it's own, so I removed it. Diffs - 3rdparty/libprocess/configure.ac 19bc601247f3b1fc6b28d3474fb39f7369bb382f Diff: https://reviews.apache.org/r/29531/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 29533: Added a URL abstraction to stout.
On Jan. 5, 2015, 2:50 p.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp, lines 28-29 https://reviews.apache.org/r/29533/diff/1/?file=805385#file805385line28 Is this complete? It doesn't look like it supports what we currently have in src/zookeeper/url.hpp: ``` // Describes a ZooKeeper URL of the form: // // zk://username:password@servers/path // // Where username:password is for the 'digest' scheme (see ZooKeeper // documentation regarding access controls using ACLs) and servers // is of the form: // // host1:port1,host2:port2,host3:port3 // // Note that in the future we may want to support authentication // mechanisms other than 'digest' and have a URL of the following // form. // // zk://scheme:credentials@servers/path ``` Niklas Nielsen wrote: Should we follow: http://tools.ietf.org/html/rfc3986 ? True URL parsing is tricky. Niklas Nielsen wrote: Or write a shim on an existing library instead of rewriting: http://uriparser.sourceforge.net/ Benjamin Hindman wrote: I was punting parsing for now and focing everyone to be explicit (which is nice because it doesn't require dealing with a Try). I think we can pull in a parser later. Also, this is a general URL, and a zookeeper::URL is a ZooKeeper URL, which maybe we want to make be a subclass of URL? But I'm not necessarily convinced, and didn't feel like we needed to take this on right now (people shouldn't be converting between a zookeeper::URL and a URL anyway). SGTM - created a ticket to keep track of using an existing library: https://issues.apache.org/jira/browse/MESOS-2247 - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29533/#review66742 --- On Jan. 21, 2015, 9:44 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29533/ --- (Updated Jan. 21, 2015, 9:44 a.m.) Review request for mesos and Ben Mahler. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/Makefile.am 8e51957d141af0be64cac42f65e03bca5929c8a9 3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/tests/url_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/29533/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 29538: Replaced Node with network::Address.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29538/#review69265 --- LGTM but fundamentally, it seems like we do not have consensus on this change. Awaiting feedback on the dev@ thread before giving ship-it - Niklas Nielsen On Jan. 21, 2015, 9:49 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29538/ --- (Updated Jan. 21, 2015, 9:49 a.m.) Review request for mesos, Dominic Hamon, Evelina Dumitrescu, Joris Van Remoortere, and Niklas Nielsen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/include/Makefile.am 542ae1c39283087da6fef69be29c811ac35f00f4 3rdparty/libprocess/include/process/address.hpp PRE-CREATION 3rdparty/libprocess/include/process/future.hpp 0326b23cdd475c6e86b33f9b4c63136fdecab443 3rdparty/libprocess/include/process/network.hpp PRE-CREATION 3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af 3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22 3rdparty/libprocess/include/process/process.hpp 3708f98b8fb6737aafb1c058122a8cd01885b76d 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d 3rdparty/libprocess/src/poll_socket.hpp f7ca08e04f0e2a6c4436579b8e18881376985aa5 3rdparty/libprocess/src/poll_socket.cpp 2e70c6c43a9474c577f7fe409c3722290f247d6c 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f 3rdparty/libprocess/src/tests/benchmarks.cpp b286259afd5bd4b3ff47e04d754e675e2db0e6d1 3rdparty/libprocess/src/tests/http_tests.cpp c71a91d516214d20d3df4c220e4a39a070db3260 3rdparty/libprocess/src/tests/metrics_tests.cpp 0c80c69bc3457fd70ab745ff8a02be6ec9cfd9e7 3rdparty/libprocess/src/tests/process_tests.cpp 3bbfe0a7a65acb52d139fda81816acf305d891f5 Diff: https://reviews.apache.org/r/29538/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Scaling Proposal: MAINTAINERS Files
+1 Thanks for the write up Ben! On Tuesday, February 10, 2015, Dominic Hamon dha...@twitter.com.invalid wrote: Well, we should probably do that anyway :) On Feb 10, 2015 2:25 AM, Adam Bordelon a...@mesosphere.io javascript:; wrote: +1 on MAINTAINERS over OWNERS, and the rest of the proposal thus far. Also +1 on Merit is not about quantity of work, it means doing things the community values in a way that the community values. I will, however, echo Tom's concern that we may need to break up master.cpp and slave.cpp if we want fine-grained maintainers of subcomponents of either. On Mon, Feb 9, 2015 at 1:47 PM, Yan Xu y...@jxu.me javascript:; wrote: Good point for MAINTAINERS -- Jiang Yan Xu y...@jxu.me javascript:; @xujyan http://twitter.com/xujyan On Mon, Feb 9, 2015 at 12:05 PM, Vinod Kone vinodk...@gmail.com javascript:; wrote: I like MAINTAINERS because it sounds less authoritative than OWNERS. FWIW, maintainers is also a well understood and well used term (e.g: https://www.kernel.org/doc/linux/MAINTAINERS, https://wiki.jenkins-ci.org/display/JENKINS/Hosting+Plugins#HostingPlugins-AddingMaintainerInformation ) On Sun, Feb 8, 2015 at 10:40 AM, Dominic Hamon dha...@twopensource.com javascript:; wrote: Yes, great. Why not use OWNERS as it is already in use internally at Twitter, at Google, in Chromium, and tooling already supports that as an implicit standard? On Feb 8, 2015 2:52 AM, Benjamin Mahler benjamin.mah...@gmail.com javascript:; wrote: Hi all, I have been chatting with a few committers and we'd like to consider adding the concept of MAINTAINERS files to coincide with our shepherds concept, introduced here: http://mail-archives.apache.org/mod_mbox/mesos-dev/201404.mbox/%3ccafeoqnwjibkayurkf0mfxve2usd5d91xpoe8u+pktiyvszv...@mail.gmail.com%3E Please take a moment to read that thread and its responses here in which maintainers are alluded to: http://mail-archives.apache.org/mod_mbox/mesos-dev/201404.mbox/%3cca+a2mtvc61-3idxtm-ghgcxekqxwz063ouhpbrgbpvsa9zs...@mail.gmail.com%3E http://mail-archives.apache.org/mod_mbox/mesos-dev/201404.mbox/%3CCAAkWvAxegdg8+QQ4-sqZ-SKi9J=2WJDCVg_Sc9aaHttS4=6...@mail.gmail.com%3E *Motivation:* To re-iterate from that thread, many companies rely on Mesos as the foundational layer of their software infrastructure stack. Much of the success of Mesos can be attributed to our focus on quality (code that is simple / easy to read and understand, high attention to detail, thorough reviewing, good testing practices, managing technical debt, learning from each other, etc). As the community of contributors has grown, it's become increasingly difficult to ensure that people are able to find reviewers with experience in specific areas of the project. Good contributions often fall through the cracks as a result of the lack of clarity around this. We would like to ensure that reviewers with context and a long-term outlook on the particular area of the code are involved in providing feedback. It can be difficult for a contributor to consider the implications of their change, when they are looking to get a bug fixed or a feature implemented before the next release or the end of a sprint. We'd like to be able to add more and more committers as the community grows, and incentivize them to become responsible maintainers of components as they become more involved in the project. *MAINTAINERS file system:* In order to ensure we can maintain the quality of the code as we grow, we'd like to propose adding an MAINTAINERS file system to the source tree. From the chromium mailing list (s/OWNERS/MAINTAINERS/): *A MAINTAINERS file lives in a directory and describes (in simple list form) whose review is required to commit changes to it. MAINTAINERShip inherits, in that someone listed at a higher level in the tree is capable of reviewing changes to lower level files.* *MAINTAINERS files provide a means for people to find engineers experienced in developing specific areas for code reviews. They are designed to help ensure changes don't fall through the cracks and get appropriate scrutiny. MAINTAINERShip is a responsibility and people designated as MAINTAINERS in a given area are responsible for the long term improvement of that area, and reviewing code in that area.* This would be enforced via our review tooling
Re: Review Request 30338: Introduced ExecutorRunState struct for Isolators and Launchers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30338/#review71813 --- Ship it! Ship It! - Niklas Nielsen On Feb. 9, 2015, 6:53 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30338/ --- (Updated Feb. 9, 2015, 6:53 p.m.) Review request for mesos, Ian Downes, Niklas Nielsen, Till Toenshoff, and Vinod Kone. Bugs: MESOS-2096 https://issues.apache.org/jira/browse/MESOS-2096 Repository: mesos Description --- [4/9] Build Mesos Modules outside Mesos source tree. The struct is constructed from some fields of RunState and passed on to Isolators. This further allows us to do cleanup various isolators/launchers. The goal was to remove the dependency on RunState so that we can eventually expose slave/containerizer/isolator.hpp as a public header. Diffs - src/slave/containerizer/external_containerizer.hpp 12968781b47cbf53bef2529d6bbc3819b09c36e9 src/slave/containerizer/isolator.hpp e39a8a5e7ecd3273cabab2d7f4038eb7a6d88bb3 src/slave/containerizer/isolator.cpp bb4da46f2d0984956b57ffbb065dc3cc43ff8262 src/slave/containerizer/isolators/cgroups/cpushare.hpp 1050af7394fa7b181ce5e1d1841c397da7649b84 src/slave/containerizer/isolators/cgroups/cpushare.cpp 6554ca3d8c45f449ca5414c695efe813f31a101b src/slave/containerizer/isolators/cgroups/mem.hpp 4de5c646d2869f5893158a260f973ec098bcc33e src/slave/containerizer/isolators/cgroups/mem.cpp 0bb4039ba83698e663ab0527f90c46ed7bd11bf5 src/slave/containerizer/isolators/cgroups/perf_event.hpp 6bf885820d09d6ee3190b465851207a46dacd038 src/slave/containerizer/isolators/cgroups/perf_event.cpp f94eeaecbf4b60b5a29b54fff8eb2db9c30e8bef src/slave/containerizer/isolators/filesystem/shared.hpp a5b5ca1dd598ea35aa6d08ded93f881eb6bc2c65 src/slave/containerizer/isolators/filesystem/shared.cpp 85a5ade7fd739f95c7ab940641358af3dc76acef src/slave/containerizer/isolators/namespaces/pid.hpp 7052a033c1beeb8dab73ef0f4e75185d6130650a src/slave/containerizer/isolators/namespaces/pid.cpp 0ad102d00276b4f5a3141ac16eb7ed186690e4be src/slave/containerizer/isolators/network/port_mapping.hpp 1e4ed3d3929b648308dfd03d1f8b578988cf079d src/slave/containerizer/isolators/network/port_mapping.cpp 361e33b013fd37dfbcda701bf13c28b3420160ef src/slave/containerizer/isolators/posix.hpp b6d289bc2a7e9d0e86c2a2bf7134b9612754830f src/slave/containerizer/isolators/posix/disk.hpp 58a06c7f47b33006705b1ded8f4fdcff95cabb2d src/slave/containerizer/isolators/posix/disk.cpp b2be552035ced393e5e0c0e41e701fcbdcddf190 src/slave/containerizer/launcher.hpp b6fab38865c2be576ced5486a55ae931730572ed src/slave/containerizer/launcher.cpp f2267adbfabc936c7f99711b53e2bf62de37a18a src/slave/containerizer/linux_launcher.hpp 0d630facc90f55ed7f9559e66a5349a30337528f src/slave/containerizer/linux_launcher.cpp 8417160e756018da8233c7a3287e35781b5743da src/slave/containerizer/mesos/containerizer.hpp b3aafe4efa9f3469d7a3fd39243ad66b46d6a54d src/slave/containerizer/mesos/containerizer.cpp fa40d47aee7803833bcde6cce1e86a21d7cf27d0 src/tests/isolator.hpp 7c40f3cb419057c91b307f164edcdb724d45c50d Diff: https://reviews.apache.org/r/30338/diff/ Testing --- make check. Thanks, Kapil Arya
Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2746
https://issues.apache.org/jira/browse/MESOS-2366 On 17 February 2015 at 17:56, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2746/changes Changes: [benjamin.mahler] Updated EventLoop::delay to take a lambda::function. -- [...truncated 72164 lines...] I0218 01:55:15.052839 13946 master.cpp:785] Master terminating I0218 01:55:15.053035 13943 registrar.cpp:444] Applied 1 operations in 72064ns; attempting to update the 'registry' I0218 01:55:15.053145 13935 slave.cpp:2751] master@67.195.81.187:57268 exited W0218 01:55:15.053166 13935 slave.cpp:2754] Master disconnected! Waiting for a new master to be elected I0218 01:55:15.054481 13918 process.cpp:2117] Dropped / Lost event for PID: master@67.195.81.187:57268 I0218 01:55:15.054572 13918 process.cpp:2117] Dropped / Lost event for PID: master@67.195.81.187:57268 I0218 01:55:15.056511 13940 log.cpp:683] Attempting to append 316 bytes to the log I0218 01:55:15.056644 13935 coordinator.cpp:339] Coordinator attempting to write 2 action at position 3 I0218 01:55:15.057008 13945 process.cpp:2117] Dropped / Lost event for PID: log-coordinator(287)@67.195.81.187:57268 I0218 01:55:15.060351 13941 process.cpp:2117] Dropped / Lost event for PID: master@67.195.81.187:57268 I0218 01:55:15.229552 13941 slave.cpp:1089] Will retry registration in 32.644031ms if necessary I0218 01:55:15.099928 13948 process.cpp:2117] Dropped / Lost event for PID: scheduler-3b7a53ae-0e3b-42d1-8461-93911caf9079@67.195.81.187:57268 I0218 01:55:15.230154 13945 process.cpp:2117] Dropped / Lost event for PID: registrar(256)@67.195.81.187:57268 I0218 01:55:15.238539 13943 slave.cpp:505] Slave terminating I0218 01:55:15.241852 13918 process.cpp:2117] Dropped / Lost event for PID: slave(221)@67.195.81.187:57268 I0218 01:55:15.242988 13918 process.cpp:2117] Dropped / Lost event for PID: scheduler-9b2103c5-38b0-4c4b-8614-1aeb1fcc95ed@67.195.81.187:57268 [ OK ] ExceptionTest.DisallowSchedulerActionsOnAbort (361 ms) [ RUN ] ExceptionTest.DisallowSchedulerCallbacksOnAbort Using temporary directory '/tmp/ExceptionTest_DisallowSchedulerCallbacksOnAbort_VuflGx' I0218 01:55:15.248679 13918 leveldb.cpp:175] Opened db in 2.668145ms I0218 01:55:15.249372 13918 leveldb.cpp:182] Compacted db in 663293ns I0218 01:55:15.249419 13918 leveldb.cpp:197] Created db iterator in 21632ns I0218 01:55:15.249439 13918 leveldb.cpp:203] Seeked to beginning of db in 2067ns I0218 01:55:15.249449 13918 leveldb.cpp:272] Iterated through 0 keys in the db in 289ns I0218 01:55:15.249492 13918 replica.cpp:743] Replica recovered with log positions 0 - 0 with 1 holes and 0 unlearned I0218 01:55:15.249970 13947 recover.cpp:448] Starting replica recovery I0218 01:55:15.250306 13947 recover.cpp:474] Replica is in 4 status I0218 01:55:15.251730 13937 replica.cpp:640] Replica in 4 status received a broadcasted recover request I0218 01:55:15.252112 13942 recover.cpp:194] Received a recover response from a replica in 4 status I0218 01:55:15.252532 13945 master.cpp:347] Master 20150218-015515-3142697795-57268-13918 (pomona.apache.org) started on 67.195.81.187:57268 I0218 01:55:15.252576 13945 master.cpp:393] Master only allowing authenticated frameworks to register I0218 01:55:15.252593 13945 master.cpp:398] Master only allowing authenticated slaves to register I0218 01:55:15.252617 13945 credentials.hpp:36] Loading credentials for authentication from '/tmp/ExceptionTest_DisallowSchedulerCallbacksOnAbort_VuflGx/credentials' I0218 01:55:15.252769 13941 recover.cpp:565] Updating replica status to 3 I0218 01:55:15.252887 13945 master.cpp:440] Authorization enabled I0218 01:55:15.253491 13936 whitelist_watcher.cpp:78] No whitelist given I0218 01:55:15.253628 13947 hierarchical.hpp:286] Initialized hierarchical allocator process I0218 01:55:15.253706 13937 leveldb.cpp:305] Persisting metadata (8 bytes) to leveldb took 565291ns I0218 01:55:15.253726 13937 replica.cpp:322] Persisted replica status to 3 I0218 01:55:15.253965 13939 recover.cpp:474] Replica is in 3 status I0218 01:55:15.254829 13940 master.cpp:1354] The newly elected leader is master@67.195.81.187:57268 with id 20150218-015515-3142697795-57268-13918 I0218 01:55:15.254858 13940 master.cpp:1367] Elected as the leading master! I0218 01:55:15.254871 13940 master.cpp:1185] Recovering from registrar I0218 01:55:15.254978 13946 registrar.cpp:312] Recovering registrar I0218 01:55:15.255887 13932 replica.cpp:640] Replica in 3 status received a broadcasted recover request I0218 01:55:15.256160 13935 recover.cpp:194] Received a recover response from a replica in 3 status I0218 01:55:15.256742 13937 recover.cpp:565] Updating replica status to 1 I0218 01:55:15.257387 13934 leveldb.cpp:305] Persisting metadata (8 bytes) to leveldb took 437201ns
Re: Review Request 29507: Added Configurable Slave Ping Timeouts
. Clock::cancel(pingTimer); pingTimer = delay( MASTER_PING_TIMEOUT(), self(), Slave::pingTimeout, detection); send(from, PongSlaveMessage()); } ``` Based on all of this, it's really important to understand the implications of the slave under and over estimating the timeout on the master side. For example, if the slave under-estimates and always triggers re-registration, that would be problematic on large clusters (40k slaves / 75 seconds = 500+ re-registrations / second in the steady state!). That's why a TODO mentioned using upper/lower bounds for this. Adam B wrote: Thank you for reviewing/discussing. I hadn't thought much before about the one-way socket closure scenario, but it doesn't drastically change my perspective. As you mention, it's important to consider the implications of the slave misestimating the timeout, especially with a configurable timeout where a master and slave could be at different versions/configurations during a rolling upgrade. There must be one source of truth for this timeout, rather than allowing the slave to estimate or have its own timeout configuration. So I still propose that the master should pass `master_ping_timeout` to the slave via SlaveRe[re]gisteredMessage, so that any slave that has ever considered itself registered/RUNNING knows the master's actual value and will wait at least as long as the master, no matter if/when/how the socket closes. We could also pass the timeout in the PingSlaveMessage if we're paranoid about the master changing its ping timeout value without triggering a reregistration. I f you aren't opposed, I can put together a patch and some tests to demonstrate. Even with the master communicating its timeout so that both sides use the same value, at the point of a two-way network split whichever side last received a Ping/Pong will start its timer later and consequently time out later due to the non-zero communication latency. In the event of a one-way socket closure where the slave can still reach the master, a successful Pong will always follow a successful Ping, so the slave will time out first. If the master times out first, it will send a ShutdownSlaveMessage, remove the slave, and terminate the SlaveObserver, never trying to contact the slave again. The slave may continue trying to send status updates, etc. in the meantime (which might go through in a one-way disconnect), but the slave will eventually timeout, disconnect itself (so it stops sending messages), and consult the MasterDetector for a leader to reregister with. If the master cannot reach the slave, it is likely that the ZK quorum cannot reach it either, but if the slave can reach the ZK quorum, or is configured with a static master, it will indeed try to re-authenticate/register, using a backoff for registration, but not for authentication (TODO). If the slave times out first, it will unnecessarily try to reregister/authenticate even though the master thinks it is still registered. If the master continues to send messages to the slave, they will all be dropped with a warning logged, except for Ping messages which will try to reply with a Pong. If the reregister/authenticate/pong messages from the slave cannot reach the master, the master will eventually remove the slave. If the slave is able to reregister before the master removes it (i.e. brief network connectivity issue), all will go back to normal, but the whole headache could have been avoided if the slave had timed out after the master. To try to enforce ordering (master always times out first), we could have the master timeout after `slave_ping_timeout*max_slave_ping_timeouts` and have the slave timeout after `slave_ping_timeout*(max_slave_ping_timeouts+1)`, passing these values from the master to slave as previously discussed. Thoughts? Ping - did you guys reach to an agreement? - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/#review67113 --- On Jan. 8, 2015, 12:44 a.m., Adam B wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/ --- (Updated Jan. 8, 2015, 12:44 a.m.) Review request for mesos and Niklas Nielsen. Bugs: MESOS-2110 https://issues.apache.org/jira/browse/MESOS-2110 Repository: mesos Description --- Added new --slave_ping_timeout and --max_slave_ping_timeouts flags to mesos-master to replace the existing (still default) SLAVE_PING_TIMEOUT (15secs) and MAX_SLAVE_PING_TIMEOUTS (5). These can be extended
Re: Review Request 30074: Added max allowed age to Slave state.json endpoint
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/#review72855 --- Ship it! src/slave/http.cpp https://reviews.apache.org/r/30074/#comment118973 Which directory age? :) How about 'sandbox' or 'executor directory'. It's hard to interpret it's meaning only from the field name. - Niklas Nielsen On Feb. 14, 2015, 3:20 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/ --- (Updated Feb. 14, 2015, 3:20 a.m.) Review request for mesos, Niklas Nielsen and Till Toenshoff. Bugs: mesos-2229 https://issues.apache.org/jira/browse/mesos-2229 Repository: mesos Description --- Adds and entry `max_allowed_age_secs` to the response of the `state.json` endpoint in the slave. The max allowed age value is available only if it is set, which depends on the flag `--disk_watch_interval` which by default runs every minute (So it will only be available after the first minute running). Modifies the unit test `SlaveTest.StateEndpoint` so it takes into account the new entry. Diffs - src/slave/http.cpp 0395d00 src/slave/slave.hpp 70bd8c1 src/slave/slave.cpp a8b2621 src/tests/slave_tests.cpp 956ce64 Diff: https://reviews.apache.org/r/30074/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 29507: Added Configurable Slave Ping Timeouts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/#review72992 --- Let's get tests wired up before committing this :) - Niklas Nielsen On Jan. 8, 2015, 12:44 a.m., Adam B wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/ --- (Updated Jan. 8, 2015, 12:44 a.m.) Review request for mesos and Niklas Nielsen. Bugs: MESOS-2110 https://issues.apache.org/jira/browse/MESOS-2110 Repository: mesos Description --- Added new --slave_ping_timeout and --max_slave_ping_timeouts flags to mesos-master to replace the existing (still default) SLAVE_PING_TIMEOUT (15secs) and MAX_SLAVE_PING_TIMEOUTS (5). These can be extended if slaves are expected/allowed to be down for longer than a minute or two. Beware that this affects recovery from network timeouts as well as actual slave node/process failover. Diffs - src/master/constants.hpp c386eab src/master/constants.cpp 9ee17e9 src/master/flags.hpp f5c8d2a src/master/master.cpp d6651e2 src/slave/constants.hpp fd1c1ab src/slave/constants.cpp 2a99b11 src/slave/slave.cpp 50b5781 src/tests/fault_tolerance_tests.cpp 5763486 src/tests/partition_tests.cpp fea7801 src/tests/slave_recovery_tests.cpp cd4a398 src/tests/slave_tests.cpp c50cbc7 Diff: https://reviews.apache.org/r/29507/diff/ Testing --- Manually tested slave failover/shutdown with master using different --slave_ping_timeout and --max_slave_ping_timeouts. Updated unit tests to use shorter non-default values for ping timeouts. Thanks, Adam B
Re: Review Request 29855: Fixed variable shadowing in module_tests.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29855/#review72996 --- Ship it! Ship It! - Niklas Nielsen On Jan. 13, 2015, 10:55 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29855/ --- (Updated Jan. 13, 2015, 10:55 a.m.) Review request for mesos, Niklas Nielsen and Till Toenshoff. Repository: mesos Description --- See summary. Diffs - src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc Diff: https://reviews.apache.org/r/29855/diff/ Testing --- make check. Thanks, Kapil Arya
Re: Review Request 30074: Added max allowed age to Slave state.json endpoint
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/#review73003 --- The patch changed a bit since the first /state.json version. Holding back on the first given ship-it until we get the new version into a good shape src/slave/slave.cpp https://reviews.apache.org/r/30074/#comment119130 How about replacing age(usage.get()) here as well? src/slave/slave.cpp https://reviews.apache.org/r/30074/#comment119129 Can you help me understand the second part of this. What does 'as if ... were using no disk'? Think we need to sharpen this comment a little bit src/slave/slave.cpp https://reviews.apache.org/r/30074/#comment119132 Max age of 0 seconds is hard to tell whether is a very unhealthy system or no value present. Wonder if we should leave a todo if the metrics system doesn't support it. - Niklas Nielsen On Feb. 18, 2015, 7:09 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/ --- (Updated Feb. 18, 2015, 7:09 a.m.) Review request for mesos, Niklas Nielsen and Till Toenshoff. Bugs: mesos-2229 https://issues.apache.org/jira/browse/mesos-2229 Repository: mesos Description --- Adds and entry `max_allowed_age_secs` to the response of the `state.json` endpoint in the slave. The max allowed age value is available only if it is set, which depends on the flag `--disk_watch_interval` which by default runs every minute (So it will only be available after the first minute running). Modifies the unit test `SlaveTest.StateEndpoint` so it takes into account the new entry. Diffs - src/slave/metrics.hpp e2ce845ec2229e1e6e71c710022551bec9d15029 src/slave/metrics.cpp ee610b8a7d352c20e8a91bb86c8aa2c1f011e910 src/slave/slave.hpp 7a399f6df50c69b7e1e12d74f076fa57b6edb1b3 src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3 src/tests/slave_tests.cpp 21709e2858d91a2746e0343786f73dec22735da6 Diff: https://reviews.apache.org/r/30074/diff/ Testing --- make check Thanks, Alexander Rojas
Review Request 30948: Reverted configurable graceful shutdown period patch set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30948/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone. Repository: mesos Description --- Reverted patch set (to be reworked after 0.22) Diffs - include/mesos/mesos.proto 3a2921dff856d37455593dcbf7340aa537997d35 src/Makefile.am 05ee76d5f08a28f4ad6129b8c4f472722732aa92 src/exec/exec.cpp 349294369a68be5edf0f38fcc2ec3b762d5c02a9 src/launcher/executor.cpp 8f47f0e23288279f003f8739fb7c5242041fc6ab src/slave/constants.hpp 7717abd4f9a3bd6fdca6af2364864e374ce2e056 src/slave/constants.cpp cdf5c46fc13e6e5d602a3b1397b5e5d5fd3d13d0 src/slave/containerizer/containerizer.cpp 4e0dc3b8a110adeab12c0c249f90ca18b240bbba src/slave/flags.hpp 6ef64ed118c8cb311f97c58069337ab08010baa6 src/slave/graceful_shutdown.hpp 950329ddf6968b61dc10feb50c2fc2fddc97f014 src/slave/graceful_shutdown.cpp 2ab58f7b874078643185762e86640b54950fe270 src/slave/slave.cpp 1e60454cecfe387c4906a74f176bef00c2e0dbb7 src/tests/gc_tests.cpp 45efce347af7ad6bedd193715611dc0a67f5d767 src/tests/slave_tests.cpp a02e335576bf68b449a6286fa5cf5093b1b7182a Diff: https://reviews.apache.org/r/30948/diff/ Testing --- make check Thanks, Niklas Nielsen
Re: Review Request 30961: Enabled label decorator to override.
On Feb. 12, 2015, 5:24 p.m., Kapil Arya wrote: Is the idea here to allow the label decorator hooks to remove the labels as well? Kapil Arya wrote: Don't we also want the label removal facility in the slave instead of the master? It doesn't make much sense to remove labels in the master. This is to make the semantics of decorators consistent. Having decorators which can only append and others which overrides seems more confusing to me. Does that make sense? On Feb. 12, 2015, 5:24 p.m., Kapil Arya wrote: src/hook/manager.cpp, lines 107-110 https://reviews.apache.org/r/30961/diff/1/?file=862741#file862741line107 Since we are doing a CopyFrom, shouldn't we be updating taskInfo with the updated labels. Otherwise, with the current logic, we'll get labels from the last hook only. Good catch! Will fix - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30961/#review72301 --- On Feb. 12, 2015, 5:13 p.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30961/ --- (Updated Feb. 12, 2015, 5:13 p.m.) Review request for mesos, Ben Mahler and Kapil Arya. Bugs: MESOS-2351 https://issues.apache.org/jira/browse/MESOS-2351 Repository: mesos Description --- See summary. Diffs - src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937 src/tests/hook_tests.cpp dc6d289394e5718a37936e29ad6d988b52933f98 Diff: https://reviews.apache.org/r/30961/diff/ Testing --- make check (with modified VerifyMasterLaunchTaskHook test) Thanks, Niklas Nielsen
Review Request 30961: Enabled label decorator to override.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30961/ --- Review request for mesos, Ben Mahler and Kapil Arya. Bugs: MESOS-2351 https://issues.apache.org/jira/browse/MESOS-2351 Repository: mesos Description --- See summary. Diffs - src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937 src/tests/hook_tests.cpp dc6d289394e5718a37936e29ad6d988b52933f98 Diff: https://reviews.apache.org/r/30961/diff/ Testing --- make check (with modified VerifyMasterLaunchTaskHook test) Thanks, Niklas Nielsen
Review Request 30962: Enabled environment decorator to override.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/ --- Review request for mesos, Ben Mahler and Kapil Arya. Bugs: MESOS-2351 https://issues.apache.org/jira/browse/MESOS-2351 Repository: mesos Description --- See summary Diffs - src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b Diff: https://reviews.apache.org/r/30962/diff/ Testing --- make check Thanks, Niklas Nielsen
Re: Build failed in Jenkins: mesos-reviewbot #4105
There is an issue with our build setup:
rm -f java/jni/org_apache_mesos*.h
rm -f authentication/cram_md5/.dirstamp
rm -f authorizer/*.lo
rm: cannot remove 'python/interface/build': Is a directory
rm: cannot remove 'python/native/build': Is a directory
make[2]: [clean-generic] Error 1 (ignored)
rm -f authorizer/.deps/.dirstamp
rm -f cli/*.o
rm -f authorizer/.dirstamp
Does that look familiar to any of you guys?
On 17 February 2015 at 09:21, Apache Jenkins Server
jenk...@builds.apache.org wrote:
See https://builds.apache.org/job/mesos-reviewbot/4105/
--
[...truncated 5660 lines...]
rm -f tests/common/.deps/.dirstamp
rm -f tests/common/.dirstamp
rm -f state/*.o
rm -rf examples/.libs examples/_libs
rm -f state/*.lo
rm -f usage/.deps/.dirstamp
rm -f tests/*.o
rm -f usage/.dirstamp
rm -rf exec/.libs exec/_libs
rm -f watcher/.deps/.dirstamp
rm -f watcher/.dirstamp
rm -rf fetcher/.libs fetcher/_libs
rm -f zookeeper/.deps/.dirstamp
rm -rf files/.libs files/_libs
rm -f zookeeper/.dirstamp
rm -rf hook/.libs hook/_libs
rm -rf java/jni/.libs java/jni/_libs
rm -rf jvm/.libs jvm/_libs
rm -rf jvm/org/apache/.libs jvm/org/apache/_libs
rm -rf linux/.libs linux/_libs
rm -rf linux/routing/.libs linux/routing/_libs
rm -rf linux/routing/diagnosis/.libs linux/routing/diagnosis/_libs
rm -rf linux/routing/filter/.libs linux/routing/filter/_libs
rm -rf linux/routing/link/.libs linux/routing/link/_libs
rm -rf linux/routing/queueing/.libs linux/routing/queueing/_libs
rm -rf local/.libs local/_libs
rm -rf log/.libs log/_libs
rm -rf log/tool/.libs log/tool/_libs
rm -rf logging/.libs logging/_libs
rm -rf master/.libs master/_libs
rm -rf master/allocator/sorter/drf/.libs master/allocator/sorter/drf/_libs
rm -rf messages/.libs messages/_libs
rm -rf module/.libs module/_libs
rm -rf sched/.libs sched/_libs
rm -rf scheduler/.libs scheduler/_libs
rm -rf slave/.libs slave/_libs
rm -rf slave/containerizer/.libs slave/containerizer/_libs
rm -rf slave/containerizer/isolators/cgroups/.libs
slave/containerizer/isolators/cgroups/_libs
rm -f tests/common/*.o
rm -rf slave/containerizer/isolators/filesystem/.libs
slave/containerizer/isolators/filesystem/_libs
rm -f usage/*.o
rm -rf slave/containerizer/isolators/namespaces/.libs
slave/containerizer/isolators/namespaces/_libs
rm -f usage/*.lo
rm -rf slave/containerizer/isolators/network/.libs
slave/containerizer/isolators/network/_libs
rm -f watcher/*.o
rm -rf slave/containerizer/isolators/posix/.libs
slave/containerizer/isolators/posix/_libs
rm -f watcher/*.lo
rm -f zookeeper/*.o
rm -f zookeeper/*.lo
rm -rf slave/containerizer/mesos/.libs slave/containerizer/mesos/_libs
rm -rf state/.libs state/_libs
rm -rf usage/.libs usage/_libs
rm -rf watcher/.libs watcher/_libs
rm -rf zookeeper/.libs zookeeper/_libs
rm -rf ./.deps authentication/.deps authentication/cram_md5/.deps
authorizer/.deps cli/.deps common/.deps containerizer/.deps docker/.deps
examples/.deps exec/.deps fetcher/.deps files/.deps health-check/.deps
hook/.deps java/jni/.deps jvm/.deps jvm/org/apache/.deps launcher/.deps
linux/.deps linux/routing/.deps linux/routing/diagnosis/.deps
linux/routing/filter/.deps linux/routing/link/.deps
linux/routing/queueing/.deps local/.deps log/.deps log/tool/.deps
logging/.deps master/.deps master/allocator/sorter/drf/.deps messages/.deps
module/.deps sched/.deps scheduler/.deps slave/.deps
slave/containerizer/.deps slave/containerizer/isolators/cgroups/.deps
slave/containerizer/isolators/filesystem/.deps
slave/containerizer/isolators/namespaces/.deps
slave/containerizer/isolators/network/.deps
slave/containerizer/isolators/posix/.deps slave/containerizer/mesos/.deps
state/.deps tests/.deps tests/common/.deps usage/.deps watcher/.deps
zookeeper/.deps
rm -f Makefile
make[2]: Leaving directory `
https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.22.0/_build/src'
Making distclean in ec2
make[2]: Entering directory `
https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.22.0/_build/ec2'
rm -rf .libs _libs
rm -f *.lo
test -z || rm -f
test . = ../../ec2 || test -z || rm -f
rm -f Makefile
make[2]: Leaving directory `
https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.22.0/_build/ec2'
rm -f config.status config.cache config.log configure.lineno
config.status.lineno
rm -f Makefile
make[1]: Leaving directory `
https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.22.0/_build'
if test -d mesos-0.22.0; then find mesos-0.22.0 -type d ! -perm -200
-exec chmod u+w {} ';' rm -rf mesos-0.22.0 || { sleep 5 rm -rf
mesos-0.22.0; }; else :; fi
==
mesos-0.22.0 archives ready for distribution:
mesos-0.22.0.tar.gz
==
real10m57.820s
user61m55.553s
sys 5m1.968s
+ chmod -R +w 3rdparty aclocal.m4 ar-lib autom4te.cache bin bootstrap
CHANGELOG compile config.guess
Re: Review Request 30100: Updated style guide to use '#pragma once' instead of '#define' guard.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30100/#review72773 --- What was the final verdict on pragma once? Is it still relevant? - Niklas Nielsen On Jan. 20, 2015, 3:58 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30100/ --- (Updated Jan. 20, 2015, 3:58 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Hindman, Cody Maloney, Dominic Hamon, Michael Park, Niklas Nielsen, Till Toenshoff, and Timothy Chen. Bugs: MESOS-2211 https://issues.apache.org/jira/browse/MESOS-2211 Repository: mesos Description --- See summary. Diffs - docs/mesos-c++-style-guide.md 3cc9ecd3d8561840d74a6e46a3dbdedf932fec00 Diff: https://reviews.apache.org/r/30100/diff/ Testing --- Tested with a markdown viewer. Thanks, Kapil Arya
Re: Cutting Mesos 0.22.0 RC1
Hi Dave, That is on me. We/I didn't get to send out meeting notes after we met. So I apologize for not writing the intended deadline out immediately. I will see if I can page in enough information from memory and notes to put together a small report from that meeting. To the release cut: taken the current progress, I would still aim for Sunday if there are no objections. Thoughts? Niklas On 17 February 2015 at 10:12, Dave Lester d...@davelester.org wrote: Hi Niklas, Were notes published to the mailing list from the Feb 12 community meeting, or could you share some? This type of agreement should be taking place on the mailing list; If it didn't happen on a mailing list, it didn't happen. [1] Dave [1] https://community.apache.org/newbiefaq.html On Mon, Feb 16, 2015, at 05:37 PM, Niklas Nielsen wrote: Hi everyone, Per our last community meeting (Feb 12), we agreed to cut Mesos 0.22.0 in two weeks (Feb 26). There are still quite a few things in flight, so if any of you don't have any objections, let's aim to cut a release candidate by EOW (Sunday March 1st EOD). I will be reaching out to the leads of ongoing projects to track progress. Cheers, Niklas
Re: Review Request 30263: Added test for CRAM-MD5 support of SASL within configuration phase.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30263/#review72666 --- Ship it! Ship It! - Niklas Nielsen On Jan. 26, 2015, 3:11 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30263/ --- (Updated Jan. 26, 2015, 3:11 a.m.) Review request for mesos, Alexander Rojas and Cody Maloney. Bugs: MESOS-2165 https://issues.apache.org/jira/browse/MESOS-2165 Repository: mesos Description --- see summary Diffs - configure.ac acc685c Diff: https://reviews.apache.org/r/30263/diff/ Testing --- make check (with and without CRAM-MD5 installed) Thanks, Till Toenshoff
Cutting Mesos 0.22.0 RC1
Hi everyone, Per our last community meeting (Feb 12), we agreed to cut Mesos 0.22.0 in two weeks (Feb 26). There are still quite a few things in flight, so if any of you don't have any objections, let's aim to cut a release candidate by EOW (Sunday March 1st EOD). I will be reaching out to the leads of ongoing projects to track progress. Cheers, Niklas
Re: Review Request 30998: Added --disabled_endpoints flag to the slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30998/#review72806 --- src/slave/flags.hpp https://reviews.apache.org/r/30998/#comment118882 These are specific to the files process, shouldn't it be per process then? - Niklas Nielsen On Feb. 16, 2015, 8:21 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30998/ --- (Updated Feb. 16, 2015, 8:21 a.m.) Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone. Bugs: MESOS-2333 https://issues.apache.org/jira/browse/MESOS-2333 Repository: mesos Description --- Adds the flag `--disabled_endpoints` to the slave, used to pass a list of disabled endpoints. As of this points, only endpoints provided by the `mesos::Files` objects can be disabled. Diffs - src/slave/flags.hpp ddb32593566b71bcf0b66adeeb889e43ef911084 src/slave/main.cpp 173a1a3117901d61027fe27d5f411312ed9d9777 Diff: https://reviews.apache.org/r/30998/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 29925: Moved allocation related sources into a separate directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29925/#review69849 --- Ship it! Ship It! - Niklas Nielsen On Jan. 27, 2015, 5:22 a.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29925/ --- (Updated Jan. 27, 2015, 5:22 a.m.) Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-2213 https://issues.apache.org/jira/browse/MESOS-2213 Repository: mesos-git Description --- See summary. Diffs - src/Makefile.am 07bea1f src/local/local.cpp 76e73a4 src/master/allocation/allocator.hpp PRE-CREATION src/master/allocation/mesos/hierarchical.hpp PRE-CREATION src/master/allocation/sorter.hpp PRE-CREATION src/master/allocation/sorters/drf.hpp PRE-CREATION src/master/allocation/sorters/drf.cpp PRE-CREATION src/master/allocator.hpp 318a756 src/master/drf_sorter.hpp 5a66313 src/master/drf_sorter.cpp 584e26c src/master/hierarchical_allocator_process.hpp 6b44892 src/master/main.cpp e5e76ce src/master/master.cpp ab6d1d1 src/master/sorter.hpp 8915c61 src/tests/cluster.hpp 74cedb3 src/tests/fault_tolerance_tests.cpp e0065b3 src/tests/hierarchical_allocator_tests.cpp f44d9e9 src/tests/master_allocator_tests.cpp 2430622 src/tests/master_authorization_tests.cpp 42ffe24 src/tests/master_slave_reconciliation_tests.cpp 04806ed src/tests/master_tests.cpp 678d27f src/tests/mesos.hpp 3f4704b src/tests/rate_limiting_tests.cpp 7f5ca25 src/tests/resource_offers_tests.cpp ffad1f8 src/tests/sorter_tests.cpp 520a42e Diff: https://reviews.apache.org/r/29925/diff/ Testing --- make check (Ubuntu, OS X) Thanks, Alexander Rukletsov
Re: Review Request 29927: Implemented MasterAllocatorTest::StopAllocator() method.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29927/#review69850 --- Ship it! src/tests/master_allocator_tests.cpp https://reviews.apache.org/r/29927/#comment114663 You can do 'return CHECK_NOTNULL(allocator_.get());' :) - Niklas Nielsen On Jan. 27, 2015, 7:23 a.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29927/ --- (Updated Jan. 27, 2015, 7:23 a.m.) Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-2213 https://issues.apache.org/jira/browse/MESOS-2213 Repository: mesos-git Description --- Several tests have been reported flaky if allocation is not ceased explicitly (see MESOS-1677). To stop allocation, an allocator instance should be destroyed. To facilitate this, store a pointer to a MockAllocator instance in the MasterAllocatorTest fixture and let a test case destroy it. Diffs - src/tests/master_allocator_tests.cpp 2430622 Diff: https://reviews.apache.org/r/29927/diff/ Testing --- make check (Ubuntu, OS X) Thanks, Alexander Rukletsov
Re: Review Request 29890: Refactored allocator interface to support general implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29890/#review69841 --- src/master/allocator.hpp https://reviews.apache.org/r/29890/#comment114652 Can we change this to MesosAllocatorProcess? - Niklas Nielsen On Jan. 27, 2015, 5:15 a.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29890/ --- (Updated Jan. 27, 2015, 5:15 a.m.) Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-2213 https://issues.apache.org/jira/browse/MESOS-2213 Repository: mesos-git Description --- Introduce a basic Allocator interface that every allocator should implement. This interface does not require allocators to be based on libprocess process. For allocators they do implement allocation logic via an internal libprocess process, a special wrapper is provided. Allocator uses and tests are updated to use Allocator type instead of AllocatorProcess. Diffs - src/local/local.cpp 76e73a4 src/master/allocator.hpp 318a756 src/master/hierarchical_allocator_process.hpp 6b44892 src/master/main.cpp e5e76ce src/tests/cluster.hpp 74cedb3 src/tests/fault_tolerance_tests.cpp e0065b3 src/tests/hierarchical_allocator_tests.cpp f44d9e9 src/tests/master_allocator_tests.cpp 2430622 src/tests/master_authorization_tests.cpp 42ffe24 src/tests/master_tests.cpp 678d27f src/tests/mesos.hpp 3f4704b src/tests/mesos.cpp 5ed4df5 src/tests/partition_tests.cpp fea7801 src/tests/rate_limiting_tests.cpp 7f5ca25 src/tests/resource_offers_tests.cpp ffad1f8 src/tests/slave_recovery_tests.cpp d135856 Diff: https://reviews.apache.org/r/29890/diff/ Testing --- make distcheck (Ubuntu, OS X) Thanks, Alexander Rukletsov
Re: Review Request 30097: Monitor modularization [7/7]: Ported monitor tests to new interface and made it type paramed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30097/ --- (Updated Jan. 27, 2015, 2:28 p.m.) Review request for mesos, Ben Mahler and Kapil Arya. Bugs: MESOS-2219 https://issues.apache.org/jira/browse/MESOS-2219 Repository: mesos-git Description --- Ported monitor tests to new monitor interface, changed it to a typed test and wired up monitor module test. Diffs (updated) - src/Makefile.am 07bea1f src/examples/test_monitor_module.cpp PRE-CREATION src/tests/module.hpp 21e8fc4 src/tests/module.cpp e6dbf94 src/tests/monitor_tests.cpp 3b02619 Diff: https://reviews.apache.org/r/30097/diff/ Testing --- make check Thanks, Niklas Nielsen
Re: Review Request 30093: Monitor modularization [3/7]: Changed mesos-local to use new resource monitor interface.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30093/ --- (Updated Jan. 27, 2015, 2:28 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-2219 https://issues.apache.org/jira/browse/MESOS-2219 Repository: mesos-git Description --- See summary Diffs (updated) - src/local/local.cpp 76e73a4203812fd9b49a66f436e2523d1bc6ce14 Diff: https://reviews.apache.org/r/30093/diff/ Testing --- make check Thanks, Niklas Nielsen
Re: Review Request 30091: Monitor modularization [1/7]: Added resource monitor interface.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30091/ --- (Updated Jan. 27, 2015, 2:27 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-2219 https://issues.apache.org/jira/browse/MESOS-2219 Repository: mesos-git Description --- Added resource monitor interface and moved existing monitor implementation to src/slave/monitor/mesos/ similar to containerizer structure. Diffs (updated) - src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e src/slave/monitor.hpp f4ebafc5bbba43669dc1436899072b009936a22e src/slave/monitor.cpp 398af010564e999b46e38560ba1e652261a9420c src/slave/monitor/monitor.hpp PRE-CREATION src/slave/monitor/monitor.cpp PRE-CREATION Diff: https://reviews.apache.org/r/30091/diff/ Testing --- make check Thanks, Niklas Nielsen
Re: Review Request 30094: Monitor modularization [4/7]: Ported tests to new monitor interface.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30094/ --- (Updated Jan. 27, 2015, 2:28 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-2219 https://issues.apache.org/jira/browse/MESOS-2219 Repository: mesos-git Description --- See summary Diffs (updated) - src/tests/cluster.hpp 74cedb324949143fd1949082d8a4db596a32d95c src/tests/hook_tests.cpp 44f73effdce2d03627215418007ccbc3263a0c52 src/tests/mesos.hpp 3f4704bf20d654a9b26a483a59eaf96e126ef02c src/tests/mesos.cpp 5ed4df530cf1bf11eec3b29542641822e0f702b2 src/tests/slave_tests.cpp a85a0282947278ce6e02e38093f8b88af4cb612a Diff: https://reviews.apache.org/r/30094/diff/ Testing --- make check Thanks, Niklas Nielsen
Re: Review Request 30152: Monitor modularization [6/7]: Wired up modules in ResourceMonitor::create().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30152/ --- (Updated Jan. 27, 2015, 2:28 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-2219 https://issues.apache.org/jira/browse/MESOS-2219 Repository: mesos-git Description --- See summary. Diffs (updated) - src/slave/monitor/monitor.hpp PRE-CREATION src/slave/monitor/monitor.cpp PRE-CREATION Diff: https://reviews.apache.org/r/30152/diff/ Testing --- make check Thanks, Niklas Nielsen
Re: Review Request 30092: Monitor modularization [2/7]: Changed slave to use monitor interface.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30092/ --- (Updated Jan. 27, 2015, 2:27 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-2219 https://issues.apache.org/jira/browse/MESOS-2219 Repository: mesos-git Description --- Adds resource_monitor to mesos-slave and change the slave process to use a provided resource monitor implementation. Diffs (updated) - src/slave/flags.hpp 0f6cc41d60a2e3bc2121cc438351135541ef99ba src/slave/main.cpp 42e46c58ab4b16033ac6a73d127968d0803490aa src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6 Diff: https://reviews.apache.org/r/30092/diff/ Testing --- make check Thanks, Niklas Nielsen
Re: Review Request 30095: Monitor modularization [5/7]: Added monitor module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30095/ --- (Updated Jan. 27, 2015, 2:28 p.m.) Review request for mesos, Ben Mahler and Kapil Arya. Bugs: MESOS-2219 https://issues.apache.org/jira/browse/MESOS-2219 Repository: mesos-git Description --- See summary. Diffs (updated) - src/module/manager.cpp 5abea26f66b54adc9bc78897c0a7d02713878797 src/module/monitor.hpp PRE-CREATION Diff: https://reviews.apache.org/r/30095/diff/ Testing --- make check Thanks, Niklas Nielsen
Re: Review Request 29539: Replaced Node with Address in Mesos.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29539/#review70140 --- Ship it! Ship It! - Niklas Nielsen On Jan. 28, 2015, 6:09 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29539/ --- (Updated Jan. 28, 2015, 6:09 p.m.) Review request for mesos and Niklas Nielsen. Repository: mesos-git Description --- See summary. Diffs - src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553 src/master/master.cpp e9dcca3c92c94f3123519855e238bcef47eeece9 src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2 src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268 src/slave/http.cpp d1cf8a68fab9a2df44f6c753683ad37fd4b1a1f9 src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6 src/tests/fetcher_tests.cpp 8c0b0757eb388f1684d8b94393983f1844a769a7 src/tests/files_tests.cpp 9ad6db51873b96b3cd759523cef9748f6823fb7e src/tests/gc_tests.cpp 454f0974833ad5db8b504a36b010cc72c3a19751 src/tests/logging_tests.cpp 22a785e80304415ff2aacf76972fd58c74eb5c15 src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed src/tests/metrics_tests.cpp 7512b908ec1cbf80b74b768613a5f7925fa2249e src/tests/monitor_tests.cpp 3b0261946405f9926742a680309880fac7480732 Diff: https://reviews.apache.org/r/29539/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 29538: Replaced Node with network::Address.
On Jan. 22, 2015, 1:23 p.m., Niklas Nielsen wrote: LGTM but fundamentally, it seems like we do not have consensus on this change. Awaiting feedback on the dev@ thread before giving ship-it Think we have gotten to censensus on calling this Address and the IP::Address for InternetAddress. Giving this a ship-it - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29538/#review69265 --- On Jan. 21, 2015, 9:49 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29538/ --- (Updated Jan. 21, 2015, 9:49 a.m.) Review request for mesos, Dominic Hamon, Evelina Dumitrescu, Joris Van Remoortere, and Niklas Nielsen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/include/Makefile.am 542ae1c39283087da6fef69be29c811ac35f00f4 3rdparty/libprocess/include/process/address.hpp PRE-CREATION 3rdparty/libprocess/include/process/future.hpp 0326b23cdd475c6e86b33f9b4c63136fdecab443 3rdparty/libprocess/include/process/network.hpp PRE-CREATION 3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af 3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22 3rdparty/libprocess/include/process/process.hpp 3708f98b8fb6737aafb1c058122a8cd01885b76d 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d 3rdparty/libprocess/src/poll_socket.hpp f7ca08e04f0e2a6c4436579b8e18881376985aa5 3rdparty/libprocess/src/poll_socket.cpp 2e70c6c43a9474c577f7fe409c3722290f247d6c 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f 3rdparty/libprocess/src/tests/benchmarks.cpp b286259afd5bd4b3ff47e04d754e675e2db0e6d1 3rdparty/libprocess/src/tests/http_tests.cpp c71a91d516214d20d3df4c220e4a39a070db3260 3rdparty/libprocess/src/tests/metrics_tests.cpp 0c80c69bc3457fd70ab745ff8a02be6ec9cfd9e7 3rdparty/libprocess/src/tests/process_tests.cpp 3bbfe0a7a65acb52d139fda81816acf305d891f5 Diff: https://reviews.apache.org/r/29538/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 29538: Replaced Node with network::Address.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29538/#review70143 --- Ship it! Modulus out-standing issues - Niklas Nielsen On Jan. 21, 2015, 9:49 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29538/ --- (Updated Jan. 21, 2015, 9:49 a.m.) Review request for mesos, Dominic Hamon, Evelina Dumitrescu, Joris Van Remoortere, and Niklas Nielsen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/include/Makefile.am 542ae1c39283087da6fef69be29c811ac35f00f4 3rdparty/libprocess/include/process/address.hpp PRE-CREATION 3rdparty/libprocess/include/process/future.hpp 0326b23cdd475c6e86b33f9b4c63136fdecab443 3rdparty/libprocess/include/process/network.hpp PRE-CREATION 3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af 3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22 3rdparty/libprocess/include/process/process.hpp 3708f98b8fb6737aafb1c058122a8cd01885b76d 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d 3rdparty/libprocess/src/poll_socket.hpp f7ca08e04f0e2a6c4436579b8e18881376985aa5 3rdparty/libprocess/src/poll_socket.cpp 2e70c6c43a9474c577f7fe409c3722290f247d6c 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f 3rdparty/libprocess/src/tests/benchmarks.cpp b286259afd5bd4b3ff47e04d754e675e2db0e6d1 3rdparty/libprocess/src/tests/http_tests.cpp c71a91d516214d20d3df4c220e4a39a070db3260 3rdparty/libprocess/src/tests/metrics_tests.cpp 0c80c69bc3457fd70ab745ff8a02be6ec9cfd9e7 3rdparty/libprocess/src/tests/process_tests.cpp 3bbfe0a7a65acb52d139fda81816acf305d891f5 Diff: https://reviews.apache.org/r/29538/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 30082: Cleaned up namespace hierarchy in allocation sources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30082/#review70262 --- Ship it! Ship It! - Niklas Nielsen On Jan. 28, 2015, 9:32 a.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30082/ --- (Updated Jan. 28, 2015, 9:32 a.m.) Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-2213 https://issues.apache.org/jira/browse/MESOS-2213 Repository: mesos-git Description --- See summary. Diffs - src/local/local.hpp 0aa50ef src/local/local.cpp 76e73a4 src/master/allocation/allocator.hpp PRE-CREATION src/master/allocation/mesos/allocator.hpp PRE-CREATION src/master/allocation/mesos/hierarchical.hpp PRE-CREATION src/master/allocation/sorter.hpp PRE-CREATION src/master/allocation/sorters/drf.hpp PRE-CREATION src/master/allocation/sorters/drf.cpp PRE-CREATION src/master/main.cpp e5e76ce src/master/master.hpp 1d342e5 src/master/master.cpp 54f2690 src/tests/cluster.hpp 74cedb3 src/tests/fault_tolerance_tests.cpp e0065b3 src/tests/hierarchical_allocator_tests.cpp f44d9e9 src/tests/master_allocator_tests.cpp 2430622 src/tests/master_authorization_tests.cpp 42ffe24 src/tests/master_tests.cpp 678d27f src/tests/mesos.hpp 3f4704b src/tests/mesos.cpp 5ed4df5 src/tests/partition_tests.cpp fea7801 src/tests/rate_limiting_tests.cpp 7f5ca25 src/tests/resource_offers_tests.cpp ffad1f8 src/tests/slave_recovery_tests.cpp d135856 src/tests/sorter_tests.cpp 520a42e Diff: https://reviews.apache.org/r/30082/diff/ Testing --- make check (OS X) Thanks, Alexander Rukletsov
Re: Review Request 30074: Added max allowed age to Slave stats.json endpoint
On Jan. 28, 2015, 10:17 a.m., Niklas Nielsen wrote:
src/slave/slave.cpp, line 132
https://reviews.apache.org/r/30074/diff/3/?file=828310#file828310line132
You don't have to initialize Option types with None. They will
automatically be that :)
Alexander Rukletsov wrote:
This is more explicit though. Do we have an agreement for such cases?
Feel free to drop - think we do both:
https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L127 vs
https://github.com/apache/mesos/blob/master/src/slave/slave.hpp#L406
- Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30074/#review70029
---
On Jan. 21, 2015, 5:55 a.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30074/
---
(Updated Jan. 21, 2015, 5:55 a.m.)
Review request for mesos, Niklas Nielsen and Till Toenshoff.
Bugs: mesos-2229
https://issues.apache.org/jira/browse/mesos-2229
Repository: mesos-git
Description
---
Adds and entry `max_allowed_age` to the response of the stats.json endpoint
in the slave. The format of the value is `{double}(days|mins|secs)`.
The max allowed age value is available only if it is set, which depends on
the flag `--disk_watch_interval` which by default runs every minute (So it
will only be available after the first minute running).
Modifies the unit test `SlaveTest.MetricsInStatsEndpoint` so it takes into
account the new entry.
Diffs
-
src/slave/http.cpp d1cf8a6
src/slave/slave.hpp 70bd8c1
src/slave/slave.cpp fca83b3
src/tests/slave_tests.cpp a85a028
Diff: https://reviews.apache.org/r/30074/diff/
Testing
---
make check
Thanks,
Alexander Rojas
Re: Review Request 30074: Added max allowed age to Slave stats.json endpoint
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30074/#review70029
---
Thanks for submitting this Alexander!
I have a few questions/suggestions below :)
src/slave/http.cpp
https://reviews.apache.org/r/30074/#comment114961
Why stats and not state.json?
src/slave/http.cpp
https://reviews.apache.org/r/30074/#comment114967
We should think about how to get the fact in, that it integer is a number
of seconds.
How about something like:
max_allowed_directory_age_seconds = 42
or
max_allowed_directory_seconds = 42
?
src/slave/slave.hpp
https://reviews.apache.org/r/30074/#comment114960
We can make this a bit more precise. It is not just any files, but the
executor directories/sandboxes.
How about having something like:
// Maximum age of executor directories. Will be recomputed periodically
every flags.disk_watch_interval.
src/slave/slave.cpp
https://reviews.apache.org/r/30074/#comment114966
You don't have to initialize Option types with None. They will
automatically be that :)
src/slave/slave.cpp
https://reviews.apache.org/r/30074/#comment114955
You don't need to use some() here. You can just set the value:
maxAllowedAge = age(usage.get());
src/tests/slave_tests.cpp
https://reviews.apache.org/r/30074/#comment114964
Instead of setting this low (which would still cause a 1s+ test). How about
forwarding the clock with flags.disk_watch_interval? That should trigger the
timeout immediately
- Niklas Nielsen
On Jan. 21, 2015, 5:55 a.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30074/
---
(Updated Jan. 21, 2015, 5:55 a.m.)
Review request for mesos, Niklas Nielsen and Till Toenshoff.
Bugs: mesos-2229
https://issues.apache.org/jira/browse/mesos-2229
Repository: mesos-git
Description
---
Adds and entry `max_allowed_age` to the response of the stats.json endpoint
in the slave. The format of the value is `{double}(days|mins|secs)`.
The max allowed age value is available only if it is set, which depends on
the flag `--disk_watch_interval` which by default runs every minute (So it
will only be available after the first minute running).
Modifies the unit test `SlaveTest.MetricsInStatsEndpoint` so it takes into
account the new entry.
Diffs
-
src/slave/http.cpp d1cf8a6
src/slave/slave.hpp 70bd8c1
src/slave/slave.cpp fca83b3
src/tests/slave_tests.cpp a85a028
Diff: https://reviews.apache.org/r/30074/diff/
Testing
---
make check
Thanks,
Alexander Rojas
Re: Review Request 29883: Added /master/slaves and /master/frameworks/{framework}/tasks/{task} endpoints.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/#review70034 --- A high level comment: we should probably split this patch into one for the slaves endpoint and one for the framework one :) src/master/http.cpp https://reviews.apache.org/r/29883/#comment114978 Why static const and not just const? Also, why the capitilization? src/master/http.cpp https://reviews.apache.org/r/29883/#comment114979 Would you mind throwing in a comment on how the parser will fill this out? I had to reread the code below a couple of times to make sense of it, which was maybe a hint that there should be some supporting documentation :) src/master/http.cpp https://reviews.apache.org/r/29883/#comment114988 One thought: we already have helpers to let us model JSON from various Mesos structs and protobuf types. I wonder if, for consistency, we could do the same thing here. This would mean we could use something like: return OK(model(master-frameworks.registered), ...); instead. src/master/http.cpp https://reviews.apache.org/r/29883/#comment114989 Same thing for tasks: we could have a model overload which took a vector of tasks and modeled them. That way, we could get rid of the tasks() overloads too. Thoughts? src/master/http.cpp https://reviews.apache.org/r/29883/#comment114981 How about using the model() for task? https://github.com/apache/mesos/blob/master/src/common/http.hpp#L43 src/master/http.cpp https://reviews.apache.org/r/29883/#comment114968 tasks() has a bit of an awkward overload (taken the existing endpoint). Let's think about if we can seperate the two somehow. src/master/http.cpp https://reviews.apache.org/r/29883/#comment114980 Same thing here src/master/master.cpp https://reviews.apache.org/r/29883/#comment114990 Let's see if we can get rid of the overloads instead :) src/master/master.cpp https://reviews.apache.org/r/29883/#comment114991 Let's set the bar and add endpoint documentation up-front src/master/master.cpp https://reviews.apache.org/r/29883/#comment114992 Same here. src/tests/master_tests.cpp https://reviews.apache.org/r/29883/#comment114973 One more newline. src/tests/master_tests.cpp https://reviews.apache.org/r/29883/#comment114974 Mind throwing in comments for the tests you are adding. They should look something like this: https://github.com/apache/mesos/blob/master/src/tests/master_tests.cpp#L2685 src/tests/master_tests.cpp https://reviews.apache.org/r/29883/#comment114972 One more newline src/tests/master_tests.cpp https://reviews.apache.org/r/29883/#comment114997 s/Some/Two/ src/tests/master_tests.cpp https://reviews.apache.org/r/29883/#comment115001 If you are not using the vector to pass the messages around, we have traditionally numbered the variables: https://github.com/apache/mesos/blob/master/src/tests/master_tests.cpp#L1300 and https://github.com/apache/mesos/blob/master/src/tests/master_tests.cpp#L1327 src/tests/master_tests.cpp https://reviews.apache.org/r/29883/#comment115000 Where do you use 'slaves'? src/tests/master_tests.cpp https://reviews.apache.org/r/29883/#comment114971 One more newline src/tests/master_tests.cpp https://reviews.apache.org/r/29883/#comment114970 One more newline src/tests/master_tests.cpp https://reviews.apache.org/r/29883/#comment115002 See comment below. We could, for clarity, compare against a JSON string we put together and parse. src/tests/master_tests.cpp https://reviews.apache.org/r/29883/#comment115005 Could we use join() instead? Here and below for clarity in what goes in the request path. src/tests/master_tests.cpp https://reviews.apache.org/r/29883/#comment115006 Can we use createTasks() here? Take a look at https://github.com/apache/mesos/blob/master/src/tests/status_update_manager_tests.cpp#L141 src/tests/master_tests.cpp https://reviews.apache.org/r/29883/#comment114998 s/ran/run/ src/tests/master_tests.cpp https://reviews.apache.org/r/29883/#comment114996 How about writing the expected json string, parse it and compare with the received one? Here is a place where we are comparing with that approach: https://github.com/apache/mesos/blob/master/src/tests/master_tests.cpp#L2643 src/tests/master_tests.cpp https://reviews.apache.org/r/29883/#comment115007 See comment above about join() src/tests/master_tests.cpp https://reviews.apache.org/r/29883/#comment115004 Same thing here. src/tests/master_tests.cpp https://reviews.apache.org/r/29883/#comment114969 One more newline - Niklas Nielsen On Jan. 16, 2015, 5:37 a.m., Alexander Rojas wrote
Re: Review Request 29526: Replaced network::socket with network::Socket.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29526/#review66615 --- Ship it! Ship It! - Niklas Nielsen On Jan. 1, 2015, 8:45 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29526/ --- (Updated Jan. 1, 2015, 8:45 p.m.) Review request for mesos, Joris Van Remoortere and Niklas Nielsen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/src/tests/http_tests.cpp c71a91d516214d20d3df4c220e4a39a070db3260 3rdparty/libprocess/src/tests/process_tests.cpp 3bbfe0a7a65acb52d139fda81816acf305d891f5 Diff: https://reviews.apache.org/r/29526/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 29527: Moved network::* functions into network.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29527/#review66616 --- Ship it! Taken it's just a code move - Niklas Nielsen On Jan. 1, 2015, 8:46 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29527/ --- (Updated Jan. 1, 2015, 8:46 p.m.) Review request for mesos, Joris Van Remoortere and Niklas Nielsen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/include/Makefile.am 542ae1c39283087da6fef69be29c811ac35f00f4 3rdparty/libprocess/include/process/network.hpp PRE-CREATION 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4 3rdparty/libprocess/src/poll_socket.cpp 2e70c6c43a9474c577f7fe409c3722290f247d6c 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f 3rdparty/libprocess/src/tests/process_tests.cpp 3bbfe0a7a65acb52d139fda81816acf305d891f5 Diff: https://reviews.apache.org/r/29527/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 29541: Added network::resolve and network::hostname.
On Jan. 1, 2015, 9:03 p.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [29526, 29527, 29528, 29529, 29530, 29531, 29532, 29533, 29534, 29535, 29536, 29538, 29539] Failed command: ./support/apply-review.sh -n -r 29539 Error: 2015-01-02 05:03:58 URL:https://reviews.apache.org/r/29539/diff/raw/ [19746/19746] - 29539.patch [1] error: patch failed: src/master/contender.cpp:233 error: src/master/contender.cpp: patch does not apply error: patch failed: src/master/detector.cpp:204 error: src/master/detector.cpp: patch does not apply Failed to apply patch Mind rebasing? - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29541/#review66509 --- On Jan. 1, 2015, 8:46 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29541/ --- (Updated Jan. 1, 2015, 8:46 p.m.) Review request for mesos, Dominic Hamon, Evelina Dumitrescu, Joris Van Remoortere, and Niklas Nielsen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/include/process/network.hpp PRE-CREATION 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf Diff: https://reviews.apache.org/r/29541/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 28655: Introduced Mesos Hooks abstraction.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28655/#review66813 --- Hi Kapil, One high-level observation is that hooks are wired up with function pointers. Can't we use an abstract class with virtual methods instead? src/hook/hook.hpp https://reviews.apache.org/r/28655/#comment110464 Why is a Hook not a pure abstract class? Couldn't this be a virtual function and fit the usual pattern better? src/hook/manager.hpp https://reviews.apache.org/r/28655/#comment110465 newline src/hook/manager.hpp https://reviews.apache.org/r/28655/#comment110471 Should we make the return type a Try so we can capture hook errors? src/hook/manager.cpp https://reviews.apache.org/r/28655/#comment110470 Can you make hooks const? src/hook/manager.cpp https://reviews.apache.org/r/28655/#comment110469 Mind adding some comments on the different steps involved? src/hook/manager.cpp https://reviews.apache.org/r/28655/#comment110449 Add newline src/hook/manager.cpp https://reviews.apache.org/r/28655/#comment110466 Don't you need to acquire the lock here? Or else, why have the lock at all? src/hook/manager.cpp https://reviews.apache.org/r/28655/#comment110448 only 4 space indent. If the decorator returns a try, you can merge it conditionally src/master/flags.hpp https://reviews.apache.org/r/28655/#comment110467 Fly by change. Can we postpone it to a different review? src/master/flags.hpp https://reviews.apache.org/r/28655/#comment110468 Maybe add some examples src/master/master.cpp https://reviews.apache.org/r/28655/#comment110447 s/newLabels/labels/g Why an option type? masterLaunchTaskLabelDecorator always returns a Labels in your case. Shouldn't it be a Try instead? - Niklas Nielsen On Jan. 5, 2015, 2:42 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28655/ --- (Updated Jan. 5, 2015, 2:42 p.m.) Review request for mesos and Niklas Nielsen. Bugs: MESOS-2060 https://issues.apache.org/jira/browse/MESOS-2060 Repository: mesos-git Description --- Hooks are implemented as Mesos modules. The first hook is a task label-decorator that is called during the task launch sequence in Mesos master. This hook allows hook modules to add additional labels to the incoming TaskInfo object. The labels are then read on the slave/executor side which may then act upon them. Diffs - src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 src/hook/hook.hpp PRE-CREATION src/hook/manager.hpp PRE-CREATION src/hook/manager.cpp PRE-CREATION src/master/flags.hpp 1cea50c02f3ad7de1e1ae91d65d1accdb9af7b03 src/master/main.cpp 193d53f13d8b14638b311cc290b5a5802ea56299 src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd src/module/hook.hpp PRE-CREATION src/module/manager.cpp 5e779e4c565ee13206cee59e9097499320474187 Diff: https://reviews.apache.org/r/28655/diff/ Testing --- Added two tests (see https://reviews.apache.org/r/29496/) and ran make check. Thanks, Kapil Arya
Re: Review Request 29533: Added a URL abstraction to stout.
On Jan. 5, 2015, 2:50 p.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp, lines 28-29 https://reviews.apache.org/r/29533/diff/1/?file=805385#file805385line28 Is this complete? It doesn't look like it supports what we currently have in src/zookeeper/url.hpp: ``` // Describes a ZooKeeper URL of the form: // // zk://username:password@servers/path // // Where username:password is for the 'digest' scheme (see ZooKeeper // documentation regarding access controls using ACLs) and servers // is of the form: // // host1:port1,host2:port2,host3:port3 // // Note that in the future we may want to support authentication // mechanisms other than 'digest' and have a URL of the following // form. // // zk://scheme:credentials@servers/path ``` Should we follow: http://tools.ietf.org/html/rfc3986 ? True URL parsing is tricky. - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29533/#review66742 --- On Jan. 1, 2015, 8:46 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29533/ --- (Updated Jan. 1, 2015, 8:46 p.m.) Review request for mesos and Ben Mahler. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp PRE-CREATION Diff: https://reviews.apache.org/r/29533/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 29533: Added a URL abstraction to stout.
On Jan. 5, 2015, 2:50 p.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp, lines 28-29 https://reviews.apache.org/r/29533/diff/1/?file=805385#file805385line28 Is this complete? It doesn't look like it supports what we currently have in src/zookeeper/url.hpp: ``` // Describes a ZooKeeper URL of the form: // // zk://username:password@servers/path // // Where username:password is for the 'digest' scheme (see ZooKeeper // documentation regarding access controls using ACLs) and servers // is of the form: // // host1:port1,host2:port2,host3:port3 // // Note that in the future we may want to support authentication // mechanisms other than 'digest' and have a URL of the following // form. // // zk://scheme:credentials@servers/path ``` Niklas Nielsen wrote: Should we follow: http://tools.ietf.org/html/rfc3986 ? True URL parsing is tricky. Or write a shim on an existing library instead of rewriting: http://uriparser.sourceforge.net/ - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29533/#review66742 --- On Jan. 1, 2015, 8:46 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29533/ --- (Updated Jan. 1, 2015, 8:46 p.m.) Review request for mesos and Ben Mahler. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp PRE-CREATION Diff: https://reviews.apache.org/r/29533/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 29539: Replaced Node with Address in Mesos.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29539/#review66834 --- One high-level question below, or else LGTM src/master/contender.cpp https://reviews.apache.org/r/29539/#comment110491 What guarantees that _url is a domain name? If that doesn't matter, then I don't understand the second argument to url(). src/master/detector.cpp https://reviews.apache.org/r/29539/#comment110492 Same here. - Niklas Nielsen On Jan. 1, 2015, 8:46 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29539/ --- (Updated Jan. 1, 2015, 8:46 p.m.) Review request for mesos and Niklas Nielsen. Repository: mesos-git Description --- See summary. Diffs - src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74 src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406 src/master/detector.cpp 700eb9dde8e71648bacc00a82766634f77cf2d15 src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1 src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e src/slave/http.cpp d1cf8a68fab9a2df44f6c753683ad37fd4b1a1f9 src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b src/tests/fetcher_tests.cpp 8c0b0757eb388f1684d8b94393983f1844a769a7 src/tests/files_tests.cpp 9ad6db51873b96b3cd759523cef9748f6823fb7e src/tests/gc_tests.cpp cb5dc5fa720bd2f344a9c7a3748dbe6f898705ca src/tests/logging_tests.cpp 22a785e80304415ff2aacf76972fd58c74eb5c15 src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894 src/tests/metrics_tests.cpp 7512b908ec1cbf80b74b768613a5f7925fa2249e src/tests/monitor_tests.cpp 3b0261946405f9926742a680309880fac7480732 Diff: https://reviews.apache.org/r/29539/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 28656: Added environment decorator for Slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28656/#review66814 --- High-level comments from the previous RR also applies here (abstract class and Try return type). Another one is the break up of launch task, I'd like to get BenH or BenM's take on it. src/hook/hook.hpp https://reviews.apache.org/r/28656/#comment110472 From previous RR: Shouldn't we make the return type a Try, so we can ignore the result from failed hooks? src/slave/flags.hpp https://reviews.apache.org/r/28656/#comment110450 Can you isolate fly-fixes in another review? Here and below src/slave/slave.cpp https://reviews.apache.org/r/28656/#comment110453 s/newEnvironment/environment/g You only have one. src/slave/slave.cpp https://reviews.apache.org/r/28656/#comment110474 Can you find an example where we wrap like this? To distinguish that it is the environment pointer you are evnentually merging, I tend to lean toward either splitting this up (Get the command pointer and then the environment pointer) or just nest with 2 additional spaces for environment and make it on one line. src/slave/slave.cpp https://reviews.apache.org/r/28656/#comment110473 Why this refactor? Couldn't you just inline the hook like in the master? - Niklas Nielsen On Jan. 5, 2015, 2:42 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28656/ --- (Updated Jan. 5, 2015, 2:42 p.m.) Review request for mesos and Niklas Nielsen. Bugs: MESOS-2060 https://issues.apache.org/jira/browse/MESOS-2060 Repository: mesos-git Description --- Similar to label decorator for Master. Diffs - src/hook/hook.hpp PRE-CREATION src/hook/manager.hpp PRE-CREATION src/hook/manager.cpp PRE-CREATION src/slave/flags.hpp 670997dc3a702cd5edf33f2e5824c5e4dfe4ecef src/slave/main.cpp 2ff2b0d186dd63e1437956e98e3682d83f2f5cd6 src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b Diff: https://reviews.apache.org/r/28656/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 28875: Added remove-executor hook for slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28875/#review66822 --- See comments to prior RR's. src/hook/manager.hpp https://reviews.apache.org/r/28875/#comment110475 How about using TryNothing instead? - Niklas Nielsen On Jan. 5, 2015, 2:42 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28875/ --- (Updated Jan. 5, 2015, 2:42 p.m.) Review request for mesos and Niklas Nielsen. Bugs: MESOS-2060 https://issues.apache.org/jira/browse/MESOS-2060 Repository: mesos-git Description --- This is different from decorators in the sense that it doesn't return anything. Diffs - src/hook/hook.hpp PRE-CREATION src/hook/manager.hpp PRE-CREATION src/hook/manager.cpp PRE-CREATION src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b Diff: https://reviews.apache.org/r/28875/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 29496: Added example hook module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29496/#review66823 --- src/examples/test_hook_module.cpp https://reviews.apache.org/r/29496/#comment110479 I wonder if we can consolidate these strings with the ones in the test code. Have you tried to extern them from the test and grab them here? src/examples/test_hook_module.cpp https://reviews.apache.org/r/29496/#comment110478 Mind adding a comment on what the test env decorator is doing and how you will validate it in together with masterLaunchTaskLabelDecorator and slaveRemoveExecutorHook? src/tests/hook_tests.cpp https://reviews.apache.org/r/29496/#comment110477 Test comment please :-) Also, it is a bit hard following what's going on. Can you add some comments to the test body too? src/tests/hook_tests.cpp https://reviews.apache.org/r/29496/#comment110480 I am not sure I understand why you are doing this. Can you expand a little bit? src/tests/hook_tests.cpp https://reviews.apache.org/r/29496/#comment110476 Same here - Niklas Nielsen On Jan. 5, 2015, 2:42 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29496/ --- (Updated Jan. 5, 2015, 2:42 p.m.) Review request for mesos. Bugs: MESOS-2060 https://issues.apache.org/jira/browse/MESOS-2060 Repository: mesos-git Description --- This module provides hooks for master label decorator, slave executor environment decorator and slave remove executor. A couple of test cases are also provided to verify the hooks from this module. Diffs - src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 src/examples/test_hook_module.cpp PRE-CREATION src/tests/hook_tests.cpp PRE-CREATION src/tests/module.hpp bc1a37df7f95e945363418429fef4d090907c73a src/tests/module.cpp 6cec1cbafe4750cff005191c51ce7c08149c18f4 Diff: https://reviews.apache.org/r/29496/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 29530: Used new std::string Socket::recv/send overloads in tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29530/#review66828 --- Ship it! Ship It! - Niklas Nielsen On Jan. 1, 2015, 8:46 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29530/ --- (Updated Jan. 1, 2015, 8:46 p.m.) Review request for mesos, Joris Van Remoortere and Niklas Nielsen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/src/tests/http_tests.cpp c71a91d516214d20d3df4c220e4a39a070db3260 3rdparty/libprocess/src/tests/process_tests.cpp 3bbfe0a7a65acb52d139fda81816acf305d891f5 Diff: https://reviews.apache.org/r/29530/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 29528: Added std::string overloads of Socket::recv/send.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29528/#review66826 --- 3rdparty/libprocess/src/socket.cpp https://reviews.apache.org/r/29528/#comment110484 Mind adding a comment here and below, for what's going on in the different cases. 3rdparty/libprocess/src/socket.cpp https://reviews.apache.org/r/29528/#comment110482 Should we maybe create a constant for 16 * 4096? 3rdparty/libprocess/src/socket.cpp https://reviews.apache.org/r/29528/#comment110485 Mind adding a comment for what you are guarding against? 3rdparty/libprocess/src/socket.cpp https://reviews.apache.org/r/29528/#comment110487 Why not inline _send? - Niklas Nielsen On Jan. 1, 2015, 8:46 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29528/ --- (Updated Jan. 1, 2015, 8:46 p.m.) Review request for mesos, Joris Van Remoortere and Niklas Nielsen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f Diff: https://reviews.apache.org/r/29528/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 29531: Fix weird outputing when running configure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29531/#review66829 --- Mind adding the before and after output to the description? My m4 is not quite strong enough to imagine it :-) - Niklas Nielsen On Jan. 1, 2015, 8:46 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29531/ --- (Updated Jan. 1, 2015, 8:46 p.m.) Review request for mesos and Niklas Nielsen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/configure.ac 19bc601247f3b1fc6b28d3474fb39f7369bb382f Diff: https://reviews.apache.org/r/29531/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 29532: Fixed style formatting.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29532/#review66830 --- Ship it! Ship It! - Niklas Nielsen On Jan. 1, 2015, 8:46 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29532/ --- (Updated Jan. 1, 2015, 8:46 p.m.) Review request for mesos and Niklas Nielsen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 7976f224ec2dcd8e59079fba100de4b6f647357e Diff: https://reviews.apache.org/r/29532/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 28672: Add configure flag for libevent socket implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28672/#review66836 --- Ship it! Ship It! - Niklas Nielsen On Dec. 18, 2014, 4:28 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28672/ --- (Updated Dec. 18, 2014, 4:28 p.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Bugs: MESOS-1911 https://issues.apache.org/jira/browse/MESOS-1911 Repository: mesos-git Description --- Add configure flag for libevent socket implementation. Diffs - 3rdparty/libprocess/Makefile.am 75870ac754e500bb4ca689201bde677fa7d854d0 3rdparty/libprocess/configure.ac 024f892106cf921d1559ecf59c81fde6a4baaa41 Diff: https://reviews.apache.org/r/28672/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 28063: Introduced grace period in CommandInfo.
On Dec. 28, 2014, 12:32 a.m., Adam B wrote: src/slave/slave.cpp, lines 2666-2667 https://reviews.apache.org/r/28063/diff/5/?file=799499#file799499line2666 Do you plan to fix this before committing? Requires ACL support, so we chose that as a non-target for this patch. - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28063/#review66208 --- On Dec. 23, 2014, 7:25 a.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28063/ --- (Updated Dec. 23, 2014, 7:25 a.m.) Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. Bugs: MESOS-1571 https://issues.apache.org/jira/browse/MESOS-1571 Repository: mesos-git Description --- CommandExecutor grace_period field is designed to be used by slave to propagate the value of the grace period flag further to containerizers and executors. Diffs - include/mesos/mesos.proto 0085aba src/slave/slave.hpp 70bd8c1 src/slave/slave.cpp ed63ded Diff: https://reviews.apache.org/r/28063/diff/ Testing --- make check (Mac OS 10.9.4, Ubuntu 14.04) Thanks, Alexander Rukletsov
Re: Review Request 28063: Introduced grace period in CommandInfo.
On Dec. 24, 2014, 1:20 a.m., Adam B wrote:
src/slave/slave.cpp, lines 2661-2664
https://reviews.apache.org/r/28063/diff/5/?file=799499#file799499line2661
Why not take `flags` as a parameter too? Then setGracePeriod(task,
flags) or setGracePeriod(task, grace_period) could be a static method that
doesn't even need to live on `Slave`.
Alexander Rukletsov wrote:
This sounds reasonable. I suggest to introduce `enforceGracePeriod(task,
grace_period)` in `common/protobuf_utils.{hpp|cpp}`. Does it make sense?
Adam B wrote:
Do we really expect this method to be used anywhere outside of this one
place in slave.cpp? If so, let's move it to protobuf_utils. If not, let's
keep it hidden in slave.cpp until it becomes more widely used.
Generalizing it for then requiring slave::flags (which it needs to be) - I am
not a fan :-/ Keep it local.
On Dec. 24, 2014, 1:20 a.m., Adam B wrote:
src/slave/slave.cpp, lines 1159-1160
https://reviews.apache.org/r/28063/diff/5/?file=799499#file799499line1159
I feel like 'setGracePeriod' is inaccurate if it doesn't always set it
(when already set). Maybe 'updateGracePeriod' or 'enforceGracePeriod' or
'mergeGracePeriod'? You can probably come up with something better.
Alexander Rukletsov wrote:
Currently, the function always sets the grace period. However, this may
change in the future. I tend to agree and go for `enforceGracePeriod()`. What
do you think?
Adam B wrote:
Call it overrideGracePeriod until you fix that TODO and allow already-set
values to survive. At that point, you can rename it to something more
accurate (I still think there's gotta be a better name out there).
Let's go with 'updateGracePeriod' - 'enforcing' is confusing.
- Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28063/#review66019
---
On Dec. 23, 2014, 7:25 a.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28063/
---
(Updated Dec. 23, 2014, 7:25 a.m.)
Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
Bugs: MESOS-1571
https://issues.apache.org/jira/browse/MESOS-1571
Repository: mesos-git
Description
---
CommandExecutor grace_period field is designed to be used by slave to
propagate the value of the grace period flag further to containerizers and
executors.
Diffs
-
include/mesos/mesos.proto 0085aba
src/slave/slave.hpp 70bd8c1
src/slave/slave.cpp ed63ded
Diff: https://reviews.apache.org/r/28063/diff/
Testing
---
make check (Mac OS 10.9.4, Ubuntu 14.04)
Thanks,
Alexander Rukletsov
Re: Support for allocator modules
Hi Alex, Thanks for the write up! Looks good to me and will be looking forward to hack away on new allocation policies. Cheers, Niklas On 13 January 2015 at 06:47, Alex Rukletsov a...@mesosphere.io wrote: Hi all, we would like to start working on modularising the allocator, but before gather some community feedback. The corresponding ticket is here: https://issues.apache.org/jira/browse/MESOS-2160. The motivation for this is to give ourselves, Mesos users, and researchers an easy way to tweak resource allocation policies. Currently Mesos supports only DRF allocator, changing which requires hacking Mesos source code, which, in turn, sets a high entry barrier. We outline three stages: 1. Replace AllocatorProcess with Allocator as an entity that implements allocation policy. Current design prescribes to subclass AllocatorProcess for implementing new allocators. This is not consistent with other similar Mesos components like Isolator, Authenticator. The proposed change will liberate allocators from the necessity to use libprocess’ process under the hood. This will therefore affect allocator tests and test helpers like MockAllocatorProcess (will become MockAllocator). The issue is tracked here: https://issues.apache.org/jira/browse/MESOS-2213. 2. Implement allocator module. Given Allocator class is a base class for all allocators, this should be trivial and similar to how isolator and authenticator modules are implemented. 3. Provide an example and / or test allocator module. What is NOT part of this effort: new allocation algorithms, resource accounting, etc. Best, Alex
Re: Review Request 27588: Removed trailing linefeeds from master and slave help messages.
On Nov. 18, 2014, 9:52 a.m., Niklas Nielsen wrote: Awesome - there are more help texts with trailing newline. Can you do a scan and catch them all? :) ping - let's get this in too. - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27588/#review61947 --- On Nov. 4, 2014, 2:50 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27588/ --- (Updated Nov. 4, 2014, 2:50 p.m.) Review request for mesos. Repository: mesos-git Description --- Also fixed help message for master's credentials flag. Diffs - src/master/flags.hpp 1cea50c02f3ad7de1e1ae91d65d1accdb9af7b03 src/slave/flags.hpp efbd35dd744d8c8a53c36dd5cdb8d1c50fcfec3a Diff: https://reviews.apache.org/r/27588/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 28656: Added environment decorator for Slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28656/#review68000 --- src/slave/slave.hpp https://reviews.apache.org/r/28656/#comment112134 Let's do this as a file-static helper :) src/slave/slave.cpp https://reviews.apache.org/r/28656/#comment112135 How about calling it 'decorateExecutorEnvironment'? - Niklas Nielsen On Jan. 13, 2015, 5:31 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28656/ --- (Updated Jan. 13, 2015, 5:31 p.m.) Review request for mesos and Niklas Nielsen. Bugs: MESOS-2060 https://issues.apache.org/jira/browse/MESOS-2060 Repository: mesos-git Description --- Similar to label decorator for Master. Diffs - src/hook/hook.hpp PRE-CREATION src/hook/manager.hpp PRE-CREATION src/hook/manager.cpp PRE-CREATION src/slave/flags.hpp f1b8dfbb7391167b67a9498561742aa9ab9089a6 src/slave/main.cpp 2ff2b0d186dd63e1437956e98e3682d83f2f5cd6 src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d Diff: https://reviews.apache.org/r/28656/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 29496: Added example hook module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29496/#review68004 --- Ship it! Ship It! - Niklas Nielsen On Jan. 13, 2015, 5:05 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29496/ --- (Updated Jan. 13, 2015, 5:05 p.m.) Review request for mesos and Niklas Nielsen. Bugs: MESOS-2060 https://issues.apache.org/jira/browse/MESOS-2060 Repository: mesos-git Description --- This module provides hooks for master label decorator, slave executor environment decorator and slave remove executor. A couple of test cases are also provided to verify the hooks from this module. Diffs - src/Makefile.am fc0c3227466ccf364353a739fec8d9532ea3c683 src/examples/test_hook_module.cpp PRE-CREATION src/tests/hook_tests.cpp PRE-CREATION src/tests/module.hpp bc1a37df7f95e945363418429fef4d090907c73a src/tests/module.cpp 6cec1cbafe4750cff005191c51ce7c08149c18f4 Diff: https://reviews.apache.org/r/29496/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 28655: Introduced Mesos Hooks abstraction.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28655/#review67994 --- Ship it! Ship It! - Niklas Nielsen On Jan. 13, 2015, 5:04 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28655/ --- (Updated Jan. 13, 2015, 5:04 p.m.) Review request for mesos. Bugs: MESOS-2060 https://issues.apache.org/jira/browse/MESOS-2060 Repository: mesos-git Description --- Hooks are implemented as Mesos modules. The first hook is a task label-decorator that is called during the task launch sequence in Mesos master. This hook allows hook modules to add additional labels to the incoming TaskInfo object. The labels are then read on the slave/executor side which may then act upon them. Diffs - src/Makefile.am fc0c3227466ccf364353a739fec8d9532ea3c683 src/hook/hook.hpp PRE-CREATION src/hook/manager.hpp PRE-CREATION src/hook/manager.cpp PRE-CREATION src/master/flags.hpp f5c8d2a8cc7530bc8746935af9ea90af747cc111 src/master/main.cpp 193d53f13d8b14638b311cc290b5a5802ea56299 src/master/master.cpp 63ca19ab9618feccd93a2335f9287122a4665c5e src/module/hook.hpp PRE-CREATION src/module/manager.cpp 5e779e4c565ee13206cee59e9097499320474187 Diff: https://reviews.apache.org/r/28655/diff/ Testing --- Added two tests (see https://reviews.apache.org/r/29496/) and ran make check. Thanks, Kapil Arya
Re: Review Request 28656: Added environment decorator for Slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28656/#review68002 --- Ship it! Ship It! - Niklas Nielsen On Jan. 13, 2015, 5:31 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28656/ --- (Updated Jan. 13, 2015, 5:31 p.m.) Review request for mesos and Niklas Nielsen. Bugs: MESOS-2060 https://issues.apache.org/jira/browse/MESOS-2060 Repository: mesos-git Description --- Similar to label decorator for Master. Diffs - src/hook/hook.hpp PRE-CREATION src/hook/manager.hpp PRE-CREATION src/hook/manager.cpp PRE-CREATION src/slave/flags.hpp f1b8dfbb7391167b67a9498561742aa9ab9089a6 src/slave/main.cpp 2ff2b0d186dd63e1437956e98e3682d83f2f5cd6 src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d Diff: https://reviews.apache.org/r/28656/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 28514: Updated WhitelistWatcher behaviour and introduced initial whitelist.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28514/#review67412 --- Ship it! Ship It! - Niklas Nielsen On Jan. 9, 2015, 2:21 a.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28514/ --- (Updated Jan. 9, 2015, 2:21 a.m.) Review request for mesos, Cody Maloney, Niklas Nielsen, and Vinod Kone. Repository: mesos-git Description --- The subscriber may now provide an initial whitelist and will be notified only when the parsed whitelist differs from the initial one. The subscriber is not explicitly notified that there is no whitelist unless a valid initial whitelist has been provided before. This change suppresses gmock warnings for uninteresting mock function calls. Diffs - src/watcher/whitelist_watcher.hpp 5838854 src/watcher/whitelist_watcher.cpp 32713bb Diff: https://reviews.apache.org/r/28514/diff/ Testing --- make check (Mac OS 10.9.4, Ubuntu 14.04) checked test log for gmock warnings. Thanks, Alexander Rukletsov
Re: Review Request 29781: Exposed type_utils.hpp as include/mesos/type_utils.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29781/#review71728 --- Ship it! src/common/type_utils.hpp https://reviews.apache.org/r/29781/#comment117597 s/protobufs/protobuf classes/ src/common/type_utils.hpp https://reviews.apache.org/r/29781/#comment117603 It was most likely something in making the isolator public that forced you to expose type_utils as well. Can we find the place and reference it directly here? src/common/type_utils.hpp https://reviews.apache.org/r/29781/#comment117598 s/ / /g - Niklas Nielsen On Feb. 4, 2015, 7:15 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29781/ --- (Updated Feb. 4, 2015, 7:15 p.m.) Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. Bugs: MESOS-2096 https://issues.apache.org/jira/browse/MESOS-2096 Repository: mesos Description --- [3/9] Build Mesos Modules outside Mesos source tree. This file includes definitions for operators on public protobufs (defined in mesos.proto) that don't have these operators generated by the protobuf compiler. The corresponding definitions are in src/common/type_utils.cpp. Mesos modules need some of the protobufs defined in mesos.proto and require some of these operators declared in type_utils.hpp. Exposing type_utils.hpp allows us to build modules without having a dependency on mesos source tree (src/*). Diffs - src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc src/cli/execute.cpp 77deec91177c90a8a20ccd4fe063b82ca08cefbd src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553 src/common/type_utils.hpp b23eeb8a4055f596aba40d0c8a8250530c870876 src/common/type_utils.cpp fcc9eb0e27a9cbf53f7923f0c051a6578527ec37 src/examples/low_level_scheduler_libprocess.cpp a0ec131fff1773280b17e97cb78a3da88afe6f7d src/examples/low_level_scheduler_pthread.cpp f05489ae10032dcf177ce149938cd94186355351 src/examples/no_executor_framework.cpp 5e47cfcfa1677052be114f8a9b0e24f6ef0238d9 src/examples/test_framework.cpp 7c062dc8fbb4a48047276ecc45ec2af4ed280d6f src/exec/exec.cpp aada24664dba9060a92230e25689c89852585443 src/launcher/executor.cpp 1cf28f168cac6e8c7e98686a35509c2b4e052504 src/log/coordinator.cpp fe0c5f9c55fd7a19b9c85a0860f88dd14205a631 src/log/recover.cpp 679741b843a1df112090cd2ce2b1bc20abbbcf44 src/log/replica.cpp dedfde4eebc12c6c4d1e75fe1f6751a56324688a src/master/http.cpp 3981b18cb82d3b8bd974b80d27f14c304898a43c src/master/master.hpp dcfd38ae2fa9e1bd0b477e9719724dba37114d30 src/master/registrar.cpp 0831963e01e3c87bf0ac27af24b832ab2ae09d97 src/master/validation.cpp 2c4b16df1ffe34c7e2a60a3d428242da4c20c347 src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2 src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268 src/slave/containerizer/external_containerizer.cpp 8d5a9047afb24a29413bfc7226f47b1edbfa4ff9 src/slave/containerizer/isolators/cgroups/cpushare.cpp 90aabb85da452a3a50f738379a73b7465dc6 src/slave/containerizer/isolators/cgroups/mem.cpp 711d66d7771cac13be831d73af3ef570d6785473 src/slave/http.cpp 0395d003e308f6af11242d88d7eeea104d5e47fc src/slave/monitor.hpp f4ebafc5bbba43669dc1436899072b009936a22e src/slave/paths.cpp 5fcfa2c78ada6f69a78fd43de067d15abb0366fa src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b src/slave/state.hpp f92808ad9b1623cea0c35ec735c53a3d6457bdbe src/slave/status_update_manager.hpp daab8e332a286ed98fd54d170853b4edcf9f915e src/tests/flags.hpp 0d3db6cd13b898674e7e62ce90543c5834225294 src/tests/protobuf_io_tests.cpp d5d788c32ef9d4e9434401464ed1c549b4559b38 src/tests/registrar_tests.cpp 6bfb679d6ab07143f9c77b8cd9719a36d363645f src/tests/state_tests.cpp ef2e96fb8b3a5e3b9c3c045b22f43f818d327b9e Diff: https://reviews.apache.org/r/29781/diff/ Testing --- make check. Thanks, Kapil Arya
Re: Review Request 29606: Exposed authentication headers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29606/#review71733 --- Ship it! src/Makefile.am https://reviews.apache.org/r/29606/#comment117600 How about moving these to their own directory? similiary to the isolator include? - Niklas Nielsen On Feb. 4, 2015, 7:16 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29606/ --- (Updated Feb. 4, 2015, 7:16 p.m.) Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. Bugs: MESOS-2096 https://issues.apache.org/jira/browse/MESOS-2096 Repository: mesos Description --- [8/9] Build Mesos Modules outside Mesos source tree. This allows authentication modules to be built outside the mesos source tree. Diffs - src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc src/authentication/authenticatee.hpp 361083b5e1ca5ab1a594b3108fb768626313a725 src/authentication/authenticator.hpp 460494a49ad7c71803507afe62005280d5929d41 src/authentication/cram_md5/authenticatee.hpp 5d35598f75f4d9a8c185cfd387e1085b3bf15395 src/authentication/cram_md5/authenticator.hpp d739a02d755c2729248291db8c274ad7e7dd4c6d src/examples/test_authentication_modules.cpp 6d32573d4e7817ddb62f3eb7aca2cf3f06d27c65 src/master/master.hpp dcfd38ae2fa9e1bd0b477e9719724dba37114d30 src/master/master.cpp 234bbecc4205036d790b026abd59100eb188f913 src/module/authenticatee.hpp bae37ced0b5da5dec2ff91d795cc8e75fd8900f2 src/module/authenticator.hpp 956233852c355f67b890479b7330d2d2f01dbaf3 src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2 src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268 src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b src/tests/cram_md5_authentication_tests.cpp a356aa1fbcf5492b22e78bd4e7ee1d092f5cf736 Diff: https://reviews.apache.org/r/29606/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 30052: Exposed Hook headers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30052/#review71734 --- Ship it! Ship It! - Niklas Nielsen On Feb. 4, 2015, 7:16 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30052/ --- (Updated Feb. 4, 2015, 7:16 p.m.) Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. Bugs: MESOS-2096 https://issues.apache.org/jira/browse/MESOS-2096 Repository: mesos Description --- [9/9] Build Mesos Modules outside Mesos source tree. Moved hook/hook.hpp to include/mesos/ and module/hook.hpp to include/mesos/module. Diffs - src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc src/examples/test_hook_module.cpp 04fd43eb3eacae0d850dd7f4e191116d20620f10 src/hook/hook.hpp 9401e03192e53019b80e9a29a322195250cc019b src/hook/manager.hpp aadc17aa8f56f8f6ae23ed427cd344f07f7db0c7 src/hook/manager.cpp 6bf1ef7bdddee78a0fab1a942aa89edfd9eb719e src/module/hook.hpp a7c51f2f46d075a291b2f8e980ae87fd4eee26bb Diff: https://reviews.apache.org/r/30052/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 29605: Moved authentication messages to mesos/authentication.proto.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29605/#review71731 --- Ship it! src/Makefile.am https://reviews.apache.org/r/29605/#comment117599 Let's move this to it's own directory too :) - Niklas Nielsen On Feb. 4, 2015, 7:16 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29605/ --- (Updated Feb. 4, 2015, 7:16 p.m.) Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. Bugs: MESOS-2096 https://issues.apache.org/jira/browse/MESOS-2096 Repository: mesos Description --- [7/9] Build Mesos Modules outside Mesos source tree. To allow authentication modules being built outside the Mesos source tree to use protobufs related to authentication. Diffs - include/mesos/authentication.hpp PRE-CREATION include/mesos/authentication.proto PRE-CREATION src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc src/authentication/authenticatee.hpp 361083b5e1ca5ab1a594b3108fb768626313a725 src/authentication/authenticator.hpp 460494a49ad7c71803507afe62005280d5929d41 src/messages/messages.proto 8d86517039ec825b7d2ace6673da8971e140fa5e src/tests/authentication_tests.cpp 5cf2da4602edbf7c168351d5f581aca10591d5d0 src/tests/fault_tolerance_tests.cpp f927d4ae9577aff2dd0ba54f1f4b5dd81e815667 Diff: https://reviews.apache.org/r/29605/diff/ Testing --- make check. Thanks, Kapil Arya
Re: Review Request 30338: Introduced ExecutorRunState struct for Isolators and Launchers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30338/#review71739 --- src/slave/containerizer/isolator.hpp https://reviews.apache.org/r/30338/#comment117606 s/ / /g src/slave/containerizer/isolator.hpp https://reviews.apache.org/r/30338/#comment117607 s/ / /g src/slave/containerizer/launcher.cpp https://reviews.apache.org/r/30338/#comment117613 src/slave/containerizer/mesos/containerizer.cpp https://reviews.apache.org/r/30338/#comment117611 Could you const this? Result from run.get() would be const. Probably won't make any big difference, so not religious about it. src/slave/flags.hpp https://reviews.apache.org/r/30338/#comment117605 Can you move this to the type_utils patch :) - Niklas Nielsen On Feb. 9, 2015, 6:38 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30338/ --- (Updated Feb. 9, 2015, 6:38 p.m.) Review request for mesos, Ian Downes, Niklas Nielsen, Till Toenshoff, and Vinod Kone. Bugs: MESOS-2096 https://issues.apache.org/jira/browse/MESOS-2096 Repository: mesos Description --- [4/9] Build Mesos Modules outside Mesos source tree. The struct is constructed from some fields of RunState and passed on to Isolators. This further allows us to do cleanup various isolators/launchers. The goal was to remove the dependency on RunState so that we can eventually expose slave/containerizer/isolator.hpp as a public header. Diffs - src/slave/containerizer/external_containerizer.hpp 12968781b47cbf53bef2529d6bbc3819b09c36e9 src/slave/containerizer/isolator.hpp e39a8a5e7ecd3273cabab2d7f4038eb7a6d88bb3 src/slave/containerizer/isolator.cpp bb4da46f2d0984956b57ffbb065dc3cc43ff8262 src/slave/containerizer/isolators/cgroups/cpushare.hpp 1050af7394fa7b181ce5e1d1841c397da7649b84 src/slave/containerizer/isolators/cgroups/cpushare.cpp 6554ca3d8c45f449ca5414c695efe813f31a101b src/slave/containerizer/isolators/cgroups/mem.hpp 4de5c646d2869f5893158a260f973ec098bcc33e src/slave/containerizer/isolators/cgroups/mem.cpp 0bb4039ba83698e663ab0527f90c46ed7bd11bf5 src/slave/containerizer/isolators/cgroups/perf_event.hpp 6bf885820d09d6ee3190b465851207a46dacd038 src/slave/containerizer/isolators/cgroups/perf_event.cpp f94eeaecbf4b60b5a29b54fff8eb2db9c30e8bef src/slave/containerizer/isolators/filesystem/shared.hpp a5b5ca1dd598ea35aa6d08ded93f881eb6bc2c65 src/slave/containerizer/isolators/filesystem/shared.cpp 85a5ade7fd739f95c7ab940641358af3dc76acef src/slave/containerizer/isolators/namespaces/pid.hpp 7052a033c1beeb8dab73ef0f4e75185d6130650a src/slave/containerizer/isolators/namespaces/pid.cpp 0ad102d00276b4f5a3141ac16eb7ed186690e4be src/slave/containerizer/isolators/network/port_mapping.hpp 1e4ed3d3929b648308dfd03d1f8b578988cf079d src/slave/containerizer/isolators/network/port_mapping.cpp 361e33b013fd37dfbcda701bf13c28b3420160ef src/slave/containerizer/isolators/posix.hpp b6d289bc2a7e9d0e86c2a2bf7134b9612754830f src/slave/containerizer/isolators/posix/disk.hpp 58a06c7f47b33006705b1ded8f4fdcff95cabb2d src/slave/containerizer/isolators/posix/disk.cpp b2be552035ced393e5e0c0e41e701fcbdcddf190 src/slave/containerizer/launcher.hpp b6fab38865c2be576ced5486a55ae931730572ed src/slave/containerizer/launcher.cpp f2267adbfabc936c7f99711b53e2bf62de37a18a src/slave/containerizer/linux_launcher.hpp 0d630facc90f55ed7f9559e66a5349a30337528f src/slave/containerizer/linux_launcher.cpp 8417160e756018da8233c7a3287e35781b5743da src/slave/containerizer/mesos/containerizer.hpp b3aafe4efa9f3469d7a3fd39243ad66b46d6a54d src/slave/containerizer/mesos/containerizer.cpp fa40d47aee7803833bcde6cce1e86a21d7cf27d0 src/slave/flags.hpp f6033355d129f0013d39dd053455c936596bf159 src/tests/isolator.hpp 7c40f3cb419057c91b307f164edcdb724d45c50d Diff: https://reviews.apache.org/r/30338/diff/ Testing --- make check. Thanks, Kapil Arya
Re: Review Request 29598: Moved Modules protobuf to mesos/modules.proto.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29598/#review71706 --- Ship it! src/Makefile.am https://reviews.apache.org/r/29598/#comment117572 Should we contain this in it's own directory? It looks a bit inconsistent compared to containerizer, fetcher and scheduler - Niklas Nielsen On Feb. 4, 2015, 7:15 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29598/ --- (Updated Feb. 4, 2015, 7:15 p.m.) Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. Bugs: MESOS-2096 https://issues.apache.org/jira/browse/MESOS-2096 Repository: mesos Description --- [1/9] Build Mesos Modules outside Mesos source tree. To expose Modules message outside the mesos source tree. This allows modules to #include mesos/mesos.hpp and get the required protobuf definition. Diffs - include/mesos/module.hpp 594212605127522a1b5f0d1335d6c208b499289b include/mesos/module.proto PRE-CREATION src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 src/common/type_utils.hpp b23eeb8a4055f596aba40d0c8a8250530c870876 src/master/flags.hpp e9f6fff28153212756c9d78be733ec045f291483 src/messages/messages.proto 8d86517039ec825b7d2ace6673da8971e140fa5e src/slave/flags.hpp facf6d3e68e412897a1381d7bbdcceaf5d1fbb94 Diff: https://reviews.apache.org/r/29598/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 29603: Exposed slave/containerizer/isolator.hpp as mesos/slave/isolator.hpp
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29603/#review71743 --- Ship it! - Niklas Nielsen On Feb. 4, 2015, 7:15 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29603/ --- (Updated Feb. 4, 2015, 7:15 p.m.) Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. Bugs: MESOS-2096 https://issues.apache.org/jira/browse/MESOS-2096 Repository: mesos Description --- [5/9] Build Mesos Modules outside Mesos source tree. Expose slave/state.hpp and slave/containerizer/isolator.hpp to allow modules to include them directly from the Mesos install location. Diffs - src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 src/slave/containerizer/containerizer.cpp 421bb868b353e644578fa27f04bdd636bfc89134 src/slave/containerizer/external_containerizer.hpp 8363cec490a2918e08a8d30d9b8832fd1e2dd4f5 src/slave/containerizer/isolator.hpp a27c3e955ff25b87599af0ac2c97427a88b786f6 src/slave/containerizer/isolator.cpp 90a47c4fc8ce2d1a2aa09fa9ad905b76eab74c80 src/slave/containerizer/isolators/cgroups/cpushare.hpp 4ded0c4678ad61742a69e14233006a448f3fc3ca src/slave/containerizer/isolators/cgroups/mem.hpp 2fa755571b4d21b8b13301fcfd57ae05ea66e6e6 src/slave/containerizer/isolators/cgroups/perf_event.hpp e511c3efe4cc4ec13cc74bdcda993477a4db2e36 src/slave/containerizer/isolators/filesystem/shared.hpp 727f63e16fa69293c472a4b6b95fb0be04e689c8 src/slave/containerizer/isolators/namespaces/pid.hpp 8da6cccff04edf11fa37f5a33648821299cf49d5 src/slave/containerizer/isolators/network/port_mapping.hpp 90d19a95092bc18c1077fbaec9ebf9c87291474c src/slave/containerizer/isolators/posix.hpp 7a667e3e30712b98484947520b58965d3b768659 src/slave/containerizer/isolators/posix/disk.hpp cf4e143eb50cf5ee59ca0d47dd6f8d0a845c3732 src/slave/containerizer/launcher.hpp 18b3546a5e51e8a3819bca11630f699a0aadf762 src/slave/containerizer/mesos/containerizer.hpp 569119fc591ecb118ecff51b8b19d0a1b8090cb5 src/slave/containerizer/mesos/containerizer.cpp d712278428889ebdfd598537690138329d8464f0 src/tests/containerizer_tests.cpp cfe31a6b528ec44c5f4ff9eaf453c68d9e518db4 src/tests/isolator.hpp 2c3a694fade996df6fb679e78f96876a7d32d214 src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc src/tests/port_mapping_tests.cpp 18d58ff310d189f7461eead445e186172cbcd101 Diff: https://reviews.apache.org/r/29603/diff/ Testing --- make check. Thanks, Kapil Arya
Re: Review Request 30948: Reverted configurable graceful shutdown period patch set.
On Feb. 13, 2015, 10:15 a.m., Ben Mahler wrote: This looks good, I'm curious though, were you unable to revert the specific commits at this point? Ben Mahler wrote: How did you get this diff? I did a reverse diff of the chain and fixed the conflicts. I could have split this in the original three patches - would you prefer that? - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30948/#review72401 --- On Feb. 12, 2015, 1:05 p.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30948/ --- (Updated Feb. 12, 2015, 1:05 p.m.) Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone. Repository: mesos Description --- Reverted patch set (to be reworked after 0.22) Diffs - include/mesos/mesos.proto 3a2921dff856d37455593dcbf7340aa537997d35 src/Makefile.am 05ee76d5f08a28f4ad6129b8c4f472722732aa92 src/exec/exec.cpp 349294369a68be5edf0f38fcc2ec3b762d5c02a9 src/launcher/executor.cpp 8f47f0e23288279f003f8739fb7c5242041fc6ab src/slave/constants.hpp 7717abd4f9a3bd6fdca6af2364864e374ce2e056 src/slave/constants.cpp cdf5c46fc13e6e5d602a3b1397b5e5d5fd3d13d0 src/slave/containerizer/containerizer.cpp 4e0dc3b8a110adeab12c0c249f90ca18b240bbba src/slave/flags.hpp 6ef64ed118c8cb311f97c58069337ab08010baa6 src/slave/graceful_shutdown.hpp 950329ddf6968b61dc10feb50c2fc2fddc97f014 src/slave/graceful_shutdown.cpp 2ab58f7b874078643185762e86640b54950fe270 src/slave/slave.cpp 1e60454cecfe387c4906a74f176bef00c2e0dbb7 src/tests/gc_tests.cpp 45efce347af7ad6bedd193715611dc0a67f5d767 src/tests/slave_tests.cpp a02e335576bf68b449a6286fa5cf5093b1b7182a Diff: https://reviews.apache.org/r/30948/diff/ Testing --- make check Thanks, Niklas Nielsen
Re: Review Request 30948: Reverted configurable graceful shutdown period patch set.
On Feb. 13, 2015, 12:41 a.m., Alexander Rukletsov wrote: Just to confirm: do we revert these patches from master or from 0.22 release only? From master/HEAD. Instead of cherry picking the commits out (which would potentially touch many commits), we tag HEAD and apply the reverse diff. - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30948/#review72347 --- On Feb. 12, 2015, 1:05 p.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30948/ --- (Updated Feb. 12, 2015, 1:05 p.m.) Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone. Repository: mesos Description --- Reverted patch set (to be reworked after 0.22) Diffs - include/mesos/mesos.proto 3a2921dff856d37455593dcbf7340aa537997d35 src/Makefile.am 05ee76d5f08a28f4ad6129b8c4f472722732aa92 src/exec/exec.cpp 349294369a68be5edf0f38fcc2ec3b762d5c02a9 src/launcher/executor.cpp 8f47f0e23288279f003f8739fb7c5242041fc6ab src/slave/constants.hpp 7717abd4f9a3bd6fdca6af2364864e374ce2e056 src/slave/constants.cpp cdf5c46fc13e6e5d602a3b1397b5e5d5fd3d13d0 src/slave/containerizer/containerizer.cpp 4e0dc3b8a110adeab12c0c249f90ca18b240bbba src/slave/flags.hpp 6ef64ed118c8cb311f97c58069337ab08010baa6 src/slave/graceful_shutdown.hpp 950329ddf6968b61dc10feb50c2fc2fddc97f014 src/slave/graceful_shutdown.cpp 2ab58f7b874078643185762e86640b54950fe270 src/slave/slave.cpp 1e60454cecfe387c4906a74f176bef00c2e0dbb7 src/tests/gc_tests.cpp 45efce347af7ad6bedd193715611dc0a67f5d767 src/tests/slave_tests.cpp a02e335576bf68b449a6286fa5cf5093b1b7182a Diff: https://reviews.apache.org/r/30948/diff/ Testing --- make check Thanks, Niklas Nielsen
Re: Review Request 29607: Disabled installing module libraries.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29607/#review71832 --- Ship it! src/Makefile.am https://reviews.apache.org/r/29607/#comment117692 Copy past :) Do we want this comment for every module? I think just having it on the first one would suffice - Niklas Nielsen On Feb. 10, 2015, 10:52 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29607/ --- (Updated Feb. 10, 2015, 10:52 a.m.) Review request for mesos, Niklas Nielsen and Till Toenshoff. Repository: mesos Description --- Module libraries (libtestisolator, libtestauthentication, libtesthook, and libexamplemodule) are needed for Mesos test suite only. Diffs - src/Makefile.am fae36ac2d539a9aa4c7cd0035275ff6b9260ea49 Diff: https://reviews.apache.org/r/29607/diff/ Testing --- Verified that the files are not installed after a 'make install'. Thanks, Kapil Arya
Re: Review Request 30580: Updated the graceful shutdown documentation and naming.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30580/#review71855 --- Ship it! Ship It! - Niklas Nielsen On Feb. 3, 2015, 6:14 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30580/ --- (Updated Feb. 3, 2015, 6:14 p.m.) Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone. Repository: mesos Description --- This is a pure cleanup to clarify the documentation and naming around graceful shutdown. Note that I also namespaced the methods differently. Diffs - src/exec/exec.cpp aada24664dba9060a92230e25689c89852585443 src/launcher/executor.cpp 1cf28f168cac6e8c7e98686a35509c2b4e052504 src/slave/constants.hpp 761cfafb3b1b342af4d1dbdb2dec39a45dd62794 src/slave/flags.hpp 0f6cc41d60a2e3bc2121cc438351135541ef99ba src/slave/graceful_shutdown.hpp 59f5cfba032a81b5f69c2dd1bc1d96527686127c src/slave/graceful_shutdown.cpp 04d8f091dfc5a007ac46ccc91c7ff7bfe620b524 src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b src/tests/gc_tests.cpp 454f0974833ad5db8b504a36b010cc72c3a19751 src/tests/slave_tests.cpp e7e2af63da785644f3f7e6e23607c02be962a2c6 Diff: https://reviews.apache.org/r/30580/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 30583: Fixed MESOS_RECOVERY_TIMEOUT to be based on the flag value.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30583/#review71856 --- Ship it! Modulo Vinod's comments - Niklas Nielsen On Feb. 4, 2015, 2:43 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30583/ --- (Updated Feb. 4, 2015, 2:43 p.m.) Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone. Bugs: MESOS-2228 https://issues.apache.org/jira/browse/MESOS-2228 Repository: mesos Description --- Now the `MESOS_RECOVERY_TIMEOUT` environment variable is set based on the flag value, instead of the `EXECUTOR_SHUTDOWN_GRACE_PERIOD` constant. It also now correctly uses `Duration::create` to interpret the protobuf value. Diffs - src/exec/exec.cpp aada24664dba9060a92230e25689c89852585443 src/launcher/executor.cpp 1cf28f168cac6e8c7e98686a35509c2b4e052504 src/slave/containerizer/containerizer.hpp 129e60f20835f5d151701e934330b81825887af1 src/slave/containerizer/containerizer.cpp 421bb868b353e644578fa27f04bdd636bfc89134 src/slave/containerizer/docker.hpp b7bf54ac65d6c61622e485ac253513eaac2e4f88 src/slave/containerizer/docker.cpp 5f4b4ce49a9523e4743e5c79da4050e6f9e29ed7 src/slave/containerizer/external_containerizer.cpp 8d5a9047afb24a29413bfc7226f47b1edbfa4ff9 src/slave/containerizer/mesos/containerizer.cpp d712278428889ebdfd598537690138329d8464f0 src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 src/tests/containerizer.cpp 26b87ac6b16dfeaf84888e80296ef540697bd775 src/tests/gc_tests.cpp 454f0974833ad5db8b504a36b010cc72c3a19751 src/tests/hook_tests.cpp 44f73effdce2d03627215418007ccbc3263a0c52 src/tests/master_allocator_tests.cpp 018a6ccba8bb78974de06398f423f1f30ef3a3df src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed src/tests/mesos.cpp 5ed4df530cf1bf11eec3b29542641822e0f702b2 src/tests/slave_recovery_tests.cpp 7e2e63d4b8a1cd7c191374bc37073d83ae413e03 src/tests/slave_tests.cpp e7e2af63da785644f3f7e6e23607c02be962a2c6 Diff: https://reviews.apache.org/r/30583/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 30601: Updated slave to use Executor/Task grace period, with a maximum.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30601/#review71864 --- Ship it! Ship It! - Niklas Nielsen On Feb. 5, 2015, 1:02 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30601/ --- (Updated Feb. 5, 2015, 1:02 p.m.) Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone. Bugs: MESOS-2228 https://issues.apache.org/jira/browse/MESOS-2228 Repository: mesos Description --- Now the slave doesn't completely ignore the grace period, note that there is a bound of 1 minute for now. Diffs - include/mesos/mesos.proto 28612168c66d85679b35d743e96954770f37daec src/slave/constants.hpp 761cfafb3b1b342af4d1dbdb2dec39a45dd62794 src/slave/constants.cpp 83d9fc1cd385722deb31883c17c824fd0e1de8a6 src/slave/containerizer/containerizer.cpp 421bb868b353e644578fa27f04bdd636bfc89134 src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b src/tests/slave_tests.cpp e7e2af63da785644f3f7e6e23607c02be962a2c6 Diff: https://reviews.apache.org/r/30601/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 30962: Environment decorator override.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/#review72418 --- I forgot to update a MergeFrom in the slave decorator. Stay tuned. - Niklas Nielsen On Feb. 13, 2015, 11:01 a.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/ --- (Updated Feb. 13, 2015, 11:01 a.m.) Review request for mesos, Ben Mahler and Kapil Arya. Bugs: MESOS-2351 https://issues.apache.org/jira/browse/MESOS-2351 Repository: mesos Description --- See summary Diffs - src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b Diff: https://reviews.apache.org/r/30962/diff/ Testing --- make check Thanks, Niklas Nielsen
Re: Review Request 30961: Label decorator override
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30961/ --- (Updated Feb. 13, 2015, 11:01 a.m.) Review request for mesos, Ben Mahler and Kapil Arya. Summary (updated) - Label decorator override Bugs: MESOS-2351 https://issues.apache.org/jira/browse/MESOS-2351 Repository: mesos Description --- See summary. Diffs (updated) - include/mesos/hook.hpp d83ace576a2c78eb7b1e910d89d912f6df5c46ef src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937 src/tests/hook_tests.cpp dc6d289394e5718a37936e29ad6d988b52933f98 Diff: https://reviews.apache.org/r/30961/diff/ Testing --- make check (with modified VerifyMasterLaunchTaskHook test) Thanks, Niklas Nielsen
Re: Review Request 30962: Environment decorator override.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/ --- (Updated Feb. 13, 2015, 11:01 a.m.) Review request for mesos, Ben Mahler and Kapil Arya. Summary (updated) - Environment decorator override. Bugs: MESOS-2351 https://issues.apache.org/jira/browse/MESOS-2351 Repository: mesos Description --- See summary Diffs (updated) - src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b Diff: https://reviews.apache.org/r/30962/diff/ Testing --- make check Thanks, Niklas Nielsen
Review Request 31028: Added slave run task hook tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31028/ --- Review request for mesos, Ben Mahler and Kapil Arya. Repository: mesos Description --- See summary Diffs - src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d src/tests/hook_tests.cpp dc6d289394e5718a37936e29ad6d988b52933f98 Diff: https://reviews.apache.org/r/31028/diff/ Testing --- make check (with newly added VerifySlaveRunTaskHook test) Thanks, Niklas Nielsen
Review Request 31027: Moved decorateExecutorEnvironment to framework struct.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31027/ --- Review request for mesos. Repository: mesos Description --- See summary. Diffs - src/slave/slave.hpp 7a399f6df50c69b7e1e12d74f076fa57b6edb1b3 src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3 Diff: https://reviews.apache.org/r/31027/diff/ Testing --- make check Thanks, Niklas Nielsen
Re: Review Request 30961: Enabled label decorator to override.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30961/ --- (Updated Feb. 13, 2015, 3:28 p.m.) Review request for mesos, Ben Mahler and Kapil Arya. Summary (updated) - Enabled label decorator to override. Bugs: MESOS-2351 https://issues.apache.org/jira/browse/MESOS-2351 Repository: mesos Description --- See summary. Diffs (updated) - include/mesos/hook.hpp d83ace576a2c78eb7b1e910d89d912f6df5c46ef src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937 src/tests/hook_tests.cpp dc6d289394e5718a37936e29ad6d988b52933f98 Diff: https://reviews.apache.org/r/30961/diff/ Testing --- make check (with modified VerifyMasterLaunchTaskHook test) Thanks, Niklas Nielsen
Review Request 31017: Fixed comment for remote executor hook.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31017/ --- Review request for mesos and Kapil Arya. Repository: mesos Description --- See summary. Diffs - include/mesos/hook.hpp d83ace576a2c78eb7b1e910d89d912f6df5c46ef Diff: https://reviews.apache.org/r/31017/diff/ Testing --- make check Thanks, Niklas Nielsen
Re: Review Request 31017: Fixed comment for remove executor hook.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31017/ --- (Updated Feb. 13, 2015, 3:28 p.m.) Review request for mesos and Kapil Arya. Summary (updated) - Fixed comment for remove executor hook. Repository: mesos Description --- See summary. Diffs - include/mesos/hook.hpp d83ace576a2c78eb7b1e910d89d912f6df5c46ef Diff: https://reviews.apache.org/r/31017/diff/ Testing --- make check Thanks, Niklas Nielsen
