/#comment112711
The destructor of the MesosAllocator will stop the process, right? How is
this different from status quo, or are you trying to solve other problems
mid-way?
- Niklas Nielsen
On Jan. 15, 2015, 9:17 a.m., Alexander Rukletsov wrote
://reviews.apache.org/r/29926/
---
(Updated Jan. 15, 2015, 8:58 a.m.)
Review request for mesos, Bernd Mathiske and Niklas Nielsen.
Bugs: MESOS-2213
https://issues.apache.org/jira/browse/MESOS-2213
Repository: mesos-git
with this
patch in?
- Niklas Nielsen
On Jan. 15, 2015, 8:58 a.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29927
Hi guys,
Do you know if your recent change broke the test?
Niklas
On 14 January 2015 at 01:09, Apache Jenkins Server
jenk...@builds.apache.org wrote:
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2667/changes
Changes:
Hi Abhishek,
Added you as a contributor.
Let me know if you have any trouble assigning tickets.
Cheers,
Niklas
On 22 January 2015 at 13:21, Abhishek Chanda abhishek.li...@gmail.com
wrote:
Hi all,
I am brand new to Mesos. Would like to assign
https://issues.apache.org/jira/browse/MESOS-2210
Sort alphabetically :)
src/local/local.cpp
https://reviews.apache.org/r/29925/#comment113988
Sort
src/tests/hierarchical_allocator_tests.cpp
https://reviews.apache.org/r/29925/#comment113992
s/\/\//\//g
- Niklas Nielsen
On Jan. 20, 2015, 10:06 a.m., Alexander Rukletsov wrote
://reviews.apache.org/r/29569/#comment113930
if (started !finished) ?
Probably a noop, but for clarity.
- Niklas Nielsen
On Jan. 21, 2015, 9:57 a.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29540/#review69289
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 1, 2015, 8:46 p.m
of castings.
3rdparty/libprocess/include/process/network.hpp
https://reviews.apache.org/r/29541/#comment113977
Aren't you missing a break here?
- Niklas Nielsen
On Jan. 21, 2015, 9:56 a.m., Benjamin Hindman wrote
/master/allocator.hpp
https://reviews.apache.org/r/29890/#comment113979
Don't we also want to change this to MesosAllocatorProcess and make the
template handle 'template typename MesosAllocatorProcess' be the generalized
'AllocatorProcess' one?
- Niklas Nielsen
On Jan. 22, 2015, 8:55 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29932/#review69320
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 20, 2015, 10:21 a.m
. 20, 2015, 10:21 a.m.)
Review request for mesos, Bernd Mathiske and Niklas Nielsen.
Bugs: MESOS-2213
https://issues.apache.org/jira/browse/MESOS-2213
Repository: mesos-git
Description
---
See summary.
Diffs
-
src/local/local.hpp 0aa50ef
src/local
/master_allocator_tests.cpp
https://reviews.apache.org/r/29927/#comment113980
Can we to guard this so you capture dispatches to a 'stopped' allocator
upfront?
- Niklas Nielsen
On Jan. 20, 2015, 10:10 a.m., Alexander Rukletsov wrote
://reviews.apache.org/r/29931/#comment113984
Is this still relevant? The allocator only lives in the master and the
containerizer and isolators similarily knows about the slave flags.
If not, let's kill the comments referencing the master flags removal
- Niklas Nielsen
On Jan. 20, 2015, 10:16
/hierarchical.hpp' sneaked it's
way in. Can you do a scan of your patch chain and check for empty files?
- Niklas Nielsen
On Jan. 20, 2015, 10:12 a.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29606/#review68830
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 19, 2015, 2:52 p.m
the test to 'index = data-size())' or throw an error
if index is strictly larger.
Feel free to drop is you have strong guarantees that this will never happen.
- Niklas Nielsen
On Jan. 21, 2015, 9:42 a.m., Benjamin Hindman wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29531/#review69244
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 21, 2015, 9:43 a.m
```
Niklas Nielsen wrote:
Should we follow: http://tools.ietf.org/html/rfc3986 ? True URL parsing
is tricky.
Niklas Nielsen wrote:
Or write a shim on an existing library instead of rewriting:
http://uriparser.sourceforge.net/
Benjamin Hindman wrote:
I was punting
on this change.
Awaiting feedback on the dev@ thread before giving ship-it
- Niklas Nielsen
On Jan. 21, 2015, 9:49 a.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
+1
Thanks for the write up Ben!
On Tuesday, February 10, 2015, Dominic Hamon dha...@twitter.com.invalid
wrote:
Well, we should probably do that anyway :)
On Feb 10, 2015 2:25 AM, Adam Bordelon a...@mesosphere.io
javascript:; wrote:
+1 on MAINTAINERS over OWNERS, and the rest of the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30338/#review71813
---
Ship it!
Ship It!
- Niklas Nielsen
On Feb. 9, 2015, 6:53 p.m
https://issues.apache.org/jira/browse/MESOS-2366
On 17 February 2015 at 17:56, Apache Jenkins Server
jenk...@builds.apache.org wrote:
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2746/changes
Changes:
[benjamin.mahler]
.)
Review request for mesos and Niklas Nielsen.
Bugs: MESOS-2110
https://issues.apache.org/jira/browse/MESOS-2110
Repository: mesos
Description
---
Added new --slave_ping_timeout and --max_slave_ping_timeouts flags
to mesos-master to replace the existing (still
/#comment118973
Which directory age? :) How about 'sandbox' or 'executor directory'. It's
hard to interpret it's meaning only from the field name.
- Niklas Nielsen
On Feb. 14, 2015, 3:20 a.m., Alexander Rojas wrote
a.m.)
Review request for mesos and Niklas Nielsen.
Bugs: MESOS-2110
https://issues.apache.org/jira/browse/MESOS-2110
Repository: mesos
Description
---
Added new --slave_ping_timeout and --max_slave_ping_timeouts flags
to mesos-master to replace the existing (still
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29855/#review72996
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 13, 2015, 10:55 a.m
present. Wonder if we should leave a todo if the metrics system
doesn't support it.
- Niklas Nielsen
On Feb. 18, 2015, 7:09 a.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
45efce347af7ad6bedd193715611dc0a67f5d767
src/tests/slave_tests.cpp a02e335576bf68b449a6286fa5cf5093b1b7182a
Diff: https://reviews.apache.org/r/30948/diff/
Testing
---
make check
Thanks,
Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30961/#review72301
---
On Feb. 12, 2015, 5:13 p.m., Niklas Nielsen wrote
f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937
src/tests/hook_tests.cpp dc6d289394e5718a37936e29ad6d988b52933f98
Diff: https://reviews.apache.org/r/30961/diff/
Testing
---
make check (with modified VerifyMasterLaunchTaskHook test)
Thanks,
Niklas Nielsen
/diff/
Testing
---
make check
Thanks,
Niklas Nielsen
There is an issue with our build setup:
rm -f java/jni/org_apache_mesos*.h
rm -f authentication/cram_md5/.dirstamp
rm -f authorizer/*.lo
rm: cannot remove 'python/interface/build': Is a directory
rm: cannot remove 'python/native/build': Is a directory
make[2]: [clean-generic] Error 1 (ignored)
rm
?
- Niklas Nielsen
On Jan. 20, 2015, 3:58 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30100/
---
(Updated
of agreement should be
taking place on the mailing list; If it didn't happen on a mailing
list, it didn't happen. [1]
Dave
[1] https://community.apache.org/newbiefaq.html
On Mon, Feb 16, 2015, at 05:37 PM, Niklas Nielsen wrote:
Hi everyone,
Per our last community meeting (Feb 12), we agreed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30263/#review72666
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 26, 2015, 3:11 a.m
Hi everyone,
Per our last community meeting (Feb 12), we agreed to cut Mesos 0.22.0 in
two weeks (Feb 26).
There are still quite a few things in flight, so if any of you don't have
any objections, let's aim to cut a release candidate by EOW (Sunday March
1st EOD).
I will be reaching out to the
/#comment118882
These are specific to the files process, shouldn't it be per process then?
- Niklas Nielsen
On Feb. 16, 2015, 8:21 a.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29925/#review69849
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 27, 2015, 5:22 a.m
://reviews.apache.org/r/29927/#comment114663
You can do 'return CHECK_NOTNULL(allocator_.get());' :)
- Niklas Nielsen
On Jan. 27, 2015, 7:23 a.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/#comment114652
Can we change this to MesosAllocatorProcess?
- Niklas Nielsen
On Jan. 27, 2015, 5:15 a.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29890
/examples/test_monitor_module.cpp PRE-CREATION
src/tests/module.hpp 21e8fc4
src/tests/module.cpp e6dbf94
src/tests/monitor_tests.cpp 3b02619
Diff: https://reviews.apache.org/r/30097/diff/
Testing
---
make check
Thanks,
Niklas Nielsen
Thanks,
Niklas Nielsen
/r/30091/diff/
Testing
---
make check
Thanks,
Niklas Nielsen
/mesos.hpp 3f4704bf20d654a9b26a483a59eaf96e126ef02c
src/tests/mesos.cpp 5ed4df530cf1bf11eec3b29542641822e0f702b2
src/tests/slave_tests.cpp a85a0282947278ce6e02e38093f8b88af4cb612a
Diff: https://reviews.apache.org/r/30094/diff/
Testing
---
make check
Thanks,
Niklas Nielsen
/
Testing
---
make check
Thanks,
Niklas Nielsen
Thanks,
Niklas Nielsen
://reviews.apache.org/r/30095/diff/
Testing
---
make check
Thanks,
Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29539/#review70140
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 28, 2015, 6:09 p.m
On Jan. 22, 2015, 1:23 p.m., Niklas Nielsen wrote:
LGTM but fundamentally, it seems like we do not have consensus on this
change. Awaiting feedback on the dev@ thread before giving ship-it
Think we have gotten to censensus on calling this Address and the IP::Address
for InternetAddress
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29538/#review70143
---
Ship it!
Modulus out-standing issues
- Niklas Nielsen
On Jan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30082/#review70262
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 28, 2015, 9:32 a.m
On Jan. 28, 2015, 10:17 a.m., Niklas Nielsen wrote:
src/slave/slave.cpp, line 132
https://reviews.apache.org/r/30074/diff/3/?file=828310#file828310line132
You don't have to initialize Option types with None. They will
automatically be that :)
Alexander Rukletsov wrote
Instead of setting this low (which would still cause a 1s+ test). How about
forwarding the clock with flags.disk_watch_interval? That should trigger the
timeout immediately
- Niklas Nielsen
On Jan. 21, 2015, 5:55 a.m., Alexander Rojas wrote
://reviews.apache.org/r/29883/#comment114969
One more newline
- Niklas Nielsen
On Jan. 16, 2015, 5:37 a.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29883
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29526/#review66615
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 1, 2015, 8:45 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29527/#review66616
---
Ship it!
Taken it's just a code move
- Niklas Nielsen
On Jan. 1
for mesos, Dominic Hamon, Evelina Dumitrescu, Joris Van
Remoortere, and Niklas Nielsen.
Repository: mesos-git
Description
---
See summary.
Diffs
-
3rdparty/libprocess/include/process/network.hpp PRE-CREATION
3rdparty/libprocess/src/http.cpp
/labels/g
Why an option type? masterLaunchTaskLabelDecorator always returns a Labels
in your case. Shouldn't it be a Try instead?
- Niklas Nielsen
On Jan. 5, 2015, 2:42 p.m., Kapil Arya wrote:
---
This is an automatically
On Jan. 5, 2015, 2:50 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp, lines 28-29
https://reviews.apache.org/r/29533/diff/1/?file=805385#file805385line28
Is this complete? It doesn't look like it supports what we currently
have in
```
Niklas Nielsen wrote:
Should we follow: http://tools.ietf.org/html/rfc3986 ? True URL parsing
is tricky.
Or write a shim on an existing library instead of rewriting:
http://uriparser.sourceforge.net/
- Niklas
/contender.cpp
https://reviews.apache.org/r/29539/#comment110491
What guarantees that _url is a domain name? If that doesn't matter, then I
don't understand the second argument to url().
src/master/detector.cpp
https://reviews.apache.org/r/29539/#comment110492
Same here.
- Niklas Nielsen
nest with 2 additional spaces for environment and make it on
one line.
src/slave/slave.cpp
https://reviews.apache.org/r/28656/#comment110473
Why this refactor? Couldn't you just inline the hook like in the master?
- Niklas Nielsen
On Jan. 5, 2015, 2:42 p.m., Kapil Arya wrote
://reviews.apache.org/r/28875/#comment110475
How about using TryNothing instead?
- Niklas Nielsen
On Jan. 5, 2015, 2:42 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
- Niklas Nielsen
On Jan. 5, 2015, 2:42 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29496/
---
(Updated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29530/#review66828
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 1, 2015, 8:46 p.m
://reviews.apache.org/r/29528/#comment110485
Mind adding a comment for what you are guarding against?
3rdparty/libprocess/src/socket.cpp
https://reviews.apache.org/r/29528/#comment110487
Why not inline _send?
- Niklas Nielsen
On Jan. 1, 2015, 8:46 p.m., Benjamin Hindman wrote
is not quite
strong enough to imagine it :-)
- Niklas Nielsen
On Jan. 1, 2015, 8:46 p.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29531
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29532/#review66830
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 1, 2015, 8:46 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28672/#review66836
---
Ship it!
Ship It!
- Niklas Nielsen
On Dec. 18, 2014, 4:28 p.m
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28063/
---
(Updated Dec. 23, 2014, 7:25 a.m.)
Review request for mesos, Ben Mahler, Niklas
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28063/
---
(Updated Dec. 23, 2014, 7:25 a.m.)
Review request for mesos, Ben Mahler, Niklas Nielsen, and Till
Hi Alex,
Thanks for the write up! Looks good to me and will be looking forward to
hack away on new allocation policies.
Cheers,
Niklas
On 13 January 2015 at 06:47, Alex Rukletsov a...@mesosphere.io wrote:
Hi all,
we would like to start working on modularising the allocator, but before
On Nov. 18, 2014, 9:52 a.m., Niklas Nielsen wrote:
Awesome - there are more help texts with trailing newline. Can you do a
scan and catch them all? :)
ping - let's get this in too.
- Niklas
---
This is an automatically generated
/#comment112134
Let's do this as a file-static helper :)
src/slave/slave.cpp
https://reviews.apache.org/r/28656/#comment112135
How about calling it 'decorateExecutorEnvironment'?
- Niklas Nielsen
On Jan. 13, 2015, 5:31 p.m., Kapil Arya wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29496/#review68004
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 13, 2015, 5:05 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28655/#review67994
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 13, 2015, 5:04 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28656/#review68002
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 13, 2015, 5:31 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28514/#review67412
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 9, 2015, 2:21 a.m
?
src/common/type_utils.hpp
https://reviews.apache.org/r/29781/#comment117598
s/ / /g
- Niklas Nielsen
On Feb. 4, 2015, 7:15 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/#comment117600
How about moving these to their own directory? similiary to the isolator
include?
- Niklas Nielsen
On Feb. 4, 2015, 7:16 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30052/#review71734
---
Ship it!
Ship It!
- Niklas Nielsen
On Feb. 4, 2015, 7:16 p.m
/#comment117599
Let's move this to it's own directory too :)
- Niklas Nielsen
On Feb. 4, 2015, 7:16 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29605
:)
- Niklas Nielsen
On Feb. 9, 2015, 6:38 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30338/
---
(Updated Feb. 9
/#comment117572
Should we contain this in it's own directory? It looks a bit inconsistent
compared to containerizer, fetcher and scheduler
- Niklas Nielsen
On Feb. 4, 2015, 7:15 p.m., Kapil Arya wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29603/#review71743
---
Ship it!
- Niklas Nielsen
On Feb. 4, 2015, 7:15 p.m., Kapil Arya
. 12, 2015, 1:05 p.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30948/
---
(Updated Feb. 12, 2015, 1:05
.
- Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30948/#review72347
---
On Feb. 12, 2015, 1:05 p.m., Niklas Nielsen wrote
/#comment117692
Copy past :) Do we want this comment for every module? I think just having
it on the first one would suffice
- Niklas Nielsen
On Feb. 10, 2015, 10:52 a.m., Kapil Arya wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30580/#review71855
---
Ship it!
Ship It!
- Niklas Nielsen
On Feb. 3, 2015, 6:14 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30583/#review71856
---
Ship it!
Modulo Vinod's comments
- Niklas Nielsen
On Feb. 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30601/#review71864
---
Ship it!
Ship It!
- Niklas Nielsen
On Feb. 5, 2015, 1:02 p.m
.
- Niklas Nielsen
On Feb. 13, 2015, 11:01 a.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30962
://reviews.apache.org/r/30961/diff/
Testing
---
make check (with modified VerifyMasterLaunchTaskHook test)
Thanks,
Niklas Nielsen
8faf6850aafcebda7e9f0d1b735d61f7effa842d
src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b
Diff: https://reviews.apache.org/r/30962/diff/
Testing
---
make check
Thanks,
Niklas Nielsen
VerifySlaveRunTaskHook test)
Thanks,
Niklas Nielsen
.
Diffs
-
src/slave/slave.hpp 7a399f6df50c69b7e1e12d74f076fa57b6edb1b3
src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3
Diff: https://reviews.apache.org/r/31027/diff/
Testing
---
make check
Thanks,
Niklas Nielsen
://reviews.apache.org/r/30961/diff/
Testing
---
make check (with modified VerifyMasterLaunchTaskHook test)
Thanks,
Niklas Nielsen
---
See summary.
Diffs
-
include/mesos/hook.hpp d83ace576a2c78eb7b1e910d89d912f6df5c46ef
Diff: https://reviews.apache.org/r/31017/diff/
Testing
---
make check
Thanks,
Niklas Nielsen
Thanks,
Niklas Nielsen
801 - 900 of 1166 matches
Mail list logo
