Re: [Geeqie-devel] Rawtherapee gets .jpg

[Colin Clark]

On 31/10/17 18:43, Ray via Geeqie-devel wrote:
  Is there a way to set Geeqie to send .DNG and .CR2 raw files to 
Rawtherapee (RT) instead of the .JPG thumbnail?


The association almost gets it right by not having RT visible in edit 
menus when no raw filetypes are found, but it is sending the .jpg file 
of a group instead of the raw file, which can lead to a fair amount of 
hair pulling, something already in short supply. I'm currently running 
ver3.1 on xubuntu 16.04lts using Zesty repos to solve dependencies. I 
can probably compile from source if needed but I'm hoping for an 
easier fix.


This seems to be a bit of a problem. I have made an entry on Geeqie's 
GitHub project page:


https://github.com/BestImageViewer/geeqie/issues/534

I guess it will be a while before a suitable solution is found.

You can, of course, simply disable file grouping - which is a pain.

There is a way to achieve this -  it is somewhat complicated, but if you 
need a short term answer this is the only one I can think of.


You must create a new desktop file - Edit/Preferences/Configure Editors 
- called e.g. my_rt.desktop


Call a shell script from the desktop file - e.g.Exec = 
/home/wherever/my_rt.sh %f


In the script file put something approximately like:

#!/bin/bash
OIFS="$IFS"
IFS=$'\n'

set -- $(geeqie -r --get-sidecars:"$1")

while (( "$#" )); do

if [[ "$1" == *".DNG" ]]; then
 rawtherapee "$1"
fi
if [[ "$1" == *".dng" ]]; then
 rawtherapee "$1"
fi

shift
done

IFS="$OIFS"
exit

Sorry, that's the best I can suggest at the moment. (n.b. The above only 
works if you select a single group)



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Webp pixbuf loader

[Colin Clark]

This pixbuf loader seems to work with Geeqie:


https://github.com/aruiz/webp-pixbuf-loader




--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Rename External Editors

[colin clark]

Is there any objection to changing all references from "External Editors" to
"Plugins", and creating an additional top-level menu entry to access  them?



--
Sent from: http://gnome-apps.13852.n7.nabble.com/Geeqie-f47609.html

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Sourceforge - Internet searches

[Colin Clark]

Hello Klaus

The SourceForge website is still coming out top of the list for Internet 
searches on Geeqie, but that site is now truly dead.


Would it be possible to replace the front page with just a simple 
re-direct to Geeqie's new home?




--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Thumbnail cache folder location

[colin clark]

Someone recently posted a message on github pointing out a problem with
thumbnail cache folders.
In addition to this problem, the code seems to be inconsistent in where it
thinks the cache should be.

Geeqie can save thumbnails is two formats:
Standard format as specified in the freedesktop docs; all thumbnails in a
single folder, with a filename created by a MD5 hash.
or,
Geeqie format, in a hierarchical tree replicating the location of the source
images, and with a filename of the original source appended by .png.

The standard (freedesktop) cache location is clearly defined:
$XDG_CACHE_HOME/thumbnails
or, if the environment variable is not set:
$HOME/.cache/thumbnails

But where should the Geeqie format thumbnails be cached?
1. $HOME/.cache/geeqie/thumbnails (even if the XDG environment variable is
set)
2. $XDG_CACHE_HOME/geeqie/thumbnails
3. $XDG_CACHE_HOME/thumbnails/geeqie/
4. None of the above?




--
View this message in context: 
http://gnome-apps.13852.n7.nabble.com/Thumbnail-cache-folder-location-tp69997.html
Sent from the Geeqie mailing list archive at Nabble.com.

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Pay for feature

[colin clark]

In case you are not tracking the repository, there is another commit that
permits you to also copy from the Exif pane in the sidebar.
Left click stores in one clipboard; right click to the other. I've already
forgotten which way round. A bit of empirical research should give you the
answer.




--
View this message in context: 
http://gnome-apps.13852.n7.nabble.com/Pay-for-feature-tp69948p69969.html
Sent from the Geeqie mailing list archive at Nabble.com.

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Pay for feature

[colin clark]

Implemented in commit bfa5abb9b5c at geeqie.org.
Just click on any cell, and the value is copied into the clipboard.



--
View this message in context: 
http://gnome-apps.13852.n7.nabble.com/Pay-for-feature-tp69948p69956.html
Sent from the Geeqie mailing list archive at Nabble.com.

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Pay for feature

[colin clark]

At the moment you can just highlight a single line of data.
Do you just want to copy a single line to the clipboard, or a set of
consecutive or non-consecutive lines?



--
View this message in context: 
http://gnome-apps.13852.n7.nabble.com/Pay-for-feature-tp69948p69950.html
Sent from the Geeqie mailing list archive at Nabble.com.

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Caching data

[Colin Clark]

Thumbnails:

I have all my photo data arranged in a tree under a single folder - that 
means I can regularly use the menu item "Render thumbnails for a 
specific folder - include subfolders" to re-render everything, overnight 
if necessary. That saves a lot of time when I open any folder in icon view.



.sim files:

These files, used for "find duplicates", are also stored in the same 
cache folder as the thumbnails. Would it be sensible to have another 
menu item to recursively create these files as for the thumbnails? (I 
recognise that the comparison phase of "find duplicates" is actually far 
longer than the create .sim file phase).



Exif data:

Reading exif data takes time - as far as I can see this is due to exiv2, 
and therefore is irreducible. Would it be possible/sensible to try to 
cache exif data also?




--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Cache and .sim files

[Colin Clark]

Hello Klaus

The thumbnail maintenance command  "Clear cache" (Geeqie thumbnail 
cache, not shared cache) does not always delete the .sim files that are 
stored in the cache along with the thumbnail .pngs.


It depends on the setting "Disable File Filtering" in Preferences. If 
File Filtering is enabled (as normal), I think only files of the types 
listed are deleted - and therefore not the .sim files.


If File Filtering is disabled, everything in the cache is deleted.

Do you know the history of this?

It seems to me that clear cache should always delete everything in the 
Geeqie cache (as stated in the original help file).



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] clang and GTK3

[Colin Clark]

Hello Klaus

When I configure to use clang, GTK2 is ok, but GTK3 fails on two lines
in cellrendericon.

Have I missed a configuration item, or is this merely "yet another bug to
be fixed"?


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Sourceforge blows

[colin clark]

Would it also be possible for an email to be sent to the list whenever the
Geeqie repository is updated?



--
View this message in context: 
http://gnome-apps.13852.n7.nabble.com/Sourceforge-blows-tp69852p69910.html
Sent from the Geeqie mailing list archive at Nabble.com.

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Sourceforge blows

[colin clark]

I would also a prefer a mailing list setup that gives the option of replying
either to the list or to the original sender. With sourceforge I have a
tendency to send to personal emails instead of to the list, as I had
intended...
Also I see that the Gmane link on geeqie.org is defunct.
Nabble is still here, so thankfully the archives are still accessible.



--
View this message in context: 
http://gnome-apps.13852.n7.nabble.com/Sourceforge-blows-tp69852p69877.html
Sent from the Geeqie mailing list archive at Nabble.com.

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Deprecated functions - standard practice

[Colin Clark]

I would like to make an attempt to reduce the number of deprecated 
warnings, but I have no knowledge of current standard methods.

I see some projects use a single header file to redefine functions - 
indeed, Geeqie uses compat.h for this in a small way.

Although this removes the need to put multiple #if GTK_CHECK_VERSION 
throughout the code, I see there can be a problem when reading the 
source code or using a debugger - the code you are reading isn't 
necessarily what was compiled. And I haven't found an easy way to see 
what the macro-processed output is.

So, is compat.h the way to go, or should in-line #defines be used?



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Geeqie++ fever dreams

[Colin Clark]

On 30/12/16 00:02, Alexander Antimonov wrote:
>
> I take "jpeg comment" issues: #381, #286.
>
In the Help files - in sections Overlay Screen Display and Lua 
Extensions - one of the examples explains how to get the jpeg comments 
into the Overlay Screen Display using a Lua script.

Of course you will have to install Lua and do a bit of copy-paste 
programming, but I don't think you will have difficulty getting it to work.

If it becomes clear there is a large number of users who need this, it 
might be better to give jpeg comments their own tag in the Overlay 
Screen Display.

However, if you want jpeg comments as an element in the sidebar, that's 
a another problem...

--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Geeqie++ fever dreams (+Win32)

[Colin Clark]

On 24/12/16 15:39, Alexander Antimonov wrote:
> While porting to C++1x it is good chance to make Geeqie more
> cross-platform. But it seems Gtk is becoming (has become) an auxiliary
> tool for the "GnomeOS". And some of the well-known projects was/is
> migrating from Gtk. Maybe we should consider Qt instead? Anyhow, I
> guess it's more correct to talk about re-implementation than just
> port.
>
I apologise for asking some questions that are no doubt totally obvious 
to those of you who have current knowledge, however...

Back in 2006 someone made a port of Gqview to windows. It died pretty 
quickly. Was this because:

a) GTK's cross platform capability is a bit of a fiction

b) Gqview/Geeqie was too complex to port successfully

c) Windows users are happy with what they have, and would not bother 
with Geeqie


I guess that the reason is b) but I'd be grateful if someone would 
confirm that.


--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Github bugs and versions

[Colin Clark]

Hello Klaus

I want to log an new bug on Github, but I would also like to indicate 
which versions it affects (as there seems to be still a few people 
around using old versions).

But I don't see any way in Github other than to create a set of labels - 
one for each existing version of Geeqie - and then to tag the bug with 
the relevant labels.

Do you have any other ideas?

Colin...



--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Natural sort order for files and folders

[Colin Clark]

On 12/12/16 06:54, Klaus Ethgen wrote:
> Well, for directories, we have no choosable sort method. But ...
> ... For images you can choose the sort order via context menu. There is
> one, "sort nummerical", that is exactly what you ask for.
>
Hello Klaus

Unfortunately even for just files, the numerical sort is still not quite 
right for me - when there are alphas, lower case is not sorted next to 
upper case.

I now find that my proposed solution was implemented in Geeqie, but was 
deleted in commit bd34c324c92456f5182579d6922d7aba664f93c3 2009-12-19.

I can't find what bug 2917164 is, but it would seem it was not a real 
bug, but simply that the sort order is not the same as that produced by 
the ls command.


If I google "Natural sort order" - and from Roger's comments - I now see 
this is a well-known problem, and that there are an infinite number of 
differing opinions about this.

However it is clear from the documentation of 
g_utf8_collate_key_for_filename() that the GTK programmers are making a 
serious attempt to produce a function that resolves this.

I suggest I implement a new option in the Files tab of Preferences to 
select the collate method. The menus are then not cluttered up, and 
those who think an ASCII sort is sensible can continue to live happily.

If you don't want yet another option in the program - no problem - I can 
just patch my working copy.


Colin...





--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Merge requests

[Colin Clark]

Hello Klaus

I'd messed up some directories including .ssh. Then made a "quick fix" 
by restoring files  to the wrong place.

Everything seems ok now. Thanks


Colin...


--
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Merge requests

[Colin Clark]

Hello Klaus

Yes, a while ago something got changed and I no longer have write 
access. I've been intending to look in my backups to see what I did, but 
I keep getting distracted - the sun has been shining, and that's 
something that doesn't happen around here too often

Sorry, I'll make another effort to check what I did. Also, is there a 
possibility that something didn't get restored completely when you had 
to rebuild the website?
Would it be possible for you to check that? Thanks.

Colin..


On 22/08/16 15:07, Klaus Ethgen wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> Hi, hi Colin,
>
> do you plan to merge your merge requests yourself? Or is there another
> reason why you did not merge them already?
>
> Regards
> Klaus
> - -- 
> Klaus Ethgen   http://www.ethgen.ch/
> pub  4096R/4E20AF1C 2011-05-16Klaus Ethgen 
> Fingerprint: 85D4 CA42 952C 949B 1753  62B3 79D0 B06F 4E20 AF1C
> -BEGIN PGP SIGNATURE-
> Comment: Charset: ISO-8859-1
>
> iQGcBAEBCgAGBQJXuwcBAAoJEKZ8CrGAGfas4cIL/jyqgSohGzcpmVno37VO8EPy
> +r6cC1wUch0/eOLZQPXn1FEezKbzuCa9L4KH6KrzuPxIrzIUZuwUL/+9Mj9egcT+
> O2NOqyukO7W1ChLHcbqau6I4aIQXN9oW5HWjNfG8Yn312CIlOZTplVTXmGdp2adc
> YKSwZNPWXHPYZqn5vDHd66G3gBgAnc9s253T23jK9bCDhQZlTBQj/hMVvBwh2xzs
> 1OEY7Ns7FMVRmha6bgWbLA7B+Di0hQsocenk6kZC9Uvys6Lbrdhq4ko2wiBl0Xon
> GfkfyHbNqPKiBwlp14KemxYGKzowDNtGvMEtCXthUFvZH8GzK72Z9Q3XeC9zfmiy
> bXQm6jxxK+SG0KN4G3ZnxMrFuOVY6BqaGqwgl6coNvky2xk15GQiu5NGkhxgZvzA
> uKlG8rhTrfSTgbH1DgA47TzHCrM63BOkiIdkEsMdSwi5iCjQXA8+wtpaQ6PmJfYZ
> eqgwoh4Zh0QcUIfbo0FVzmFZ1r51M2nmpafcZfUrfw==
> =BiH7
> -END PGP SIGNATURE-
>
> --
> ___
> Geeqie-devel mailing list
> Geeqie-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geeqie-devel
>
>


--
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Wrong rendering intent when using monitor profile

[Colin Clark]

On 09/07/16 07:45, Klaus Ethgen wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Hi Morgan,

Am Fr den  8. Jul 2016 um 21:20 schrieb Morgan Hardwood:

There is quite a serious bug or lack of feature in Geeqie. One can use a
monitor profile, but the monitor profile uses the perceptual rendering intent
instead of relative colorimetric, if it supports both. The default option
should always be relative colorimetric, even if more rendering intents are
present in the profile. That is of utmost importance and more of a bug.
Secondary to that is adding an easily-accessible option to switch rendering
intents, more of a feature request.

Can you please open a bug report at [0]. That way it will not get lost.

Regards
Klaus



At around line 187 of color-man.c is:

cc->transform = cmsCreateTransform(cc->profile_in,
   (has_alpha) ? TYPE_RGBA_8 : TYPE_RGB_8,
   cc->profile_out,
   (has_alpha) ? TYPE_RGBA_8 : TYPE_RGB_8,
   INTENT_PERCEPTUAL, 0);

INTENT_PERCEPTUAL is what lcms2 uses as default in its documentation.

If it were simply a matter of swapping that to 
INTENT_RELATIVE_COLORIMETRIC, it would be easy to put an option in the 
preferences tab.


In fact, if lcms2 has a "cmsIsIntentSupported" function, it would be 
possible to put a drop-down box of the available intents.


However I have absolutely no knowledge colours, gamuts or anything else 
- I don't know if the above information is relevant or not.


I leave it to others to decide what to do.

Colin Clark..


--
Attend Shape: An AT Tech Expo July 15-16. Meet us at AT Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Release 1.3

[Colin Clark]

On 29/05/16 14:36, Klaus Ethgen wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> Am So den 29. Mai 2016 um  4:01 schrieb John Stoffel:
>> Just gettings the warnings fixed would be a good goal in my mind.
> True.
>
> As you might have noticed, I already did some cleanup in merges 2943df6
> and 6164a63.
>
> Regards
> Klaus
> - -- 
My view, which is but one of many, is that all compiler messages other 
than errors should be inhibited for a standard build.

There may be people trying to use Geeqie who struggle just to download a 
tar and do a make. For them, compiler warnings are an unnecessary worry, 
because they do not understand that the warnings are in fact irrelevant 
to them.

They are only relevant to the developers - and unfortunately there seems 
to be very few of those around at the moment.

Deprecated warnings will never go away, because as fast as they are 
fixed, the GTK developers are at work creating a few more.

My view is that all warnings should only be enabled with the 
--enable-developer option.


--
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] few questions regarding marks

[Colin Clark]

1. I can't find how to enable marks in file manager, they are no 
longer displayed, nor do I see mark filter. I previously used it for 
sorting photos(by associating with keywords) and then filtering out 
what's necessary. Is this feature have gone for good or I just can't 
find how to enable it?


The marks functions, including Show Marks, should be on the "Select" 
main menu item. Which version is displayed on the Help/About window on 
your installation?


If you display the Info Sidebar and open up the Keywords section, you 
can then right-click on a keyword to associate it with a mark.
2. Finally found how to display current marks as overlay but it shows 
a lot of redundant information which found on the status bar, take a 
look to attached screenshot, is there a way to disable it?


The content of the Image Overlay is defined in the Preferences/Windows 
tab. Just delete everything in the Overlay Screen Display box. The 
overlay will still show any defined marks when you select an image that 
has been marked.


Have fun...

--
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] GPS maps

[Colin Clark]

On 20/05/16 23:08, Greg Troxel wrote:

What does clutter do without champlain?
If you compile with the --enable-clutter option, on the 
Preferences/Image tab there is an additional check-box: "GPU Acceleration".
This feature doesn't work on my system - possibly libclutter has evolved 
and Geeqie has not kept up.


I would love to see a way to show all images in a directory on a map at
once, and to get a subview of just the ones in a region after selecting
or clicking on a cluster marker.  Try some of those proprietary photo
apps to see what I mean :-)
I have written an additional search function that allows the user to 
search within a radius of a geo-point. But at the moment it's on a 
branch in the repository, so it will be a while before it makes it into 
a release.
However although it's a recent addition, I wrote the code years ago. At 
the time I also had the intention of using a mouse-drag to delineate a 
circle or rectangle on the map, and select any geocoded images within 
the boundary. It didn't seem so terribly complex to do. Displaying 
Exif.GPSInfo.GPSImgDirection also seemed fairly easy.


Unfortunately from that point on I had no time to use Geeqie, let alone 
code anything, so everything went onto the todo list


Recent comments from you and others have renewed my enthusiasm for the 
map software, and I now have more time for this kind of thing. I hope a 
few things get completed this time around.


--
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Image overlay configurable font and colours

[Colin Clark]

On 19/05/16 13:42, Klaus Ethgen wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> Hi Colin,
>
> What did you do to make this two patches compilable? I am not able to
> compile them. I always get compiler errors (and some warnings):
> preferences.c: In function 'config_window_apply':
> preferences.c:288:3: warning: implicit declaration of function 
> 'set_image_overlay_font_string' [-Wimplicit-function-declaration]
>set_image_overlay_font_string(>image_overlay.font,
>^
>
Hi Klaus
Sorry, I've just seen your message.
I've uploaded a new commit. I had forgotten to do a check compile 
against GTK2.
I just made a quick hack to avoid people having the problems you have 
just encountered.
I will recode it using the option of the GTK2+ Color Selector sometime soon.

Colin..




--
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] GPS maps

[Colin Clark]

On 06/05/16 17:53, Klaus Ethgen wrote:
> I installed libchamplain-0.12-dev, libclutter-gtk-1.0-dev and
> libchamplain-gtk-0.12-dev now and enabled via "--enable-gps
> --enable-clutter". (Is clutter always needed? Why not just have the gps
> switch if it is bound to clutter?)
>
> Compile and went well but...
>
> (geeqie:10413): Gtk-ERROR **: GTK+ 2.x symbols detected. Using GTK+ 2.x 
> and GTK+ 3 in the same process is not supported
>
> :-(
>
> So at least under debian, it is not strait forward.
> Now I recompiled it completely with gtk-3 and gps support.
>
> Works that far. But it shows me why I never liked GTK-3.
> - - Mouse wheel is not working in lists anymore
> - - Buttons and layout are ugly
> - - Image display flickers when using map display
>
>
Hi Klaus

The config change was made by Vladimir on 18/8/2012 (I think). If 
clutter and libchamplain libraries are installed, and the enable-clutter 
option given, then the map is compiled in also.
The user has the option of preventing the map being included by use of 
the disable-gps option.

I can get an image flickering problem if I resize the image window - but 
this depends on some combination of several things:
If the image is scaled 1:1/fit-to-window/Gnome/XFCE etc.

I don't resize the window much, so it is no real problem for me. As for 
GTK-3, I have no choice but to use it. One of the main reasons I use 
Geeqie is because of the map - to me image location is as important as 
date-and-time.

[I have scanned in some of my old slides - but whenever I look at them 
all I think is "Which building? Which mountain? Which country?" - I wish 
GPS had been around at the time of Kodachrome 64!]

But as you have written, Geeqie is stuck with GTK.

If people report a problem with the map, I will try to help solve it. 
But from the mailing list I get the feeling that the map is not a 
significant function for Geeqie users.


Colin..


--
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] GPS maps

[Colin Clark]

Hi Klaus

Whilst you are in the middle of many, many, changes...

Time has flown by, and now GPS and electronic maps are part of everyday 
devices - including cameras.

Do you think that the GPS  map option should now be set as the default?

Minimalists and maintainers of minimal-packages would still be able to 
use --disable to reduce the dependencies.

Colin.


--
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Git repository workflow

[Colin Clark]

> I'll post in the issues if appropriate: the question I have at the
> moment is that the about box seems woefully out of date, as is "geeqie
> --version". I am fairly sure I am compiling master HEAD.
>
Hi Klaus

There have been quite a few updates to the repository recently, and 
maybe a few more to come from me - e.g. copy/move with thumbnail preview 
and simultaneous rename, additional search functions.

I think people may try to keep up to date by downloading the master 
rather than wait for a release, but that gives a problem when they 
report problems - what have they compiled?.

Is it a simple thing to use git hooks to run a command to update a file 
in the repo at each commit, so that the About window can show not just 
major/minor version, but also e.g. the output of "git describe" at the 
time the last commit was made?

If not, no problem.


Colin...


--
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Gone missing sourceforge file

[Colin Clark]

On 30/04/16 11:18, Klaus Ethgen wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> Hi Colin,
>
> Am Fr den 29. Apr 2016 um 21:45 schrieb Colin Clark:
>> Has anyone kept a copy of this file?:
>>
>> http://sourceforge.net/apps/trac/geeqie/wiki/GuideEditorsConfig
>>
>>
>> Wishful thinking probably, but I thought I would try
> I only backed up bugs, feature-requests, patches and support-requests.
> Sorry.
>
> But I didn't delete wiki there. Trac on the other hand, is gone long
> ago.
>
>
Hi Klaus

I got a helpful response from someone who pointed out that it is still 
on WaybackMachine.


He had to use my personal email because he got blocked from responding 
on sourceforge.

His email address is in the domain  @science.su.

Do you have any ideas about this - does sourceforge operate a blacklist?



Colin...


--
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Gone missing sourceforge file

[Colin Clark]

Has anyone kept a copy of this file?:

http://sourceforge.net/apps/trac/geeqie/wiki/GuideEditorsConfig


Wishful thinking probably, but I thought I would try


Colin Clark



--
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] [patch] Fullscreen fix

[Colin Clark]

On 21/04/16 20:13, Josef Kufner wrote:
> Good news everyone,
>
> I managed to fix the fullscreen mode. At least it looks fixed for me :)
> -- Tested on multi-screen setup on KDE5.
>
> Here is the pull request:
> https://github.com/BestImageViewer/geeqie/pull/379
>
> What do you say? Does it work for you?
>
The full-screen problem I have encountered is:

switch geeqie to full screen mode
attempt to alt-tab to switch to another application - nothing happens, 
geeqie remains on top
pressing "escape" no longer terminates geeqie's full-screen
the only way out is to log in to another session and kill geeqie


Your patch eliminates this problem for me. So, yes, it works for me too.


Colin Clark



--
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] [BestImageViewer/geeqie] Use Formatted Renaming wrong and you'll lose your pictures, PERMANENTLY! (#380)

[Colin Clark]

On 26/04/16 19:54, Klaus Ethgen wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> Hi Colin,
>
> Am Di den 26. Apr 2016 um 19:23 schrieb Colin Clark:
>>> I think, you refer to Bug #377, not #380...?
>> #377 is "Reorganising bookmarks by mouse drag causes seg fault", which is
>> still open. (Actually, I think it is probably a general DnD fault, not a
>> bookmarks problem.)
> Hmm... But the commit comment you gave is:
>  Fix crash on drag and drop from Xfe
>
>  The issue is that when dragging and dropping from Xfe, paths aren't
>  escaped like they are when dnd'ing from a GTK app.
>
> Which makes me believe that it is #377.
>
>
Hi Klaus

This patch came from a post by Jonathan Boeing on the sourceforge 
mailing-list.

I put it into the repository without a github Issue number being raised.

In the commit comment I should have put a link to the entry in the 
sourceforge mailing-list, so that there was traceability to the origin 
of the patch.


Colin...




--
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] [BestImageViewer/geeqie] Use Formatted Renaming wrong and you'll lose your pictures, PERMANENTLY! (#380)

[Colin Clark]

I think, you refer to Bug #377, not #380...?

Regards
Klaus
- -- 


Hi Klaus

#377 is "Reorganising bookmarks by mouse drag causes seg fault", which 
is still open. (Actually, I think it is probably a general DnD fault, 
not a bookmarks problem.)



In #380 MrDrizz refers to the fault that was already patched on 
2016-04-13 (commit 010ed5dddef21c17e2ced71d38d7ff6597f4f438). I guess he 
is using a not-the-latest version.



I do not know to ensure users are kept up-to-date with the latest 
version. Maybe Launchpad's PPA - but that kind of thing is beyond my 
ability to set up.




Colin..



--
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] [PATCH v2 1/1] Fix crash on drag and drop from xfe

[Colin Clark]

On 19/04/16 01:50, Jonathan Boeing wrote:
> On Mon, 18 Apr 2016 17:39:23 -0700
> Jonathan Boeing <jonathan.n.boe...@gmail.com> wrote:
>
>> diff --git a/src/ui_bookmark.c b/src/ui_bookmark.c
>> index 842b947..18f7311 100644
>> --- a/src/ui_bookmark.c
>> +++ b/src/ui_bookmark.c
>> @@ -707,13 +707,19 @@ static void bookmark_dnd_get_data(GtkWidget
>> *widget, {
>>  BookMarkData *bm = data;
>>  GList *list = NULL;
>> +GList *errors = NULL;
>>  GList *work;
>>  gchar **uris;
>>   
>>  if (!bm->editable) return;
>>   
>>  uris = gtk_selection_data_get_uris(selection_data);
>> -list = uri_filelist_from_uris(uris);
>> +list = uri_filelist_from_uris(uris, );
>> +if(errors)
>> +{
>> +warning_dialog_dnd_uri_error(errors);
>> +string_list_free(errors);
>> +}
>>  g_strfreev(uris);
>>   
>>  work = list;
> Would you rather have bookmark_dnd_get_data() call
> uri_filelist_from_gtk_selection_data()? It looks to me like it could
> have been calling it already, regardless of my patch.
>
>> +void warning_dialog_dnd_uri_error(GList *uri_error_list)
>> +{
>> +GList *work = uri_error_list;
>> +guint count = g_list_length(work);
>> +gchar *msg = g_strdup_printf("Failed to convert %d dropped
>> item(s) to files\n", count);
>> +if(count < 10)
>> +{
>> +while (work)
>> +{
>> +gchar *prev = msg;
>> +msg = g_strdup_printf("%s\n%s", prev, (gchar
>> *)work->data);
>> +work = work->next;
>> +g_free(prev);
>> +}
>> +}
>> +warning_dialog(_("Drag and Drop failed"), msg,
>> GTK_STOCK_DIALOG_WARNING, NULL);
>> +g_free(msg);
>> +}
> I'm not real happy about that strdup loop, but warning_dialog() didn't
> look like a good basis for a dialog with multiple strings (i.e. the list
> of failed conversions). Any suggestions for that, or is it fine as-is?
>
>
Hi Jonathon

I am not competent to decide whether or not this is a perfect solution - 
anyway, I would guess there is a fair bit of Geeqie that is sub-optimal.

It works. That's good enough for me. It's in the repo.


Thanks

Colin Clark



--
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] [PATCH 0/1] Fix crash on drag and drop from Xfe

[Colin Clark]

On 16/04/16 20:01, Jonathan Boeing wrote:
> Here's a patch to fix a crash that I've been hitting for a while. The
> issue is that when dragging and dropping from Xfe (a light-weight file
> explorer, http://roland65.free.fr/xfe/), paths aren't escaped like they
> are when dnd'ing from a GTK app. If the filename has characters that are
> reserved per URI rules (e.g. 'test # one'), g_filename_from_uri()
> returns null and geeqie crashes with a SIGSEGV.
>
> To fix it, the patch checks if the conversion failed due to a bad URI.
> If so, it manually escapes the URI and tries to convert again.
>
> This probably isn't specific to Xfe, but that's the only non-GTK/QT
> program I use that can drag and drop.
>
> Jonathan Boeing (1):
>Fix crash on drag and drop from xfe
>
>   src/uri_utils.c | 28 +++-
>   1 file changed, 27 insertions(+), 1 deletion(-)
>
Hi Jonathan

It looks to me that the user doesn't get notified that part of the DnD 
has failed.

Would it be better to perhaps include something like:

warning_dialog(_("Drag and Drop failed"), "some text", 
GTK_STOCK_DIALOG_WARNING, NULL);

some where in there? (Although the code doesn't know what its parent is, 
so that may also be a problem).

Sorry, but I cannot test here this because I cannot replicate that fault 
on my system.


My apologies if I have misunderstood your solution.


Colin Clark


--
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Issue #329 easier way to get cwd when copying

[Colin Clark]

https://github.com/BestImageViewer/geeqie/issues/329

I also find that when copying/moving, the current working directory is a 
better place to start from than either the last destination or Home.


The latest commit in the repository helps with this.

A bookmark with the name "." is treated as a special case. Each time it 
is displayed, it is loaded with the path of Geeqie's current working 
folder.


One can delete or recreate this bookmark at any time.

First-time users of Geeqie will see this bookmark, because it is now in 
the list of defaults.


Existing users who want this functionality will have to create a new 
bookmark and rename it to ".".


-

I am not sure how to communicate information such as this to existing 
Geeqie users. I doubt that many are readers of this mailing list, and I 
doubt that anyone reads the ChangeLog or NEWS files.


Maybe a pop-up window that is triggered on the first-time run after a 
version number change, and change the minor or micro version number 
whenever a material commit is made...


Colin Clark

--
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Cloning geeqie

[Colin Clark]

Hi Klaus

Just a small problem this time, I hope.

The Projects page on geeqie.org lists two URLs: 
git://www.geeqie.org/geeqie.git and http://www.geeqie.org/git/geeqie.git.

If I clone from git://www.geeqie.org/geeqie.git, I get all commits.

If I clone from http://www.geeqie.org/git/geeqie.git, the last commit is 
dated Sep 27 2015.


Best regards

Colin Clark



--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351=/4140
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Documentation - Command line and Remote options

[Colin Clark]

The Help documentation for command line options, and remote options, is 
not up to date.


The attached patch updates both the code (the -h and -rh options) and 
the xml/html help files.


If anyone patches an existing installation and wants to create the new 
html files, the following (perhaps non-intuitive) commands must be executed:


sudo make clean
make
sudo make install



Colin Clark


diff --git a/doc/docbook/GuideReferenceCommandLine.xml b/doc/docbook/GuideReferenceCommandLine.xml
index 1294df7..e23f583 100644
--- a/doc/docbook/GuideReferenceCommandLine.xml
+++ b/doc/docbook/GuideReferenceCommandLine.xml
@@ -42,12 +42,22 @@
   Start up in slideshow mode.
 
 
-  -l
+  -l [filelist] [collectionlist]
 
-  --list
+  --list [filelist] [collectionlist]
 
   Open collection window containing images specified on the command line. Any collections on the command line will also be appended to this collection.
 
+
+  --blank
+
+  Start with file list blank.
+
+
+  --geometry=wxh+x+y
+  
+  Set the width height xoffset yoffset of the window. The parameters are in pixels.
+  
 
   -r
 
@@ -77,9 +87,14 @@
   Display version of Geeqie.
 
 
-  --debug
+  --debug[=level]
+
+  Turn on debugging output (when compiled with Debug enabled). level is 0 to 4.
+
+
+  --alternate
 
-  Enable Debug output to console.
+  Use alternate similarity algorithm - experimental - requires re-compile.
 
 
 
@@ -161,19 +176,17 @@
 
   Stop slide show for main window.
 
-
-  -srlt;foldergt;
-
-  --slideshow-recurselt;foldergt;
+
+  --slideshow-recurse:folder
 
-  Start recursive slide show for lt;foldergt; in main window.
+  Start recursive slide show for folder in main window.
 
 
-  -dlt;ngt;
+  -d[n][.m]
 
-  --delay=lt;ngt;
+  --delay=[n][.m]
 
-  Set slide show delay to lt;ngt; seconds, range is 0.1 to 3600
+  Set slide show delay to [n][.m] seconds, range is 0.1 to 3600
 
 
   +t
@@ -197,14 +210,44 @@
   Quit Geeqie.
 
 
-  file:lt;filenamegt;
+  --config-load:file
+
+  Load configuration from file.
+
+
+  --get-sidecars:file
+
+  Get list of sidecars of file.
+
+
+  --get-destination:file
+
+  Get destination path of file. This is used by the symlink desktop file to implement the symbolic link operation. There is no useful function for the user.
+
+
+  file:file
+
+  Change main window to display file
+
+
+  view:file
+
+  Open new window containing file
+
+
+  --list-clear
+
+  Clear command line collection list
+
+
+  --list-add:file
 
-  Change main window to display lt;filenamegt;
+  Add file to command line collection list
 
 
-  view:lt;filenamegt;
+  raise
 
-  Open new window containing lt;filenamegt;
+  Bring the geeqie window to the top
 
 
   
diff --git a/src/main.c b/src/main.c
index c56ab57..88bbe20 100644
--- a/src/main.c
+++ b/src/main.c
@@ -320,19 +320,20 @@ static void parse_command_line(gint argc, gchar *argv[])
 printf_term("%s %s\n", GQ_APPNAME, VERSION);
 printf_term(_("Usage: %s [options] [path]\n\n"), GQ_APPNAME_LC);
 print_term(_("valid options are:\n"));
-print_term(_("  +t, --with-tools   force show of tools\n"));
-print_term(_("  -t, --without-toolsforce hide of tools\n"));
-print_term(_("  -f, --fullscreen   start in full screen mode\n"));
-print_term(_("  -s, --slideshowstart in slideshow mode\n"));
-print_term(_("  -l, --list open collection window for command line\n"));
-print_term(_("  --geometry=GEOMETRYset main window location\n"));
-print_term(_("  -r, --remote   send following commands to open window\n"));
-print_term(_("  -rh,--remote-help  print remote command list\n"));
+print_term(_("  +t, --with-tools force show of tools\n"));
+print_term(_("  -t, --without-tools  force hide of tools\n"));
+print_term(_("  -f, --fullscreen start in full screen mode\n"));
+print_term(_("  -s, --slideshow  start in slideshow mode\n"));
+print_term(_("  -l, --list [files] [collections] open collection window for command line\n"

[Geeqie-devel] Feature Request #70 Navigation menu option and button for parent directory

[Colin Clark]

This request was made some years ago:

https://sourceforge.net/p/geeqie/feature-requests/70/

I have attached a patch which implements this. Also, keyboard-only users 
will be able to use keyboard-accelerators to map a key to the Up function.


Unfortunately there is a usability problem. If the configuration file 
geeqirc.xml exists (which it will except for first-time installations) 
geeqie will not look at the programmed defaults, but will create the 
toolbar from the config file - and the Up icon will not be displayed.


If the user first executes a command such as this:

sed -i '/toolitem action = "Back"/a ' 
~/.config/geeqie/geeqierc.xml


then all will be well.

This is not ideal, but I see no other solution.



Colin Clark



diff --git a/src/layout_util.c b/src/layout_util.c
index a954019..5d99ea3 100644
--- a/src/layout_util.c
+++ b/src/layout_util.c
@@ -1066,6 +1066,25 @@ static void layout_menu_home_cb(GtkAction *action, gpointer data)
 		}
 }
 
+static void layout_menu_up_cb(GtkAction *action, gpointer data)
+{
+	LayoutWindow *lw = data;
+	ViewDir *vd = lw->vd;
+	gchar *path;
+
+	if (!vd->dir_fd || strcmp(vd->dir_fd->path, G_DIR_SEPARATOR_S) == 0) return;
+	path = remove_level_from_path(vd->dir_fd->path);
+
+	if (vd->select_func)
+		{
+		FileData *fd = file_data_new_dir(path);
+		vd->select_func(vd, fd, vd->select_data);
+		file_data_unref(fd);
+		}
+
+	g_free(path);
+}
+
 
 /*
  *-
@@ -1275,6 +1294,7 @@ static GtkActionEntry menu_entries[] = {
   { "LastImage",	GTK_STOCK_GOTO_BOTTOM,	N_("_Last Image"),			"End",			N_("Last Image"),			CB(layout_menu_image_last_cb) },
   { "Back",		GTK_STOCK_GO_BACK,	N_("_Back"),NULL,			N_("Back"),CB(layout_menu_back_cb) },
   { "Home",		GTK_STOCK_HOME,		N_("_Home"),NULL,			N_("Home"),CB(layout_menu_home_cb) },
+  { "Up",		GTK_STOCK_GO_UP,		N_("_Up"),NULL,			N_("Up"),CB(layout_menu_up_cb) },
 
   { "NewWindow",	GTK_STOCK_NEW,		N_("New _window"),			"N",		N_("New window"),			CB(layout_menu_new_window_cb) },
   { "NewCollection",	GTK_STOCK_INDEX,	N_("_New collection"),			"C",			N_("New collection"),			CB(layout_menu_new_cb) },
@@ -1466,6 +1486,7 @@ static const gchar *menu_ui_description =
 "  "
 "  "
 "  "
+"  "
 "  "
 "  "
 ""
@@ -2152,6 +2173,7 @@ void layout_toolbar_add_default(LayoutWindow *lw, ToolbarType type)
 		case TOOLBAR_MAIN:
 			layout_toolbar_add(lw, type, "Thumbnails");
 			layout_toolbar_add(lw, type, "Back");
+			layout_toolbar_add(lw, type, "Up");
 			layout_toolbar_add(lw, type, "Home");
 			layout_toolbar_add(lw, type, "Refresh");
 			layout_toolbar_add(lw, type, "ZoomIn");
diff --git a/src/view_dir_list.c b/src/view_dir_list.c
index fa65a74..959eb31 100644
--- a/src/view_dir_list.c
+++ b/src/view_dir_list.c
@@ -146,15 +146,7 @@ static gboolean vdlist_populate(ViewDir *vd, gboolean clear)
 	ret = filelist_read(vd->dir_fd, NULL, (vd)->list);
 	VDLIST(vd)->list = filelist_sort(VDLIST(vd)->list, sort_type, sort_ascend);
 
-	/* add . and .. */
-
-	if (strcmp(vd->dir_fd->path, G_DIR_SEPARATOR_S) != 0)
-		{
-		filepath = g_build_filename(vd->dir_fd->path, "..", NULL);
-		fd = file_data_new_dir(filepath);
-		VDLIST(vd)->list = g_list_prepend(VDLIST(vd)->list, fd);
-		g_free(filepath);
-		}
+	/* add . */
 
 	if (options->file_filter.show_dot_directory)
 		{
--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Bug fix: #227 Keywords section of Info sidebar doesn't work on GTK3 build

[Colin Clark]

Late last year Tomasz Golinski submitted this bug:

https://sourceforge.net/p/geeqie/bugs/227/


I don't know what has changed in GTK to cause this, but I think the 
attached patch is an acceptable, possibly permanent, workaround.


In the Layout section of geeqie's geeqierc.xml configuration file some 
of the sidebar panes have a "height" field. The Keywords section does not.


This patch implements a "height" field for the Keywords pane.

When geeqie is not running, the height fields in the configuration file 
can be edited to suitable values, and will be used the next time geeqie 
is run.




Colin Clark..

diff --git a/src/bar_keywords.c b/src/bar_keywords.c
index f58f348..4cf240a 100644
--- a/src/bar_keywords.c
+++ b/src/bar_keywords.c
@@ -113,6 +113,7 @@ struct _PaneKeywordsData
 	guint idle_id; /* event source id */
 	FileData *fd;
 	gchar *key;
+	gint height;
 };
 
 typedef struct _ConfDialogData ConfDialogData;
@@ -249,6 +250,7 @@ static void bar_pane_keywords_write_config(GtkWidget *pane, GString *outstr, gin
 	write_char_option(outstr, indent, "title", gtk_label_get_text(GTK_LABEL(pkd->pane.title)));
 	WRITE_BOOL(pkd->pane, expanded);
 	WRITE_CHAR(*pkd, key);
+	WRITE_INT(*pkd, height);
 	WRITE_STRING("/>");
 }
 
@@ -1263,7 +1265,7 @@ static void bar_pane_keywords_destroy(GtkWidget *widget, gpointer data)
 }
 
 
-static GtkWidget *bar_pane_keywords_new(const gchar *id, const gchar *title, const gchar *key, gboolean expanded)
+static GtkWidget *bar_pane_keywords_new(const gchar *id, const gchar *title, const gchar *key, gboolean expanded, gint height)
 {
 	PaneKeywordsData *pkd;
 	GtkWidget *hbox;
@@ -1285,6 +1287,7 @@ static GtkWidget *bar_pane_keywords_new(const gchar *id, const gchar *title, con
 
 	pkd->pane.expanded = expanded;
 
+	pkd->height = height;
 	pkd->key = g_strdup(key);
 
 	pkd->expand_checked = TRUE;
@@ -1295,6 +1298,7 @@ static GtkWidget *bar_pane_keywords_new(const gchar *id, const gchar *title, con
 	g_object_set_data(G_OBJECT(pkd->widget), "pane_data", pkd);
 	g_signal_connect(G_OBJECT(pkd->widget), "destroy",
 			 G_CALLBACK(bar_pane_keywords_destroy), pkd);
+	gtk_widget_set_size_request(pkd->widget, -1, height);
 	gtk_widget_show(hbox);
 
 	scrolled = gtk_scrolled_window_new(NULL, NULL);
@@ -1417,6 +1421,7 @@ GtkWidget *bar_pane_keywords_new_from_config(const gchar **attribute_names, cons
 	gchar *title = NULL;
 	gchar *key = g_strdup(COMMENT_KEY);
 	gboolean expanded = TRUE;
+	gint height = 350;
 	GtkWidget *ret;
 
 	while (*attribute_names)
@@ -1428,13 +1433,14 @@ GtkWidget *bar_pane_keywords_new_from_config(const gchar **attribute_names, cons
 		if (READ_CHAR_FULL("title", title)) continue;
 		if (READ_CHAR_FULL("key", key)) continue;
 		if (READ_BOOL_FULL("expanded", expanded)) continue;
+		if (READ_INT_FULL("height", height)) continue;
 
 
 		log_printf("unknown attribute %s = %s\n", option, value);
 		}
 
 	bar_pane_translate_title(PANE_KEYWORDS, id, );
-	ret = bar_pane_keywords_new(id, title, key, expanded);
+	ret = bar_pane_keywords_new(id, title, key, expanded, height);
 	g_free(id);
 	g_free(title);
 	g_free(key);
--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] GPS Maps

[Colin Clark]

It's been a considerable time since I tried to compile geeqie, and there 
have obviously been significant organizational changes in the meantime. 
But it's good to see there is still interest in the project.


I assume that the git repository at geeqie.org is now the location of 
the latest sources.


Using the --enable-gps option I get compile errors. I don't see any 
other messages about this, so I assume it's either a problem with my 
system configuration, or more probably no-one else uses the maps.


Nevertheless, I have attached a patch that gives me an error-free 
compilation on my system.



Colin Clark..

diff --git a/src/renderer-clutter.c b/src/renderer-clutter.c
index c0f3b10..de91bc5 100644
--- a/src/renderer-clutter.c
+++ b/src/renderer-clutter.c
@@ -234,7 +234,19 @@ static void rc_prepare_post_process_lut(RendererClutter *rc)
 	g_object_unref(tmp_pixbuf);
 
 	DEBUG_0("%s clut upload start", get_exec_time());
-#if CLUTTER_CHECK_VERSION(1,10,0)
+#if COGL_VERSION_CHECK(1,18,2)
+	{
+	CoglContext *ctx = clutter_backend_get_cogl_context(clutter_get_default_backend ());
+
+	tex3d = cogl_texture_3d_new_from_data(ctx,
+	  CLUT_SIZE, CLUT_SIZE, CLUT_SIZE,
+	  COGL_PIXEL_FORMAT_RGB_888,
+	  CLUT_SIZE * 3,
+	  CLUT_SIZE * CLUT_SIZE * 3,
+	  clut,
+	  NULL);
+	}
+#elif COGL_VERSION_CHECK(1,10,4)
 	{
 	CoglContext *ctx = clutter_backend_get_cogl_context(clutter_get_default_backend ());
 
--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Keyboard shortcuts for externel editors?

[Colin Clark]

Volker Wysk pf3@... writes:

 
 
  Hallo!
 
  Is it possible to associate keyboad shortcuts with external editors?
  If it isn't, then this would be a feature request.
 
  Cheers,
  Volker
 
 
 
  -

The shortcuts are in preferences/keyboard but I find that once an 
accelerator key is set I cannot delete it (other than by editing the 
accels file).

I assume that BackSpace should clear a current setting, but that does 
not work for me. Does anyone know how to delete an existing shortcut key 
setting?



--
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951iu=/4140/ostg.clktrk
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Consider adding an Up button

[colin clark]

The attached diff file should get you an Up button.Unfortunately an existing
geeqierc.xml file will prevent an new toolbar item being displayed, so you
will need to edit that file to include the new item.It's perhaps easiest to
rename geeqierc.xml, run geeqie to generate a new file, and look for the
change that needs to be made - it will be one extra line in the toolbar
section. up_button.diff
http://gnome-apps.13852.n7.nabble.com/file/n6/up_button.diff  



--
View this message in context: 
http://gnome-apps.13852.n7.nabble.com/Consider-adding-an-Up-button-tp64268p6.html
Sent from the Geeqie mailing list archive at Nabble.com.--
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register 
http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Keywords pane height

[Colin Clark]

Is there a way to set the height of the Keywords pane in the info sidebar?

Other panes such as Title and Comment have a height parameter in the 
geeqierc.xml file, but not Keywords.

Is there a reason for Keywords to not have a height parameter?

Thanks

Colin Clark


--
Keep yourself connected to Go Parallel: 
INSIGHTS What's next for parallel hardware, programming and related areas?
Interviews and blogs by thought leaders keep you ahead of the curve.
http://goparallel.sourceforge.net
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Geeqie repositories

[Colin Clark]

Klaus Ethgen-5 wrote:
 
 
 - - Then I have different remotes with all the branches they have:
github  git://github.com/zas/geeqie_zas.git (fetch)
github  g...@github.com:zas/geeqie_zas.git (push)
gitorious   g...@gitorious.org:geeqie/geeqie.git (fetch)
gitorious   g...@gitorious.org:geeqie/geeqie.git (push)
origin  ssh://tschil.ethgen.ch/~/git/geeqie.git (fetch)
origin  ssh://tschil.ethgen.ch/~/git/geeqie.git (push)
sf  git://geeqie.git.sourceforge.net/gitroot/geeqie/geeqie (fetch)
sf  m...@geeqie.git.sourceforge.net/gitroot/geeqie/geeqie (push)
 
 As you can see, origin points on my own server where I have a similar
 layout and a hook that pushes all my work to all (at the moment github
 and gitorious) upstream repositories.
 
 


Would it be possible for the master on gitorious to be automatically pushed
onto SourceForge?

Geeqie on SourceForge looks to be a somewhat dead project, as the files have
not been updated for months.

People who are looking for software will not find geeqie on gitorious
because they will look no further than SourceForge.

For example this link..:

http://www.tuxarena.com/2011/02/top-5-image-viewers-for-ubuntukubuntu/

.. about half-way down the page shows that some people look only as far as
SourceForge (and have not yet made the connection between GQView and
geeqie).

Wherever, however, the developers want to update geeqie, I think that to
keep the general public up to date it is important that SourceForge also has
the latest source tars (and packages if possible).


-- 
View this message in context: 
http://old.nabble.com/Geeqie-repositories-tp30914628p32124744.html
Sent from the Geeqie mailing list archive at Nabble.com.


--
Magic Quadrant for Content-Aware Data Loss Prevention
Research study explores the data loss prevention market. Includes in-depth
analysis on the changes within the DLP market, and the criteria used to
evaluate the strengths and weaknesses of these DLP solutions.
http://www.accelacomm.com/jaw/sfnl/114/51385063/
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] group permissions not recognized

[Colin Clark]

On 15/07/11 14:00, Richard Guy Briggs wrote:
 On Fri, Jul 15, 2011 at 11:50:13AM +, Arnd wrote:
 Richard Guy Briggsr...@tricolour.net  [Tue, 12
 Jul 2011 17:08:33 -0400]

 When trying to manipulate files for which I have group write
 permissions but not user write permissions, the operation fails (such
 as move or delete).
 If the directory those files are in does not have group write permissions
 as well, it must fail.
 The containing directory also has group write permisssions, otherwise I
 would not be able to manipulate the file on the command line.  I know
 how unix file permissions work.  The problem is the behaviour is
 different between the command line and Geeqie.

 I am not the owner of the file.  I am only a member of the group.
 What's strange is that if the permissions for dir and file are OK, Geeqie
 will complain it can't copy (!) or move the file, but will do it anyway!
 Same applies to scripts (External Editors).
Perhaps the following bug report and patch are related to this problem:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=574853



--
AppSumo Presents a FREE Video for the SourceForge Community by Eric 
Ries, the creator of the Lean Startup Methodology on Lean Startup 
Secrets Revealed. This video shows you how to validate your ideas, 
optimize your ideas and identify your business strategy.
http://p.sf.net/sfu/appsumosfdev2dev
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] group permissions not recognized

[Colin Clark]

On 09/07/11 04:48, Richard Guy Briggs wrote:
 Hi all,

 I just confirmed what was bugging me for a while and somehow sounds
 vaguely familiar (someone else may have reported it recently on this
 list).

 I'm using Geeqie 1.0 on Debian, just updated.

 When trying to manipulate files for which I have group write permissions
 but not user write permissions, the operation fails (such as move or
 delete).

When testing for permissions the operating system looks at 
user/group/world in that order.

If you are the owner of the file and do not have write permission, then 
the operating system does not consider the group or world write permissions.

Colin Clark


--
AppSumo Presents a FREE Video for the SourceForge Community by Eric 
Ries, the creator of the Lean Startup Methodology on Lean Startup 
Secrets Revealed. This video shows you how to validate your ideas, 
optimize your ideas and identify your business strategy.
http://p.sf.net/sfu/appsumosfdev2dev
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Documentation and code standards

[Colin Clark]

Hi
Perhaps I could make some comments here not as a developer, but as a user.

1) It's probably a good idea for us to start documenting the functions
we write and the APIs we create.  For one, it's a reminder to think
about what specific problems the function/API is solving.  Beyond that,
it helps someone unfamiliar with the code figure out what's going on,
and it helps them avoid misusing a particular function.
What I find missing is high-level documentation, not low-level. An 
overall description of the way the system is organised and how the main 
functions and structures should be used. But in my experience, 
programmers won't produce documentation even when they are being paid to 
do it, and no-one is being paid to work on Geeqie. Being realistic, I 
don't think it is reasonable to expect people to do this.

2) We need to have a maximum line length.  It can be long, sure, but
it's pretty obscene when there are lines so long that they wrap on my
26 widescreen monitor (layout_util.c is a pretty bad offender).  I'm
going to suggest 160 characters; see * below.

Line length was important to me when I used 72-character terminals 
nearly half a century ago. Now I use a visual editor with line-wrap 
enabled. No matter what size window I use, the code is readable.


But I do find it very surprising that Geeqie has a non-standard coding 
format. Layout consistency could be achieved if the developers selected 
a standard format - maybe Allman or Whitesmith - and run all code 
through a code beautifier before putting it in the repository. Time 
spent on code formatting by hand is not a good use of time and will 
result in inconsistencies.



May I also make a plea for the common user, people like me who can just 
about do a configure/make.


Would it be possible for source tars (or even .deb files) of the latest 
files to be put on the Geeqie homepage on sourceforge? Is it possible 
for this do be done automatically whenever one of the git repositories 
is updated?



I would also encourage the developers to try to make Geeqie at least as 
good as GQview. There are two problems where I find GQview is 
significantly better than Geeqie:


During copy/move/rename there is no thumbnail displayed when there is a 
destination file conflict (I've made a patch to do this, which is ok for 
me, but it is a poor technical solution to the problem).


When I work with folders containing several thousand files, any 
operation on the files results in the view scrolling away from the area 
I am working on. I guess this is the same as bug *3107316*, and I assume 
it's because of gtktreeview being updated in the idle loop. But 
whatever, when I'm doing this kind of work I have to switch back to GQview!


But again, one must be realistic, and a combination of GQview and Geeqie 
works well for me as is.



Colin Clark..



--
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Documentation and code standards

[Colin Clark]

Hi
 https://gitorious.org/geeqie/geeqie/archive-tarball/master

 You can find that link if you look at the log of a branch on the right
 side.
Thanks for the info.
 During copy/move/rename there is no thumbnail displayed when there
 is a destination file conflict (I've made a patch to do this, which
 is ok for me, but it is a poor technical solution to the problem).
 Jup, that I was annoyed about once myself. Just post your patch, maybe
 it can be used.
It is the last patch in the cclark branch on github.
The problem area is around line 407 of file_data_new.c where I use 
inodes. That's clearly not a general solution.
I guess a better solution is to create a FileData structure for the 
target file before an entry is made into file_data_planned_change_hash. 
But there's also the problem of file_data_ref and file_data_unref.

[The first patch in that branch is intended to solve the problem 
described in 
http://sourceforge.net/mailarchive/forum.php?thread_name=20110121140713.41f82358%40gmail.comforum_name=geeqie-devel]

 There is just one case I use an other tool -- xv -- is to view images
 the fast way as there is no other application than xv out in the wild
 that is that fast. (See also my own work on xv[0].)
I remember that from years ago! I have no recollection of why I stopped 
using it - I'll take a look at your website.


Colin Clark..

--
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] grouping with darktable xmp files

[Colin Clark]

On 13/04/11 22:01, Colin Clark wrote:
 On 10/04/11 17:51, stair wrote:
 I have recently starting using darktable for my raw processing and have
 come across a problem with the way geeqie groups darktable's xmp files, or
 rather doesn't, the files are not grouped

 when darktable creates it's sidecar files they are given the raw file full
 name including extension, in my case image.CR2, and adds the .xmp
 extension, so the sidecar is image.CR2.xmp.

 The only way I can get grouping to work is to change the sidecar file name
 to eliminate the .CR2 bit but this is not a solution since it breaks the
 connection in darktable.  Trying various things in the sidecar extensions
 list does not help

 I don't think I am missing something here, if so a pointer would be
 appreciated.  If not then it would be very good if this could be fixed

 Thanks

 Stair



 --
 Xperia(TM) PLAY
 It's a major breakthrough. An authentic gaming
 smartphone on the nation's most reliable network.
 And it wants your games.
 http://p.sf.net/sfu/verizon-sfdev
 ___
 Geeqie-devel mailing list
 Geeqie-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/geeqie-devel

 Hi

 I find that if I append .CR2.xmp to the sidecars extension list
 (edit/preferences/preferences/files), then using right click on an image
 set Disable File Grouping followed by Enable File Grouping -

 the .CR2.xmp files are then shown as grouped with the image.

 But this is not working correctly as the grouping is lost on re-start
 and the file extensions of the sidecar files get corrupted when doing a
 copy or move.

 So there is clearly a bug in this part of the code, but if this is
 corrected it may be that you will get the functionality you are looking for.

 Colin Clark

Try changing line 761 of ui_fileops.c from

return strrchr(path, '.');

to

return strchr(path, '.');


I have no idea if that's a real solution to the problem - I'll have to 
leave that decision to someone who knows how Geeqie works.


Colin Clark



--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] grouping with darktable xmp files

[Colin Clark]

On 10/04/11 17:51, stair wrote:
 I have recently starting using darktable for my raw processing and have
 come across a problem with the way geeqie groups darktable's xmp files, or
 rather doesn't, the files are not grouped

 when darktable creates it's sidecar files they are given the raw file full
 name including extension, in my case image.CR2, and adds the .xmp
 extension, so the sidecar is image.CR2.xmp.

 The only way I can get grouping to work is to change the sidecar file name
 to eliminate the .CR2 bit but this is not a solution since it breaks the
 connection in darktable.  Trying various things in the sidecar extensions
 list does not help

 I don't think I am missing something here, if so a pointer would be
 appreciated.  If not then it would be very good if this could be fixed

 Thanks

 Stair



 --
 Xperia(TM) PLAY
 It's a major breakthrough. An authentic gaming
 smartphone on the nation's most reliable network.
 And it wants your games.
 http://p.sf.net/sfu/verizon-sfdev
 ___
 Geeqie-devel mailing list
 Geeqie-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Hi

I find that if I append .CR2.xmp to the sidecars extension list 
(edit/preferences/preferences/files), then using right click on an image 
set Disable File Grouping followed by Enable File Grouping -

the .CR2.xmp files are then shown as grouped with the image.

But this is not working correctly as the grouping is lost on re-start 
and the file extensions of the sidecar files get corrupted when doing a 
copy or move.

So there is clearly a bug in this part of the code, but if this is 
corrected it may be that you will get the functionality you are looking for.

Colin Clark



--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] copy/move/rename - GQview-style preview

[Colin Clark]

In the cclark branch of github.com:zas/geeqie_zas.git is a patch to show 
thumbnails of a target files when there is going to be a conflict during 
a copy/move/rename operation. It also allows files to be renamed 
on-the-fly during copy/move operations.

As this patch affects file operations I think it should be thoroughly 
tested before relying on it. In particular I am concerned because the 
only way I could get it to work was to use inodes - which theoretically 
don't exist on FAT/NTFS etc.

I checked this on a FAT drive, and it seems ok - stat() produces 
sensible numbers for st_ino and st_dev.

It would be good if someone could verify that it doesn't work - then I 
know I'll have to find another solution.


Colin Clark



--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] File rename function - possible data loss

[Colin Clark]

Hi

If multiple files are selected for renaming and the manual rename option 
is used, it is possible to input the same destination filename for more 
than one file.


If the operation is executed, files will be overwritten with no warning.

I don't think this should be permitted to happen with a program like 
Geeqie - inexperienced users should be given more protection.


I have attached a patch which might solve the problem. Perhaps someone 
else could review the code?



Colin Clark


diff --git a/src/filedata.c b/src/filedata.c
index 388037f..bd73058 100644
--- a/src/filedata.c
+++ b/src/filedata.c
@@ -2014,10 +2014,12 @@ gboolean file_data_sc_update_ci_unspecified_list(GList *fd_list, const gchar *de
  * it should detect all possible problems with the planned operation
  */
 
-gint file_data_verify_ci(FileData *fd)
+gint file_data_verify_ci(FileData *fd, GList *list)
 {
 	gint ret = CHANGE_OK;
 	gchar *dir;
+	GList *work = NULL;
+	FileData *fd1 = NULL;
 	
 	if (!fd-change)
 		{
@@ -2227,6 +2229,26 @@ gint file_data_verify_ci(FileData *fd)
 		g_free(dest_dir);
 		}
 		
+	/* During a rename operation, check if another destination file has
+	 * the same filename
+	 */
+ 	if(fd-change-type == FILEDATA_CHANGE_RENAME)
+		{
+		work = list;
+		while (work)
+			{
+			fd1 = work-data;
+			work = work-next;
+			if (fd1 != NULL  fd != fd1 )
+{
+if (!strcmp(fd-change-dest, fd1-change-dest))
+	{
+	ret |= CHANGE_WARN_DUPLICATE_DEST;
+	}
+}
+			}
+		}
+
 	fd-change-error = ret;
 	if (ret == 0) DEBUG_1(Change checked: OK: %s, fd-path);
 
@@ -2235,19 +2257,19 @@ gint file_data_verify_ci(FileData *fd)
 }
 
 
-gint file_data_sc_verify_ci(FileData *fd)
+gint file_data_sc_verify_ci(FileData *fd, GList *list)
 {
 	GList *work;
 	gint ret;
 
-	ret = file_data_verify_ci(fd);
+	ret = file_data_verify_ci(fd, list);
 
 	work = fd-sidecar_files;
 	while (work)
 		{
 		FileData *sfd = work-data;
 
-		ret |= file_data_verify_ci(sfd);
+		ret |= file_data_verify_ci(sfd, list);
 		work = work-next;
 		}
 
@@ -2330,6 +2352,12 @@ gchar *file_data_get_error_string(gint error)
 		g_string_append(result, _(there are unsaved metadata changes for the file));
 		}
 
+	if (error  CHANGE_WARN_DUPLICATE_DEST)
+		{
+		if (result-len  0) g_string_append(result, , );
+		g_string_append(result, _(another destination file has the same filename));
+		}
+
 	return g_string_free(result, FALSE);
 }
 
@@ -2356,7 +2384,7 @@ gint file_data_verify_ci_list(GList *list, gchar **desc, gboolean with_sidecars)
 		fd = work-data;
 		work = work-next;
 			
-		error = with_sidecars ? file_data_sc_verify_ci(fd) : file_data_verify_ci(fd);
+		error = with_sidecars ? file_data_sc_verify_ci(fd, list) : file_data_verify_ci(fd, list);
 		all_errors |= error;
 		common_errors = error;
 		
diff --git a/src/filedata.h b/src/filedata.h
index d3c5c63..03b3ae4 100644
--- a/src/filedata.h
+++ b/src/filedata.h
@@ -110,7 +110,7 @@ gboolean file_data_sc_update_ci_unspecified(FileData *fd, const gchar *dest_path
 
 gchar *file_data_get_error_string(gint error);
 
-gint file_data_verify_ci(FileData *fd);
+gint file_data_verify_ci(FileData *fd, GList *list);
 gint file_data_verify_ci_list(GList *list, gchar **desc, gboolean with_sidecars);
 
 gboolean file_data_perform_ci(FileData *fd);
@@ -120,7 +120,7 @@ void file_data_free_ci_list(GList *fd_list);
 
 void file_data_set_regroup_when_finished(FileData *fd, gboolean enable);
 
-gint file_data_sc_verify_ci(FileData *fd);
+gint file_data_sc_verify_ci(FileData *fd, GList *list);
 
 gboolean file_data_sc_perform_ci(FileData *fd);
 gboolean file_data_sc_apply_ci(FileData *fd);
diff --git a/src/typedefs.h b/src/typedefs.h
index cc10b54..c535908 100644
--- a/src/typedefs.h
+++ b/src/typedefs.h
@@ -159,6 +159,7 @@ typedef enum {
 	CHANGE_WARN_SAME   = 1  2,
 	CHANGE_WARN_CHANGED_EXT= 1  3,
 	CHANGE_WARN_UNSAVED_META   = 1  4,
+	CHANGE_WARN_DUPLICATE_DEST = 1  5,
 	CHANGE_ERROR_MASK  = (~0)  8, /* the values below are fatal errors */
 	CHANGE_NO_READ_PERM= 1  8,
 	CHANGE_NO_WRITE_PERM_DIR   = 1  9,
diff --git a/src/utilops.c b/src/utilops.c
index e32a18d..f6b2469 100644
--- a/src/utilops.c
+++ b/src/utilops.c
@@ -36,7 +36,7 @@
 
 #define DIALOG_WIDTH 750
 
-static GdkPixbuf *file_util_get_error_icon(FileData *fd, GtkWidget *widget);
+static GdkPixbuf *file_util_get_error_icon(FileData *fd, GList *list, GtkWidget *widget);
 
 /*
  *--
@@ -473,7 +473,7 @@ static GtkWidget *file_util_dialog_add_list(GtkWidget *box, GList *list, gboolea
 		gchar *sidecars;
 		
 		sidecars = with_sidecars ? file_data_sc_list_to_string(fd) : NULL;
-		GdkPixbuf *icon = file_util_get_error_icon(fd, view);
+		GdkPixbuf *icon = file_util_get_error_icon(fd, list, view);
 		gtk_list_store_append(store, iter);
 		gtk_list_store_set(store, iter,
    UTILITY_COLUMN_FD, fd,
@@ -893,7 +893,7 @@ void file_util_perform_ci

[Geeqie-devel] Collections - collect_io.c - possible bug

[Colin Clark]

Hi

If one sets up a collection with a single file, then renames that file, 
Geeqie will crash.

I believe the problem is line 661 in collect_io.c where 'path' is freed. 
This is coming from the call in line 161 where 'buf' is set to something 
that should not be freed.

At the moment I do not understand the collection code, but for me just 
commenting out line 661 solves the problem.


Colin Clark


--
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] File copy and move functions

[Colin Clark]

Hi
 what is the section of code at line 405 in filedata.c used for?

 Some info in following commits:
 https://github.com/zas/geeqie_zas/commit/a3c139eafad2246f8bde6cef391def6ab4670127
 https://github.com/zas/geeqie_zas/commit/9f2b4b649b703a20350e1962684fe4422d4d39a8

Thanks for the information. I now understand things a little better. 
maybe.

Perhaps that section of filedata.c should use the file's inode or 
something similar. If there is no other better idea, I guess I'll look 
into that.


Colin Clark


--
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] preferences.c - patch for FIXMEs

[Colin Clark]

Hi

Attached is a patch for two minor FIXMEs in the preferences page.

In the Files tab: when Add is pressed scroll to the new entry and set 
focus to the file-type field

In the Files tab: when Defaults is selected scroll to column 0, row 0
In the Keyboard tab: when Defaults is pressed scroll to column 0, row 0

These are just cosmetic changes, so are not really of interest until the 
next release happens.



Colin Clark

diff --git a/src/preferences.c b/src/preferences.c
index bedc10b..d088bc2 100644
--- a/src/preferences.c
+++ b/src/preferences.c
@@ -712,12 +712,48 @@ static void filter_set_func(GtkTreeViewColumn *tree_column, GtkCellRenderer *cel
 		}
 }
 
+static gboolean filter_add_scroll(gpointer data)
+{
+	GtkTreePath *path;
+	GList *list_cells;
+	GtkCellRenderer *cell;
+	GtkTreeViewColumn *column;
+	GList *list_columns;
+	const gchar *title;
+	guint i = 0;
+	gint rows;
+
+	rows = gtk_tree_model_iter_n_children(GTK_TREE_MODEL(filter_store), NULL);
+	path = gtk_tree_path_new_from_indices(rows-1, -1);
+	
+	list_columns = gtk_tree_view_get_columns(GTK_TREE_VIEW(data));
+	do {
+		column = g_list_nth(list_columns,i)-data;
+		title = gtk_tree_view_column_get_title(GTK_TREE_VIEW_COLUMN(column));
+		i++;
+		} while (strcmp(title, Filter) !=0 );
+
+	list_cells = gtk_cell_layout_get_cells(GTK_CELL_LAYOUT(column));
+	cell = g_list_last(list_cells)-data;
+
+	gtk_tree_view_scroll_to_cell(GTK_TREE_VIEW(data),
+path, column, FALSE, 0.0, 0.0 ); 
+	gtk_tree_view_set_cursor_on_cell(GTK_TREE_VIEW(data),
+path, column, cell, TRUE);
+
+	gtk_tree_path_free(path);
+	g_list_free(list_cells);
+	g_list_free(list_columns);
+  
+	return(FALSE); 
+}
+
 static void filter_add_cb(GtkWidget *widget, gpointer data)
 {
 	filter_add_unique(description, .new, FORMAT_CLASS_IMAGE, TRUE, FALSE, TRUE);
 	filter_store_populate();
 
-	/* FIXME: implement the scroll to/select row stuff for tree view */
+	g_idle_add((GSourceFunc)filter_add_scroll, data);
 }
 
 static void filter_remove_cb(GtkWidget *widget, gpointer data)
@@ -738,12 +774,33 @@ static void filter_remove_cb(GtkWidget *widget, gpointer data)
 	filter_store_populate();
 }
 
+static gboolean filter_default_ok_scroll(GtkTreeView *data)
+{
+	GtkTreeIter iter;
+	GtkTreePath *path;
+	GtkTreeViewColumn *column;
+	
+	gtk_tree_model_get_iter_first(GTK_TREE_MODEL(filter_store), iter);
+	path = gtk_tree_model_get_path(GTK_TREE_MODEL(filter_store), iter);
+	column = gtk_tree_view_get_column(GTK_TREE_VIEW(data),0);
+	
+	gtk_tree_view_scroll_to_cell(GTK_TREE_VIEW(data),
+ path, column,
+ FALSE, 0.0, 0.0); 
+  
+gtk_tree_path_free(path);
+
+	return(FALSE); 
+}
+
 static void filter_default_ok_cb(GenericDialog *gd, gpointer data)
 {
 	filter_reset();
 	filter_add_defaults();
 	filter_rebuild();
 	filter_store_populate();
+
+	g_idle_add((GSourceFunc)filter_default_ok_scroll, gd-data);
 }
 
 static void dummy_cancel_cb(GenericDialog *gd, gpointer data)
@@ -757,7 +814,7 @@ static void filter_default_cb(GtkWidget *widget, gpointer data)
 
 	gd = generic_dialog_new(_(Reset filters),
 reset_filter, widget, TRUE,
-dummy_cancel_cb, NULL);
+dummy_cancel_cb, data);
 	generic_dialog_add_message(gd, GTK_STOCK_DIALOG_QUESTION, _(Reset filters),
    _(This will reset the file filters to the defaults.\nContinue?));
 	generic_dialog_add_button(gd, GTK_STOCK_OK, NULL, filter_default_ok_cb, TRUE);
@@ -969,11 +1026,30 @@ static void accel_store_edited_cb(GtkCellRendererAccel *accel, gchar *path_strin
 	g_free(acc);
 }
 
+static gboolean accel_default_scroll(GtkTreeView *data)
+{
+	GtkTreeIter iter;
+	GtkTreePath *path;
+	GtkTreeViewColumn *column;
+	
+	gtk_tree_model_get_iter_first(GTK_TREE_MODEL(accel_store), iter);
+	path = gtk_tree_model_get_path(GTK_TREE_MODEL(accel_store), iter);
+	column = gtk_tree_view_get_column(GTK_TREE_VIEW(data),0);
+	
+	gtk_tree_view_scroll_to_cell(GTK_TREE_VIEW(data),
+ path, column,
+ FALSE, 0.0, 0.0); 
+  
+gtk_tree_path_free(path);
+
+	return(FALSE); 
+}
+
 static void accel_default_cb(GtkWidget *widget, gpointer data)
 {
 	accel_store_populate();
 
-	/* FIXME: implement the scroll to/select row stuff for tree view */
+	g_idle_add((GSourceFunc)accel_default_scroll, data);
 }
 
 void accel_remove_selection(GtkTreeModel *model, GtkTreePath *path, GtkTreeIter *iter, gpointer data)
@@ -1571,7 +1647,7 @@ static void config_tab_files(GtkWidget *notebook)
 	hbox = pref_box_new(group, FALSE, GTK_ORIENTATION_HORIZONTAL, PREF_PAD_BUTTON_GAP);
 
 	button = pref_button_new(NULL, NULL, _(Defaults), FALSE,
- G_CALLBACK(filter_default_cb), NULL);
+ G_CALLBACK(filter_default_cb), filter_view);
 	gtk_box_pack_end(GTK_BOX(hbox), button, FALSE, FALSE, 0);
 	gtk_widget_show(button);
 
@@ -1581,7 +1657,7 @@ static void

Re: [Geeqie-devel] grouping function for sidecar-extension

[Colin Clark]

R S-11 wrote:
 
 Hi,
 
 I'm looking for help to configure the file grouping function for
 sidecar-extension. I want to be able to rename or copy all three or four
 dependent files of an image. The jpg with the raw file behind and the xmp
 sidecar .jpg;%raw;.ufraw;.xmp  is the preset and works good.
 But when I want to add a sidecar file like  _MG_2611.CR2.pp3 
 (which is the file extension with the process parameters of RawTherapee
 for a CR2 canon raw) and use.jpg;%raw;.ufraw;.xmp;.CR2.pp3 
 the pp3 sidcar is only shown for the file, when I click on that image to
 start geeqie with it. It's also possible to rename all this files
 together,
 but it does not show  pp3 sidecars with the other images together in this
 directory. Any hint would be very welcome,I love geeqie -
 in my opinion you should promote more your panel-View (time-line) strg+j
 and have there the possibility to open a image with a
 double-click in the normal geeqie mode.
 Thanxx for the program and p l e a s e  c o n t i n u e!!
 
 --
 Nokia and ATT present the 2010 Calling All Innovators-North America
 contest
 Create new apps  games for the Nokia N8 for consumers in  U.S. and Canada
 $10 million total in prizes - $4M cash, 500 devices, nearly $6M in
 marketing
 Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
 http://p.sf.net/sfu/nokia-dev2dev
 ___
 Geeqie-devel mailing list
 Geeqie-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/geeqie-devel
 
 

Hi
It's been some time since you posted this message, but maybe you are still
looking for the answer.


If you open the Files tab on the Preferences page and set Disable File
Filtering you will get the functionality you are looking for.


Alternatively use the Add click box under the Files section to add a new
file type. It will default to the extension .new, so you will need to
click on it and change it to .pp3.

Colin Clark...


-- 
View this message in context: 
http://old.nabble.com/grouping-function-for-%22sidecar-extension%22-tp30116980p30475451.html
Sent from the Geeqie mailing list archive at Nabble.com.


--
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Symlink in the current SVN

[Colin Clark]

Marcin Zajączkowski wrote:
 On Sat, 18 Jul 2009 19:05:41 +0100
 Colin Clark ccl...@mcb.net wrote:

   
 Marcin Zajączkowski wrote:
 
 Hi,


 In geeqie 1.0beta1 Symlink command was moved File menu. In current
 SVN (1797) there is no Symlink there and in fact I wasn't able to
 find it somewhere else.
 Could you tell me how to call Symlink command and if it was removed
 accidentally (I had a problem to find the commit when it was
 removed)?
   

   
 Hi,

 If you right-click the mouse on the image or on a thumbnail, in the 
 Edit sub-menu is an entry for Symlink.
 

 Thanks for your reply, but unfortunately in my version (built from SVN
 rev. 1797) there is no that entry. In Edit sub-menu in the context
 menu for a picture or thumbnail there are only 3 entries for configured
 editors (GIMP, gqview and gThumb).
 I even deleted my geeqierc.xml, but without any result.


 Regards
 Marcin

   
Hi

Check the entries under Edit / Preferences / Configure Editors.

Do you have an entry for Symlinks? Perhaps it is marked as Hidden.

Colin Clark...

--
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Symlink in the current SVN

[Colin Clark]

Marcin Zajączkowski wrote:
 On Sat, 18 Jul 2009 19:54:43 +0100
 Colin Clark ccl...@mcb.net wrote:
 (...)
   
 In geeqie 1.0beta1 Symlink command was moved File menu. In current
 SVN (1797) there is no Symlink there and in fact I wasn't able to
 find it somewhere else.
 Could you tell me how to call Symlink command and if it was
 removed accidentally (I had a problem to find the commit when it
 was removed)?
   
   
 If you right-click the mouse on the image or on a thumbnail, in
 the Edit sub-menu is an entry for Symlink.
 
 
 Thanks for your reply, but unfortunately in my version (built from
 SVN rev. 1797) there is no that entry. In Edit sub-menu in the
 context menu for a picture or thumbnail there are only 3 entries
 for configured editors (GIMP, gqview and gThumb).
 I even deleted my geeqierc.xml, but without any result.
   

   
 Check the entries under Edit / Preferences / Configure Editors.

 Do you have an entry for Symlinks? Perhaps it is marked as Hidden.
 

 No, I have only desktop files to a few editor.
 Where is it keep in configuration? I could restart it (it seems to be
 not in geeqierc.xml).


 Regards
 Marcin
   
Hi

Unfortunately you have reached the limit of my knowledge of geeqie! 
Perhaps you may have to wait until Vladimir gets back from holiday.

I just do a standard autogen/make/sudo-make-install for geeqie. The 
symlink plugins are in the .../geeqie/trunk/plugins sub-directory and 
the installation process seems to copy them to 
/usr/local/share/geeqie/applications.

Perhaps you can figure something out from the configuration files. I am 
sorry I can't be of more help to you with this.

Colin Clark..


--
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Next Changes - libchamplain

[Colin Clark]

Hello Vladimir

Here is another patch for the GPS map software. It requires 
libchamplain-0.3, which can be downloaded from the libchamplain mainline 
repository. Run autogen.sh with --enable-gps CFLAGS=O0.


Unfortunately this is a more of a step backwards than forwards, as I get 
intermittent memory and exception errors that I cannot solve.


However this version has the Cycle Map and Osmarender in addition to the 
previous maps.


There are two additional functions that sort-of work. Most of my photos 
are not geocoded, so I coded some things to make things easy for me.


If I select a place-name on geonames.org and copy the lat/lon to the 
clipboard, middle-click on the geeqie map allows me to centre the map on 
that location.


I can then drag-and-drop thumbnails onto the map to geocode them. There 
are problems with both these functions, but they work well enough for 
me. I doubt other users of geeqie will need this facility, so there is 
little point in resolving these problems.




There is also an extra item on the search page to locate photos within a 
given range of a lat/lon position.  There are a couple of problems with 
this also.


Something with  math.h, which is the reason for the CFLAGS option.

And it is not possible to select all the files in the result of the 
search and show them on the geeqie map. This rather limits the 
usefulness of this function. But again, if this is of no use to other 
users of geeqie there is no point in solving problems that do not need 
to be solved.



This is just to let you know the current standing. Meanwhile I'll 
continue to bang my head against a brick wall with these memory and 
exception errors.


Colin Clark...

Index: configure.in
===
--- configure.in	(revision 1600)
+++ configure.in	(working copy)
@@ -328,6 +328,45 @@
 AC_SUBST(LDFLAGS)
 
 
+#  Libchamplain support - used for GPS map facility
+# --
+
+AC_ARG_ENABLE([gps],
+  AC_HELP_STRING([--enable-gps], [enable GPS map support]),
+[libgps=$enableval], [libgps=auto])
+
+if test x${libgps} == xyes; then
+  PKG_CHECK_MODULES(LIBCHAMPLAIN, [champlain-0.2 = 0.2.9],
+[
+  HAVE_LIBCHAMPLAIN=yes
+  AC_DEFINE(HAVE_LIBCHAMPLAIN, 1, [define to enable use of GPS maps])
+],
+[
+  HAVE_LIBCHAMPLAIN=no
+  AC_MSG_WARN([$LIBCHAMPLAIN_PKG_ERRORS])
+])
+else
+  HAVE_LIBCHAMPLAIN=disabled
+fi
+
+if test x${libgps} == xyes; then
+  PKG_CHECK_MODULES(LIBCHAMPLAIN_GTK, [champlain-gtk-0.2 = 0.2.9],
+[
+  HAVE_LIBCHAMPLAIN_GTK=yes
+  AC_DEFINE(HAVE_LIBCHAMPLAIN_GTK, 1, [define to enable use of GPS maps])
+],
+[
+  HAVE_LIBCHAMPLAIN_GTK=no
+  AC_MSG_WARN([$LIBCHAMPLAIN_GTK_PKG_ERRORS])
+])
+else
+  HAVE_LIBCHAMPLAIN_GTK=disabled
+fi
+	
+AM_CONDITIONAL(HAVE_LIBCHAMPLAIN_GTK, [test x$HAVE_LIBCHAMPLAIN_GTK = xyes])
+AC_SUBST(LIBCHAMPLAIN_GTK_CFLAGS)
+AC_SUBST(LIBCHAMPLAIN_GTK_LIBS)
+
 AH_TOP([
 /** @file config.h
  * autogenerated definition by autoheader.
@@ -398,7 +437,7 @@
   Gtk:   $GTK_CFLAGS
   Glib:  $GLIB_CFLAGS
   Thread:$GTHREAD_LIBS
-  Others:	 $LCMS_LIBS $EXIV2_LIBS
+  Others:	 $LCMS_LIBS $EXIV2_LIBS $LIBCHAMPLAIN_LIBS $LIBCHAMPLAIN_GTK_LIBS
 
 Localization:
   NLS support:   $USE_NLS
@@ -414,6 +453,8 @@
   LCMS:  $HAVE_LCMS
   Exiv2:	 $HAVE_EXIV2
   Lirc:  $HAVE_LIRC
+  Libchamplain:		$HAVE_LIBCHAMPLAIN
+  Libchamplain-gtk:	$HAVE_LIBCHAMPLAIN_GTK
 
 Documentation:
   Doxygen:   $DOXYGEN
Index: src/bar.c
===
--- src/bar.c	(revision 1600)
+++ src/bar.c	(working copy)
@@ -24,11 +24,13 @@
 
 #include ui_menu.h
 #include bar_comment.h
+#include bar_gps.h
 #include bar_keywords.h
 #include bar_exif.h
 #include bar_histogram.h
 #include histogram.h
 #include rcfile.h
+#include bar_gps.h
 
 typedef struct _KnownPanes KnownPanes;
 struct _KnownPanes
@@ -144,6 +146,21 @@
 /layout
 /gq;
 
+static const gchar default_config_gps[] = 
+gq
+layout id = '_current_'
+bar
+pane_gps id = 'gps' expanded = 'true' 
+map-source = 'Open Street Map - Mapnik'
+zoom-level = '11'
+latitude = '0.00'
+longitude = '0.00' 
+marker-icon = './src/icons/red-dot.png'
+/
+/bar
+/layout
+/gq;
+
 static const KnownPanes known_panes[] = {
 /* default sidebar */
 	{PANE_HISTOGRAM,	histogram,	N_(Histogram),	default_config_histogram},
@@ -155,6 +172,7 @@
 	{PANE_EXIF,		file_info,	N_(File info),	default_config_file_info},
 	{PANE_EXIF,		location,	N_(Location),		default_config_location},
 	{PANE_EXIF,		copyright,	N_(Copyright),	default_config_copyright},
+	{PANE_GPS,		gps,	N_(GPS Map),	default_config_gps},
 
 	{PANE_UNDEF,		NULL,		NULL,			NULL}
 };
Index: src/bar.h

Re: [Geeqie-devel] Next Changes - libchamplain

[Colin Clark]

Hello Vladimir


Please look at bar_comment.c

Replacing the text widget with libchamplain widget should be enough for the 
beginning. 


Vladimir

  
I have made an attempt to do something with libchamplain. The patch and 
files are attached.
Beware that I don't know the C language, nor the gnu make system, nor 
gnome/gtk, nor geeqie! In many places things will be wrong, and there 
are places where to get something to work I have simply made a 
quick-and-dirty hack. This is just to let you - and anyone else - know 
where I'm at so far with this.


You will need the libchamplain-0.2.9 and libchamplain-gtk-0.2.9 from 
http://projects.gnome.org/libchamplain/download. Run autogen.sh with 
--enable-gps. The .png file goes in trunk/src/icons. And of course you 
have to enable the gps map from the newly designed sidebar.


Right-click on the map shows the available maps. Middle-click cycles 
through the layers (unfortunately the thumbnail view only works if 
thumbnails are currently being shown). Multiple file selection is a 
total mess.


Unless someone else comes up with another solution, I'll just keep 
hacking away to try to improve things.


Colin Clark...

Index: configure.in
===
--- configure.in	(revision 1600)
+++ configure.in	(working copy)
@@ -328,6 +328,45 @@
 AC_SUBST(LDFLAGS)
 
 
+#  Libchamplain support - used for GPS map facility
+# --
+
+AC_ARG_ENABLE([gps],
+  AC_HELP_STRING([--enable-gps], [enable GPS map support]),
+[libgps=$enableval], [libgps=auto])
+
+if test x${libgps} == xyes; then
+  PKG_CHECK_MODULES(LIBCHAMPLAIN, [champlain-0.2 = 0.2.9],
+[
+  HAVE_LIBCHAMPLAIN=yes
+  AC_DEFINE(HAVE_LIBCHAMPLAIN, 1, [define to enable use of GPS maps])
+],
+[
+  HAVE_LIBCHAMPLAIN=no
+  AC_MSG_WARN([$LIBCHAMPLAIN_PKG_ERRORS])
+])
+else
+  HAVE_LIBCHAMPLAIN=disabled
+fi
+
+if test x${libgps} == xyes; then
+  PKG_CHECK_MODULES(LIBCHAMPLAIN_GTK, [champlain-gtk-0.2 = 0.2.9],
+[
+  HAVE_LIBCHAMPLAIN_GTK=yes
+  AC_DEFINE(HAVE_LIBCHAMPLAIN_GTK, 1, [define to enable use of GPS maps])
+],
+[
+  HAVE_LIBCHAMPLAIN_GTK=no
+  AC_MSG_WARN([$LIBCHAMPLAIN_GTK_PKG_ERRORS])
+])
+else
+  HAVE_LIBCHAMPLAIN_GTK=disabled
+fi
+	
+AM_CONDITIONAL(HAVE_LIBCHAMPLAIN_GTK, [test x$HAVE_LIBCHAMPLAIN_GTK = xyes])
+AC_SUBST(LIBCHAMPLAIN_GTK_CFLAGS)
+AC_SUBST(LIBCHAMPLAIN_GTK_LIBS)
+
 AH_TOP([
 /** @file config.h
  * autogenerated definition by autoheader.
@@ -398,7 +437,7 @@
   Gtk:   $GTK_CFLAGS
   Glib:  $GLIB_CFLAGS
   Thread:$GTHREAD_LIBS
-  Others:	 $LCMS_LIBS $EXIV2_LIBS
+  Others:	 $LCMS_LIBS $EXIV2_LIBS $LIBCHAMPLAIN_LIBS $LIBCHAMPLAIN_GTK_LIBS
 
 Localization:
   NLS support:   $USE_NLS
@@ -414,6 +453,8 @@
   LCMS:  $HAVE_LCMS
   Exiv2:	 $HAVE_EXIV2
   Lirc:  $HAVE_LIRC
+  Libchamplain:		$HAVE_LIBCHAMPLAIN
+  Libchamplain-gtk:	$HAVE_LIBCHAMPLAIN_GTK
 
 Documentation:
   Doxygen:   $DOXYGEN
Index: src/bar.c
===
--- src/bar.c	(revision 1600)
+++ src/bar.c	(working copy)
@@ -24,11 +24,13 @@
 
 #include ui_menu.h
 #include bar_comment.h
+#include bar_gps.h
 #include bar_keywords.h
 #include bar_exif.h
 #include bar_histogram.h
 #include histogram.h
 #include rcfile.h
+#include bar_gps.h
 
 typedef struct _KnownPanes KnownPanes;
 struct _KnownPanes
@@ -144,6 +146,21 @@
 /layout
 /gq;
 
+static const gchar default_config_gps[] = 
+gq
+layout id = '_current_'
+bar
+pane_gps id = 'gps' expanded = 'true' 
+map-source = 'Open Street Map - Mapnik'
+zoom-level = '11'
+latitude = '0.00'
+longitude = '0.00' 
+marker-icon = './src/icons/red-dot.png'
+/
+/bar
+/layout
+/gq;
+
 static const KnownPanes known_panes[] = {
 /* default sidebar */
 	{PANE_HISTOGRAM,	histogram,	N_(Histogram),	default_config_histogram},
@@ -155,6 +172,7 @@
 	{PANE_EXIF,		file_info,	N_(File info),	default_config_file_info},
 	{PANE_EXIF,		location,	N_(Location),		default_config_location},
 	{PANE_EXIF,		copyright,	N_(Copyright),	default_config_copyright},
+	{PANE_GPS,		gps,	N_(GPS Map),	default_config_gps},
 
 	{PANE_UNDEF,		NULL,		NULL,			NULL}
 };
Index: src/bar.h
===
--- src/bar.h	(revision 1600)
+++ src/bar.h	(working copy)
@@ -17,6 +17,7 @@
 typedef enum {
 	PANE_UNDEF = 0,
 	PANE_COMMENT,
+	PANE_GPS,
 	PANE_EXIF,
 	PANE_HISTOGRAM,
 	PANE_KEYWORDS
Index: src/main.c
===
--- src/main.c	(revision 1600)
+++ src/main.c	(working copy)
@@ -748,7 +748,8 @@
 	file_data_register_notify_func(collect_manager_notify_cb, NULL, NOTIFY_PRIORITY_LOW);
 
 	gtkrc_load();
-	gtk_init(argc, argv);
+//	gtk_init(argc

Re: [Geeqie-devel] Next Changes - libchamplain

[Colin Clark]

Hello Vladimir


 - add new panes
 - star rating
 - GPS pane (using http://blog.pierlux.com/projects/libchamplain/en/)
 I would prefer if these panes were contributed by somebody else, to 
 verify
 that the API is easy enough ;)

I'm glad you mentioned libchamplain, otherwise I probably would have not 
known about it. This is a really useful function. I use the external 
editor facility to run a shell script which passes a file's GPS 
parameters to a slightly modified version of the GTK demo file provided 
by Pierre-Luc Beaudoin. This pops up a window with markers showing the 
GPS locations of the photos - pretty basic, but really that's all I 
need. http://www.pierlux.com/

When you mention API, do you mean the libchamplain API - which is quite 
straightforward. Or are you referring to Geeqie? I took a look at the 
source, and it seems to me to be very complicated to add another pane to 
the sidebar. Is there a quick-and-easy way to add another pane?

Thanks

Colin Clark..


--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Toolbar - tooltips

[Colin Clark]

Hello Vladimir
Yes, this would be a correct implementation. It would be great if you could 
send a patch.


  

I have attached a patch file, hopefully the right format.

Colin Clark..

Index: editors.c
===
--- editors.c	(revision 1558)
+++ editors.c	(working copy)
@@ -264,6 +264,8 @@
 	
 	editor-hotkey = g_key_file_get_string(key_file, DESKTOP_GROUP, X-Geeqie-Hotkey, NULL);
 
+	editor-comment = g_key_file_get_string(key_file, DESKTOP_GROUP, Comment, NULL);
+
 	extensions = g_key_file_get_string(key_file, DESKTOP_GROUP, X-Geeqie-File-Extensions, NULL);
 	if (extensions)
 		editor-ext_list = filter_to_list(extensions);
Index: layout_util.c
===
--- layout_util.c	(revision 1558)
+++ layout_util.c	(working copy)
@@ -1678,7 +1678,7 @@
 		{
 		GList *path;
 		EditorDescription *editor = work-data;
-		GtkActionEntry entry = { editor-key, NULL, editor-name, editor-hotkey, NULL, G_CALLBACK(layout_menu_edit_cb) };
+		GtkActionEntry entry = { editor-key, NULL, editor-name, editor-hotkey, editor-comment, G_CALLBACK(layout_menu_edit_cb) };
 		
 		if (editor-icon  register_theme_icon_as_stock(editor-key, editor-icon))
 			{
Index: editors.h
===
--- editors.h	(revision 1558)
+++ editors.h	(working copy)
@@ -45,6 +45,7 @@
 	gchar *hotkey;
 	GList *ext_list;
 	gchar *file;
+	gchar *comment;		/* .desktop Comment key, used to show a tooltip */
 	EditorFlags flags;
 	gboolean hidden;
 };
--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Toolbar - tooltips

[Colin Clark]

Hi

I find it very useful to be able to put extra icons on the toolbar by 
putting entries to .desktop files in the toolbar section of geeqierc.xml.

But I tend to forget what my icons mean, so tooltips would also be useful.

I see in the Freedesktop.org standards that the Comment key of a desktop 
file can be used for tooltips [but it also says that The value should 
not be redundant with the values of |Name| and |GenericName|.. Does 
this mean that the Name key should be used for a tooltip unless there is 
an entry in the Comment key?]


I have no idea about this kind of programming, but I have got something 
to work by:

putting an extra field for tooltips in the _EditorDescription structure 
in editors.h
gchar *tooltip;

putting an extra line in editors.c, at about line 266, to read in the 
tooltip
editor-tooltip = g_key_file_get_string(key_file, DESKTOP_GROUP, 
Comment, NULL);

changing line 1681 of layout_util.c to load the tooltip.
GtkActionEntry entry = { editor-key, NULL, editor-name, 
editor-hotkey, editor-tooltip, G_CALLBACK(layout_menu_edit_cb) };



Am I going in the right direction, or have I completely missed an 
important aspect?

Thanks


Colin Clark...



--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] View-as-icons - slow response

[Colin Clark]

Hello Vladimir


 Then it must be the histogram map computation.

 There are several problems:
 - map computation can take a long time and is done in one piece
 - the relative priorities of image loading, drawing first and second pass,
   histogram and preloading next image are probably not completely right

 It should not happen when the histogram is not visible, but there may be 
 another bug.
   
Yes, the histogram was part of the problem. I edited image.c to take out 
a call to update histogram, and the problem was reduced.

However, the real problem lay elsewhere. In System/Preferences/Assistive 
Technologies I found that the Enable Assistive Technologies checkbox was 
clicked. I unset it and logged in again, and the problem was gone.

A Google search shows that this option was set by default in the Ubuntu 
8.10 update, and the problems it causes is known about anyway.

Colin Clark...

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] View-as-icons - slow response

[Colin Clark]

Hi

I'm using Geeqie with Ubuntu 8.10 on a standard desktop. I find I'm 
getting a slow response when looking at sub-directories with a large 
number of files.

If I leave the Files Pane in its default setting (with or without 
thumbnails), clicking on a file changes the image preview very quickly. 
If I click on a new file before the preview is completely rendered, the 
rendering of that image is aborted and rendering of the next image is 
started immediately.

However if I change the Files Pane setting to View As Icons, rendering 
of the preview is rather slower, and clicking on another file has no 
effect until rendering of the current image is completed. Not only that, 
but the rendering pauses towards the end of each image, and the final 
sections are rendered very slowly - the process taking perhaps 2 or 3 
seconds per image.

This effect first appears in svn 1394. The --enable-threads option makes 
no difference.

Sorry I can't be of more help.

Colin Clark...




--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Segmentation fault in image-load.c

[Colin Clark]

Hi

I have compiled geeqie from the latest svn. Geeqie runs ok until I move 
to a directory containing an image. I then get a segmentation fault at 
line 475 of image-load.c with il-data_mutex having value zero.

Does anyone have an idea of where the problem may be?

Thanks

Colin Clark...

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Segmentation fault: View as List

[Colin Clark]

Hi

I'm using svn 1074. If I select the file list option View as List and 
then try to create a new folder I get a segmentation fault at line 274 
of view_dir_tree.c.

The variable store doesn't contain anything sensible, so maybe the 
Model has not been set correctly.

Sorry, that's as far as my debugging capabilities take me. Perhaps 
someone can help?

Colin Clark..


-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel