Re: [PHP-DEV] E_USER_DEPRECATED

2008-07-21 Thread Lukas Kahwe Smith
On 18.07.2008, at 23:29, Lars Strojny wrote: Hello, I've create a patch to introduce E_USER_DEPRECATED for user level deprecation warnings. I think the purpose is fairly obvious and it corresponds with the rest of our user level errors (E_USER_ERROR, E_USER_WARNING). 5_3:

Re: [PHP-DEV] E_USER_DEPRECATED

2008-07-21 Thread Hannes Magnusson
On Mon, Jul 21, 2008 at 10:14, Lukas Kahwe Smith [EMAIL PROTECTED] wrote: On 18.07.2008, at 23:29, Lars Strojny wrote: Hello, I've create a patch to introduce E_USER_DEPRECATED for user level deprecation warnings. I think the purpose is fairly obvious and it corresponds with the rest of

[PHP-DEV] PHP 6 Bug Summary Report

2008-07-21 Thread internals
PHP 6 Bug Database summary - http://bugs.php.net/ Num Status Summary (65 total -- which includes 26 feature requests) ===[*General Issues]== 26771 Suspended register_tick_funtions crash under threaded webservers

[PHP-DEV] Patch for #41996

2008-07-21 Thread Martin Jansen
Attached is a patch plus test case for PHP_5_3's PDO_OCI that fixes bug #41996. Should cleanly apply to HEAD, too. Martin Index: oci_statement.c === RCS file: /repository/php-src/ext/pdo_oci/oci_statement.c,v retrieving revision 1.25

Re: [PHP-DEV] E_USER_DEPRECATED

2008-07-21 Thread Richard Quadling
2008/7/21 Hannes Magnusson [EMAIL PROTECTED] On Mon, Jul 21, 2008 at 10:14, Lukas Kahwe Smith [EMAIL PROTECTED] wrote: On 18.07.2008, at 23:29, Lars Strojny wrote: Hello, I've create a patch to introduce E_USER_DEPRECATED for user level deprecation warnings. I think the purpose is

Re: [PHP-DEV] New string functions: str_startswith() and str_endswith()

2008-07-21 Thread Stan Vassilev | FM
Hi, ucfirst() isn't solving a pain point either. But we use it all the time (I do at least). I'm particularly for begins/endswith() function as I do this all over my code and I'd appreciate the simplification and free extra performance. Regards, Stan Vassilev I agree that many existing

RE: [PHP-DEV] New string functions: str_startswith() and str_endswith()

2008-07-21 Thread Jared Williams
Surely substr_compare() does both begin end easily enough. Though the fact that it throws warnings is annoying. Jared -Original Message- From: Stan Vassilev | FM [mailto:[EMAIL PROTECTED] Sent: 21 July 2008 13:18 To: internals Subject: Re: [PHP-DEV] New string functions:

Re: [PHP-DEV] New string functions: str_startswith() and str_endswith()

2008-07-21 Thread Brian Moon
Stan Vassilev | FM wrote: I'm particularly for begins/endswith() function as I do this all over my code and I'd appreciate the simplification and free extra performance. I really don't mean to be rude here, but shorter and less typing !== performance gain. The PHP string functions are very

Re: [PHP-DEV] zend_inline_hash_function reimplementation

2008-07-21 Thread Lukas Kahwe Smith
On 21.07.2008, at 17:29, Michal Dziemianko wrote: Hello, I have looked into Zend/zend_hash.h and I guess it might be sped up a little. So far it uses D. Bernstein's hash which is quite fast, but I think it might be worth replacing it with MurmurHash. I have tried comparison of speed for

Re: [PHP-DEV] New string functions: str_startswith() and str_endswith()

2008-07-21 Thread Rasmus Lerdorf
Brian Moon wrote: Stan Vassilev | FM wrote: I'm particularly for begins/endswith() function as I do this all over my code and I'd appreciate the simplification and free extra performance. I really don't mean to be rude here, but shorter and less typing !== performance gain. The PHP string

[PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_3) / run-tests.php

2008-07-21 Thread Jani Taskinen
Please reply via the mailing list. You did weird ws changes in HEAD but not in 5.3 and vise-versa. That's VERY bad thing considering this script must be SAME for both branches. If you can't keep it in sync, don't touch it. Otherwise the bunnies get it.. Feel free to commit the help texts. I'm

Re: [PHP-DEV] Patch for #41996

2008-07-21 Thread Pierre Joye
hi Martin! On Mon, Jul 21, 2008 at 12:18 PM, Martin Jansen [EMAIL PROTECTED] wrote: Attached is a patch plus test case for PHP_5_3's PDO_OCI that fixes bug #41996. Should cleanly apply to HEAD, too. Applied to HEAD and 5.3, thanks for your work! Cheers, -- Pierre http://blog.thepimp.net |

Re: [PHP-DEV] Patch for #41996

2008-07-21 Thread Martin Jansen
On Mon, Jul 21, 2008 at 7:36 PM, Pierre Joye [EMAIL PROTECTED] wrote: On Mon, Jul 21, 2008 at 12:18 PM, Martin Jansen [EMAIL PROTECTED] wrote: Attached is a patch plus test case for PHP_5_3's PDO_OCI that fixes bug #41996. Should cleanly apply to HEAD, too. Applied to HEAD and 5.3, thanks for

RE: [PHP-DEV] zend_inline_hash_function reimplementation

2008-07-21 Thread Andi Gutmans
Hi Michal, Can you please send a link to the patch so we can review? I didn't get the attachment. Thanks, Andi -Original Message- From: Michal Dziemianko [mailto:[EMAIL PROTECTED] Sent: Monday, July 21, 2008 8:29 AM To: internals@lists.php.net Subject: [PHP-DEV]

Re: [PHP-DEV] Patch for #41996

2008-07-21 Thread Pierre Joye
hi! On Mon, Jul 21, 2008 at 7:52 PM, Martin Jansen [EMAIL PROTECTED] wrote: On Mon, Jul 21, 2008 at 7:36 PM, Pierre Joye [EMAIL PROTECTED] wrote: On Mon, Jul 21, 2008 at 12:18 PM, Martin Jansen [EMAIL PROTECTED] wrote: Attached is a patch plus test case for PHP_5_3's PDO_OCI that fixes bug

Re: [PHP-DEV] zend_inline_hash_function reimplementation

2008-07-21 Thread Scott MacVicar
Hi Andi, The patch is attached for 5_3. I've got some time allocated tomorrow to review all of Michal's patches that have been produced for the GSoC. I'll try to post some figures from real life apps. Scott Andi Gutmans wrote: Hi Michal, Can you please send a link to the patch so we can

[PHP-DEV] Rounding in PHP and floating point numbers in general

2008-07-21 Thread Christian Seiler
Hi, With this posting I'd like to make another try in resolving the rounding issues in PHP. This is basically in response to http://bugs.php.net/bug.php?id=42294 (bug #42294) where I added a comment last year. Since then I have read quite a bit on this subject so I feel that I should post an

RE: [PHP-DEV] zend_inline_hash_function reimplementation

2008-07-21 Thread Andi Gutmans
Thanks. Is there also a 64bit variant of this algorithm? That could deliver a substantial benefit. Andi -Original Message- From: Scott MacVicar [mailto:[EMAIL PROTECTED] Sent: Monday, July 21, 2008 11:15 AM To: Andi Gutmans Cc: Michal Dziemianko; internals@lists.php.net Subject:

Re: [PHP-DEV] New string functions: str_startswith() and str_endswith()

2008-07-21 Thread Stanislav Malyshev
Hi! It also isn't any shorter: if(str_endswith($path,'.php')) vs. if(substr($path,-4)=='.php') Doesn't substr allocate new string for .php? Then endswith can have one advantage of not requiring any new allocations. Not sure it's enough to add it, but a point here to consider. --

Re: [PHP-DEV] Re: parent:: forwarding

2008-07-21 Thread Lukas Kahwe Smith
Hello All, I had a chat with Etienne and Stas on IRC to try and figure out how to approach things. We decided that its best to go with only having parent:: be forwarding for alpha1. Depending on user feedback we might revisit the topic, but for now it seems that with this solution the

Re: [PHP-DEV] Re: towards a 5.3 release

2008-07-21 Thread Lukas Kahwe Smith
On 17.07.2008, at 20:03, Stanislav Malyshev wrote: Hi! Greg's argument seems sound to me. With the proposed change errors are less likely and more transparent in case they happen (for people using No, they won't be transparent at all. If you use Exception and forget to put use

Re: [PHP-DEV] New string functions: str_startswith() and str_endswith()

2008-07-21 Thread Paweł Stradomski
W liście Rasmus Lerdorf z dnia poniedziałek, 21 lipca 2008: It also isn't any shorter: if(str_endswith($path,'.php')) vs. if(substr($path,-4)=='.php') Only if comparing to a static string, but not for this case: if (substr($path, -strlen($extension)) == $extension) Readability

Re: [PHP-DEV] New string functions: str_startswith() and str_endswith()

2008-07-21 Thread Jani Taskinen
Paweł Stradomski kirjoitti: W liście Rasmus Lerdorf z dnia poniedziałek, 21 lipca 2008: It also isn't any shorter: if(str_endswith($path,'.php')) vs. if(substr($path,-4)=='.php') Only if comparing to a static string, but not for this case: if (substr($path, -strlen($extension))

Re: [PHP-DEV] Re: cvs: php-src(PHP_5_3) /ext/phar/tests rename_dir.phpt rmdir.phpt /ext/phar/tests/tar rename_dir.phpt rmdir.phpt /ext/phar/tests/zip rename_dir.phpt rmdir.phpt

2008-07-21 Thread Lukas Kahwe Smith
On 17.07.2008, at 04:17, Greg Beaver wrote: Dmitry Stogov wrote: dmitry Thu Jul 10 14:27:21 2008 UTC Added files: (Branch: PHP_5_3) /php-src/ext/phar/tests rename_dir.phpt rmdir.phpt /php-src/ ext/phar/tests/tar rename_dir.phpt rmdir.phpt /php-src/ext/phar/

Re: [PHP-DEV] Optimization for ..._MULTIPLY_LONG on more systems

2008-07-21 Thread Lukas Kahwe Smith
On 17.07.2008, at 16:20, Matt Wilmas wrote: Hi all, Replying to this OLD message about the ZEND_SIGNED_MULTIPLY_LONG() change... It's just a small thing, but it's been on the TODO for a while, so I attempted to correct the issue with my original patch that used long long type, which

Re: [PHP-DEV] New string functions: str_startswith() and str_endswith()

2008-07-21 Thread D. Dante Lorenso
Jani Taskinen wrote: Paweł Stradomski kirjoitti: W liście Rasmus Lerdorf z dnia poniedziałek, 21 lipca 2008: It also isn't any shorter: if(str_endswith($path,'.php')) vs. if(substr($path,-4)=='.php') Only if comparing to a static string, but not for this case: if (substr($path,

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/mysql php_mysql.c /ext/mysqli mysqli.c /ext/mysqlnd mysqlnd.c mysqlnd_palloc.c mysqlnd_ps.c mysqlnd_wireprotocol.c

2008-07-21 Thread Lukas Kahwe Smith
On 18.07.2008, at 10:11, Pierre Joye wrote: On Fri, Jul 18, 2008 at 9:27 AM, Ulf Wendel [EMAIL PROTECTED] wrote: Lester Caine schrieb: Ulf Wendel wrote: If mysqlnd turns out to be stable enough during the PHP 5.3 test phase, PHP 5.3+ may use mysqlnd as a default. There is no need to

Re: [PHP-DEV] zend_inline_hash_function reimplementation

2008-07-21 Thread Stanislav Malyshev
Hi! I understand this patch has potential portability issues for architectures that won't be able to read int's unaligned. Maybe we could keep both of them and do some configure test to see if it works fine, if not - use the old one? Also I understand that this function returns uint while

Re: [PHP-DEV] [PATCH] Allow use($var..) statement ubiquitously

2008-07-21 Thread Lukas Kahwe Smith
On 18.07.2008, at 01:23, Moriyoshi Koizumi wrote: Hi, Attached are the patches that allow the use statement that was introduced with closures to appear within every function statement except method definitions. I think this feature is a good addition because it resolves inconsistency

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/mysql php_mysql.c /ext/mysqli mysqli.c /ext/mysqlnd mysqlnd.c mysqlnd_palloc.c mysqlnd_ps.c mysqlnd_wireprotocol.c

2008-07-21 Thread Pierre Joye
Hi Lukas, On Mon, Jul 21, 2008 at 10:52 PM, Lukas Kahwe Smith [EMAIL PROTECTED] wrote: It seems to me like in 99% of the cases on linux the initial install of PHP will include PDO and MySQL (ok lets say 90% for MySQL and 99% for PDO) intentionally anyways. For the rest they will be hand

Re: [PHP-DEV] New string functions: str_startswith() and str_endswith()

2008-07-21 Thread Johannes Schlüter
On Mon, 2008-07-21 at 22:06 +0200, Paweł Stradomski wrote: W liście Rasmus Lerdorf z dnia poniedziałek, 21 lipca 2008: It also isn't any shorter: if(str_endswith($path,'.php')) vs. if(substr($path,-4)=='.php') Only if comparing to a static string, but not for this case:

Re: [PHP-DEV] zend_inline_hash_function reimplementation

2008-07-21 Thread Scott MacVicar
There is an aligned version of the algorithm available but its slower, there is also a 64-bit version in the works. I emailed the author about its progress to check. At the moment adding both looks the way forward, i'll benchmark a PPC version of the algorithm shortly. Scott On 21 Jul

Re: [PHP-DEV] Re: parent:: forwarding

2008-07-21 Thread Etienne Kneuss
Hello, On Mon, Jul 21, 2008 at 9:48 PM, Lukas Kahwe Smith [EMAIL PROTECTED] wrote: Etienne will handle applying the patch and doing at least a base line summary of the decision process, so that we have this as a reference if we ever revisit the topic. I can't apply the patch, as it requires

Re: [PHP-DEV] Re: parent:: forwarding

2008-07-21 Thread Stanislav Malyshev
Hi! I can't apply the patch, as it requires ZE2 karma which I don't have. I'll write a RFC for it though. Please add there a link to the newest patch, since there was a lot of variations around... -- Stanislav Malyshev, Zend Software Architect [EMAIL PROTECTED] http://www.zend.com/

[PHP-DEV] Modify language grammar to allow trailing commas in function/method calls

2008-07-21 Thread Evan Priestley
This was floated in 2003 but had weak advocation and didn't seem to come to a decisive resolution: http://marc.info/?l=php-internalsm=106685833011253w=2 Basically, the proposal is to modify the grammar to allow trailing commas in function and method calls, so this becomes a