Re: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-27 Thread Jürgen Spitzmüller
John McCabe-Dansted wrote: Well, I in the attached (very draft) patch I have cut and pasted feature (3) from GuiSpellChecker.cpp. It seems reasonable that the user install spellchecker modules for languages they want permanently in the Langauges menu. However converse it not true, as a user

Re: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-27 Thread Jürgen Spitzmüller
John McCabe-Dansted wrote: > Well, I in the attached (very draft) patch I have cut and pasted > feature (3) from GuiSpellChecker.cpp. It seems reasonable that the > user install spellchecker modules for languages they want permanently > in the Langauges menu. However converse it not true, as a

Re: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-26 Thread Guenter Milde
On 2010-02-25, Jürgen Spitzmüller wrote: Jean-Marc Lasgouttes wrote: Thanks for the work on the language menu, while there is still room for improvement, I think it is going in the right direction. in the rather usual case when only one language is used ... ... This new menu entry is a

Re: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-26 Thread Jean-Marc Lasgouttes
Guenter Milde mi...@users.berlios.de writes: Actually, I'd prefer to move the language setting out of the character dialogue completely. Language is an important semantic feature, while all other settings in this dialogue concern presentational markup. It makes sense. JMarc

Re: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-26 Thread Abdelrazak Younes
On 02/26/2010 12:05 PM, Jean-Marc Lasgouttes wrote: Guenter Mildemi...@users.berlios.de writes: Actually, I'd prefer to move the language setting out of the character dialogue completely. Language is an important semantic feature, while all other settings in this dialogue concern

Re: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-26 Thread John McCabe-Dansted
On Thu, Feb 25, 2010 at 9:24 PM, Jürgen Spitzmüller sp...@lyx.org wrote: snip 3) On Linux/Ubuntu Languages that the user has installed language-packs for (or maybe aspell/hunspell packs) 4) Languages that the user has configured input methods for. In my case this would mean that I always have

Re: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-26 Thread Guenter Milde
On 2010-02-25, Jürgen Spitzmüller wrote: > Jean-Marc Lasgouttes wrote: Thanks for the work on the language menu, while there is still room for improvement, I think it is going in the right direction. >> in the rather usual case when only one language is used ... ... >> This new menu entry is a

Re: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-26 Thread Jean-Marc Lasgouttes
Guenter Milde writes: > Actually, I'd prefer to move the language setting out of the character > dialogue completely. Language is an important semantic feature, while all > other settings in this dialogue concern presentational markup. It makes sense. JMarc

Re: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-26 Thread Abdelrazak Younes
On 02/26/2010 12:05 PM, Jean-Marc Lasgouttes wrote: Guenter Milde writes: Actually, I'd prefer to move the language setting out of the character dialogue completely. Language is an important semantic feature, while all other settings in this dialogue concern

Re: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-26 Thread John McCabe-Dansted
On Thu, Feb 25, 2010 at 9:24 PM, Jürgen Spitzmüller wrote: >> 3) On Linux/Ubuntu Languages that the user has installed >> language-packs for (or maybe aspell/hunspell packs) >> 4) Languages that the user has configured input methods for. >> >> In my case this would mean that I

Re: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-25 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller sp...@lyx.org writes: A couple of questions: 1) Is using _(() enough to make the code sufficiently multilingual? I doubt it. But you can try yourself. Just try different LANG environments. BTW, I just tried this language selector thing, only to find out that, in the rather

Re: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-25 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: BTW, I just tried this language selector thing, only to find out that, in the rather usual case when only one language is used, it adds an ugly Language... entry that just opens the character dialog. I think it would be better the gray out of remove the entry in

Re: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-25 Thread Jürgen Spitzmüller
John McCabe-Dansted wrote: In the worst case we could enumerate the options. Heck I'd even find 1: English 2: English (UK) 3: English (USA) 4: English (Canada) More meaningful than _English E_nglish (UK) En_glish (USA) Eng_lish (Canada) I don't. Remember these are _menu_ accelerators.

Re: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-25 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: I think we can do that better with Qt's help. I'll have a look. try revision 33566. Jürgen

Re: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-25 Thread John McCabe-Dansted
On Thu, Feb 25, 2010 at 8:34 PM, Jürgen Spitzmüller sp...@lyx.org wrote: Jean-Marc Lasgouttes wrote: BTW, I just tried this language selector thing, only to find out that, in the rather usual case when only one language is used, it adds an ugly Language... entry that just opens the character

Re: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-25 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller sp...@lyx.org writes: Jean-Marc Lasgouttes wrote: BTW, I just tried this language selector thing, only to find out that, in the rather usual case when only one language is used, it adds an ugly Language... entry that just opens the character dialog. I think it would be

Re: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-25 Thread John McCabe-Dansted
On Thu, Feb 25, 2010 at 8:56 PM, Jürgen Spitzmüller sp...@lyx.org wrote: Jürgen Spitzmüller wrote: I think we can do that better with Qt's help. I'll have a look. try revision 33566. Looks good. I notice that you've added an accelerator to More Languages too :). Malay and More Languages

Re: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-25 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: Thanks for changing that. Another solution could be to have at top-level the language that are used in the buffer and a submenu with all the other languages. This would allow easy selection of a still unused language too. Yes, but we have a lot of languages. And

Re: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-25 Thread Jürgen Spitzmüller
John McCabe-Dansted wrote: Perhaps the Languages menu should always have certain important languages available, including for example 1) The LyX Interface Language 2) The System default language 3) On Linux/Ubuntu Languages that the user has installed language-packs for (or maybe

RE: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-25 Thread Jürgen Spitzmüller
Vincent van Ravesteijn - TNW wrote: Consider this a bug.. I understood ;-) I already did.. OK? Yes. It's in. Jürgen

RE: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-25 Thread Vincent van Ravesteijn - TNW
And in the less usual case in which only languages are used other than the document language, the document language is not in the list (which I would expect of course). Consider this a bug.. I already did.. OK? Yes. Jürgen Vincent

Re: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-25 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: >> A couple of questions: >> 1) Is using _("(") enough to make the code sufficiently multilingual? > > I doubt it. But you can try yourself. Just try different LANG environments. BTW, I just tried this language selector thing, only to find out that, in

Re: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-25 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > BTW, I just tried this language selector thing, only to find out that, > in the rather usual case when only one language is used, it adds an ugly > Language... entry that just opens the character dialog. I think it would > be better the gray out of remove the entry

Re: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-25 Thread Jürgen Spitzmüller
John McCabe-Dansted wrote: > In the worst case we could enumerate the options. Heck I'd even find > 1: English > 2: English (UK) > 3: English (USA) > 4: English (Canada) > More meaningful than > _English > E_nglish (UK) > En_glish (USA) > Eng_lish (Canada) I don't. Remember these are _menu_

Re: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-25 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > I think we can do that better with Qt's help. I'll have a look. try revision 33566. Jürgen

Re: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-25 Thread John McCabe-Dansted
On Thu, Feb 25, 2010 at 8:34 PM, Jürgen Spitzmüller wrote: > Jean-Marc Lasgouttes wrote: > >> BTW, I just tried this language selector thing, only to find out that, >> in the rather usual case when only one language is used, it adds an ugly >> Language... entry that just opens the

Re: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-25 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: > Jean-Marc Lasgouttes wrote: > >> BTW, I just tried this language selector thing, only to find out that, >> in the rather usual case when only one language is used, it adds an ugly >> Language... entry that just opens the character dialog. I think it

Re: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-25 Thread John McCabe-Dansted
On Thu, Feb 25, 2010 at 8:56 PM, Jürgen Spitzmüller wrote: > Jürgen Spitzmüller wrote: > >> I think we can do that better with Qt's help. I'll have a look. > > try revision 33566. Looks good. I notice that you've added an accelerator to "More Languages" too :). "Malay" and "More

Re: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-25 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > Thanks for changing that. Another solution could be to have at top-level > the language that are used in the buffer and a submenu with all the > other languages. This would allow easy selection of a still unused > language too. Yes, but we have a lot of languages.

Re: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-25 Thread Jürgen Spitzmüller
John McCabe-Dansted wrote: > Perhaps the Languages menu should always have certain important > languages available, including for example > 1) The LyX Interface Language > 2) The System default language > 3) On Linux/Ubuntu Languages that the user has installed > language-packs for (or maybe

RE: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-25 Thread Jürgen Spitzmüller
Vincent van Ravesteijn - TNW wrote: >>Consider this a bug.. I understood ;-) > I already did.. > >>OK? > > Yes. It's in. Jürgen

RE: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-25 Thread Vincent van Ravesteijn - TNW
>> And in the less usual case in which only languages are used other than >> the document language, the document language is not in the list (which >> I would expect of course). >Consider this a bug.. I already did.. >OK? Yes. >Jürgen Vincent

Re: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-24 Thread John McCabe-Dansted
On Wed, Feb 24, 2010 at 10:08 PM, LyX Ticket Tracker t...@lyx.org wrote: #6558: Edit-Language lacks keyboard shortcuts. snip  I implemented a simpler solution (ignoring the casing) at r33555. snip Ticket URL: http://www.lyx.org/trac/ticket/6558#comment:2 OK, but adding a couple of lines

Re: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-24 Thread Jürgen Spitzmüller
John McCabe-Dansted wrote: OK, but adding a couple of lines of code makes this much nicer for English users. But we do not only have English users. I'm not even sure my current approach is suitable for all localizations. I think Japanese uses roman accelerators, but the strings are

Re: #6558: Edit-Language lacks keyboard shortcuts.

2010-02-24 Thread John McCabe-Dansted
On Thu, Feb 25, 2010 at 6:07 AM, Jürgen Spitzmüller sp...@lyx.org wrote: OK, but adding a couple of lines of code makes this much nicer for English users. But we do not only have English users. Right, but English is the language I can test with confidence. I'm not even sure my current

Re: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-24 Thread John McCabe-Dansted
On Wed, Feb 24, 2010 at 10:08 PM, LyX Ticket Tracker <t...@lyx.org> wrote: > #6558: Edit->Language lacks keyboard shortcuts. >  I implemented a simpler solution (ignoring the casing) at r33555. > Ticket URL: <http://www.lyx.org/trac/ticket/6558#comment:2> OK, but

Re: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-24 Thread Jürgen Spitzmüller
John McCabe-Dansted wrote: > OK, but adding a couple of lines of code makes this much nicer for > English users. But we do not only have English users. I'm not even sure my current approach is suitable for all localizations. I think Japanese uses roman accelerators, but the strings are

Re: #6558: Edit->Language lacks keyboard shortcuts.

2010-02-24 Thread John McCabe-Dansted
On Thu, Feb 25, 2010 at 6:07 AM, Jürgen Spitzmüller wrote: >> OK, but adding a couple of lines of code makes this much nicer for >> English users. > > But we do not only have English users. Right, but English is the language I can test with confidence. > I'm not even sure my