Re: a simple formatter

2008-02-07 Thread Amos Jeffries
Tested. I have made a (small) file of the structures I've noticed past formatting errors on. With a manual fix-up to what I think it should look like in readable C++ under the published squid formatting description. The output of your script does this: .. It is the

Re: a simple formatter

2008-02-07 Thread Amos Jeffries
On Wed, 2008-02-06 at 21:26 +0200, Tsantilas Christos wrote: Do we need something like that? Any comments/suggestions? Any testers? I believe we do and I appreciate you working on it! Please try to fix the remaining problems Amos pointed out. Also, can you apply it to the entire Squid tree,

Re: squid-3.HEAD IPAddress leak

2008-02-07 Thread Amos Jeffries
On Fri, 2008-02-08 at 11:46 +1300, Amos Jeffries wrote: The basics: addrinfo* extends the neutral sockaddr* type ( union { sockaddr_in, sockaddr_in6, sockaddr_storage} ) while adding the size values and moving the flags and protocol details. Hi Amos, I understand that we need

Re: a simple formatter

2008-02-07 Thread Amos Jeffries
On Fri, 2008-02-08 at 14:31 +1300, Amos Jeffries wrote: On Wed, 2008-02-06 at 21:26 +0200, Tsantilas Christos wrote: Do we need something like that? Any comments/suggestions? Any testers? I believe we do and I appreciate you working on it! Please try to fix the remaining problems Amos

Re: squid-3.HEAD IPAddress leak

2008-02-07 Thread Amos Jeffries
On Fri, Feb 08, 2008, Amos Jeffries wrote: sockaddr_storage (as Husni uses, and Adrian mentioned) was created to provide a better way of using sockaddr* so the sockaddr_in and sockaddr_in6 bits could be read-written easily. But the big/litte endian problems between OS screwed up

Re: squid-3.HEAD IPAddress leak

2008-02-08 Thread Amos Jeffries
Alex Rousskov wrote: On Fri, 2008-02-08 at 15:52 +1300, Amos Jeffries wrote: The second; sockaddr_storage (as Husni uses, and Adrian mentioned) was created to provide a better way of using sockaddr* so the sockaddr_in and sockaddr_in6 bits could be read-written easily. But the big/litte

Re: a simple formatter

2008-02-08 Thread Amos Jeffries
Tsantilas Christos wrote: On Fri, 2008-02-08 at 16:10 +1300, Amos Jeffries wrote: The same() operations used in those tests may be different from a same_MD5s() operation. Try inserting an empty line in a middle of a function and recompile. You will get a different MD5. Stripping the executable

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-08 Thread Amos Jeffries
Henrik Nordström wrote: sön 2008-02-03 klockan 19:37 +1300 skrev Amos Jeffries: Changing the MD5 affects both private and public (GET, HEAD, etc I assume?) store MD5 functions. You don't need to worry about the private keys. The primary input to private keys is the runtime unique object id

Re: squid-3.HEAD IPAddress leak

2008-02-08 Thread Amos Jeffries
Amos Jeffries wrote: Alex Rousskov wrote: On Fri, 2008-02-08 at 15:52 +1300, Amos Jeffries wrote: The second; sockaddr_storage (as Husni uses, and Adrian mentioned) was created to provide a better way of using sockaddr* so the sockaddr_in and sockaddr_in6 bits could be read-written easily

Re: two xasserts in squid3

2008-02-10 Thread Amos Jeffries
Hi all, There is something which confuse me. The xassert function implemented in squid3 in two places, in the file src/debug.cc and in the lib/assert.c file. Also the assert macro declared in src/Debug.h file and in the include/assert.h file. Is there any reason for these two

Re: cvs commit: squid3/src cf.data.pre

2008-02-10 Thread Amos Jeffries
hno 2008/02/08 04:20:28 MST Modified files: src cf.data.pre Log: Restrict the cgi-bin refresh pattern to just */cgi-bin/* Revision ChangesPath 1.500 +1 -1 squid3/src/cf.data.pre That would be a violation of the RFC would it not? The

Re: two xasserts in squid3

2008-02-10 Thread Amos Jeffries
On Mon, 2008-02-11 at 10:15 +1300, Amos Jeffries wrote: What I'm seeing with the auto-docs work is that a lot of header files include squid.h or protos.h for one or two simple things. That file brings with it a host of type-dependencies, directly or indirectly that clutter up the whole

Re: two xasserts in squid3

2008-02-10 Thread Amos Jeffries
On Mon, Feb 11, 2008, Amos Jeffries wrote: FWIW the keyword 'typedef' is as evil in C++ as #define, and only 'goto' is worse (and completely unnecessary since functional-C deprecated pascal). Goto is fine. You just need to know how and when to use it. My use of goto in new Squid C code I

Re: two xasserts in squid3

2008-02-10 Thread Amos Jeffries
On Mon, Feb 11, 2008, Amos Jeffries wrote: I end up with -one- exit location in the function and I don't have to bum around using extra functions or massively nested conditional constructs to achieve it. In fact, I've used goto in a few places to tidy up the code.. If you need to use

Re: two xasserts in squid3

2008-02-11 Thread Amos Jeffries
On Tue, 2008-02-12 at 10:37 +1300, Amos Jeffries wrote: When we get a better VCS, we should discuss moving include/ and lib/ stuff into src/ with the exception of 3rd party code. This would avoid problems created by that artificial boundary. What I have been mulling over after seeing code

Re: two xasserts in squid3

2008-02-11 Thread Amos Jeffries
On Mon, 2008-02-11 at 10:15 +1300, Amos Jeffries wrote: I think a better approach to this would be: 1) do we actually need it anyway? Yes, we need a common assert-like macro. 2) where is it supposed to be defined? IMO: include/xassert.h if xassert is used outside of src/ src

Re: two xasserts in squid3

2008-02-11 Thread Amos Jeffries
On Sun, 2008-02-10 at 20:51 +0200, Tsantilas Christos wrote: Maybe it was better if the files lib/assert.c and include/assert.h removed and the assert macro defined in squid.h file like squid2.6 does... It looks like Array, MemPool, and splay files are using assert outside of src/ so you

Re: two xasserts in squid3

2008-02-11 Thread Amos Jeffries
Alex Rousskov wrote: On Sun, 2008-02-10 at 20:51 +0200, Tsantilas Christos wrote: Maybe it was better if the files lib/assert.c and include/assert.h removed and the assert macro defined in squid.h file like squid2.6 does... It looks like Array, MemPool, and splay files are using assert

Re: HEAD squid3/src SquidString.h,1.15,1.16 String.cci,1.11,1.12

2008-02-10 Thread Amos Jeffries
Oh ^%^%$!! Whats the Best way to undo this? Amos Amos Jeffries wrote: Update of cvs.devel.squid-cache.org:/cvsroot/squid/squid3/src Modified Files: SquidString.h String.cci Log Message: Several String fixes. - Add two missing includes when configured --disable-inline - SegFault when

Re: HEAD squid3/src SquidString.h,1.15,1.16 String.cci,1.11,1.12

2008-02-10 Thread Amos Jeffries
Adrian Chadd wrote: On Mon, Feb 11, 2008, Amos Jeffries wrote: Oh ^%^%$!! Whats the Best way to undo this? Commit a diff which reverts it? :) This was to cvs.devel.squid-cache.org HEAD. Same way the Arthur (I think) buggered up HEAD earlier. Is it Best to do a reverse patch in that case

Re: two xasserts in squid3

2008-02-11 Thread Amos Jeffries
On Tue, 2008-02-12 at 11:10 +1300, Amos Jeffries wrote: On Mon, 2008-02-11 at 09:33 +1100, Robert Collins wrote: One of the things I'd most love to see is the modularisation completed - complete deletion of protos.h, structs.h, typedefs.h. Yes, of course. That would be the focus

Re: squid-3.HEAD IPAddress leak

2008-02-12 Thread Amos Jeffries
On Fri, 2008-02-08 at 12:14 +0900, Adrian Chadd wrote: Together they make a pretty tree. But every used piece is eseentially another new, memset, free. Ah, and here you will have problems. The members of that struct should probably be malloc, free, and not new/delete. You're using

Re: meetup occuring in London

2008-02-12 Thread Amos Jeffries
Adrian Chadd wrote: (Only replying to squid-dev) On Wed, Feb 13, 2008, Robert Collins wrote: Some of the squid developers are going to get together in London during the weekend of the 1st and 2nd of March. We're still putting together final details and so on. We'll be talking about much of

Re: HEAD squid3/src SquidString.h,1.15,1.16 String.cci,1.11,1.12

2008-02-12 Thread Amos Jeffries
Amos Jeffries wrote: Adrian Chadd wrote: On Mon, Feb 11, 2008, Amos Jeffries wrote: Oh ^%^%$!! Whats the Best way to undo this? Commit a diff which reverts it? :) This was to cvs.devel.squid-cache.org HEAD. Same way the Arthur (I think) buggered up HEAD earlier. Is it Best to do

Re: squid3 future directory structure

2008-02-12 Thread Amos Jeffries
Alex Rousskov wrote: On Tue, 2008-02-12 at 11:19 +1300, Amos Jeffries wrote: On Tue, 2008-02-12 at 10:37 +1300, Amos Jeffries wrote: When we get a better VCS, we should discuss moving include/ and lib/ stuff into src/ with the exception of 3rd party code. This would avoid problems created

Re: squid3 future directory structure

2008-02-13 Thread Amos Jeffries
Hello, I have created the following wiki page to see if we can agree on how to define future subdirectories and what to move there. This can be a Squid 3.2 feature, I think. http://wiki.squid-cache.org/Features/SourceLayout Amos, do you want to lead this activity? I have already

3.1 steps forward

2008-02-13 Thread Amos Jeffries
I'm just checking 3.1 progress maps now that the current big patches are in. Adrian: http://wiki.squid-cache.org/Features/LogDaemon Can we add a timeline on this now please? If it requires a push THN will provide a little funding to get it for our use in 3.1. Amos

Re: squid3 future directory structure

2008-02-13 Thread Amos Jeffries
On Thu, 2008-02-14 at 11:45 +1300, Amos Jeffries wrote: I'd prefer the filenames matching the (single!) class defined inside. Standard C++ practice for some. Sure. That means some need a Foo/FooX others just Foo/XYZ. But we can use namespaces and rename classes as needed to avoid long

Re: 3.1 steps forward

2008-02-14 Thread Amos Jeffries
Adrian Chadd wrote: On Thu, Feb 14, 2008, Amos Jeffries wrote: I'm just checking 3.1 progress maps now that the current big patches are in. Adrian: http://wiki.squid-cache.org/Features/LogDaemon Can we add a timeline on this now please? If it requires a push THN will provide a little

Re: eCAP: expose Squid or link with eCAP lib?

2008-02-14 Thread Amos Jeffries
Hello, The Squid eCAP branch already has limited support for loadable modules. I have also written some eCAP-specific code, but I am not satisfied with its design yet. This may be the last opportunity to change things without rewriting a lot of code so I would love to get your feedback

Re: squid3 future directory structure

2008-02-14 Thread Amos Jeffries
On Thu, 2008-02-14 at 11:45 +1300, Amos Jeffries wrote: http://wiki.squid-cache.org/Features/SourceLayout Added ICMP to your list of components. It's a clear-cut one now. Thank you. Can you lead this activity? We need somebody who will drive the discussion and oversee actual changes

Re: eCAP: expose Squid or link with eCAP lib?

2008-02-14 Thread Amos Jeffries
On Fri, 2008-02-15 at 12:15 +1300, Amos Jeffries wrote: I imagine the basic first-signup users of eCAP will be wanting to perform content-filters on pages as they arrive. That only needs a read-only buffer of the page data and a hook to allow/deny the transaction. FWIW, some of the users

Re: 3.1 steps forward

2008-02-15 Thread Amos Jeffries
Adrian Chadd wrote: On Fri, Feb 15, 2008, Amos Jeffries wrote: Sorry if I was obtuse. I meant that you are the expert on this one. Are you able to re-locate that mysterious branch and estimate when you will have time to sync and push it to HEAD? squid3_logdaemon have you fixed the AddrInfo

Re: eCAP: expose Squid or link with eCAP lib?

2008-02-15 Thread Amos Jeffries
Tsantilas Christos wrote: Hi, Alex Rousskov wrote: 1) Expose Squid internals: Publish/install Squid headers and libraries to give direct access to Squid resources. This approach will most likely require installing pretty much all headers because the module may

Re: HEAD squid3/errors/Armenian ERR_ESI,1.1,1.2 ERR_ICAP_FAILURE,1.1,1.2

2008-02-17 Thread Amos Jeffries
Robert Collins wrote: On Sat, 2008-02-16 at 18:14 -0700, Alex Rousskov wrote: On Fri, 2008-02-15 at 14:05 +, Arthur Tumanyan wrote: Update of cvs.devel.squid-cache.org:/cvsroot/squid/squid3/errors/Armenian Modified Files: ERR_ESI ERR_ICAP_FAILURE Log Message: Another SourceForge HEAD

Re: Time for squid 3.0 STABLE2 ?

2008-02-19 Thread Amos Jeffries
Hi, What about to release squid 3.0 STABLE2 ? I think that there are many patches already applied to HEAD-3 that could be applied also to SQUID_3_0. If needed, I could try to contribute in the back port of some patch. I've been thinking along those lines myself for a while. Its a

Re: How to configure squid complatly anonymous (SSH tunnel)?

2008-02-20 Thread Amos Jeffries
globalvpn2008 wrote: Hello, I have installed squid manually , it works fine, I can able to brows internet via SSH tunnel . but I have a problem : when I check my IP via this SSH tunnel with http://ip2location.com and also http://ipchicken.com it show my VPS ip and also show my VPS location,

Re: Time for squid 3.0 STABLE2 ?

2008-02-20 Thread Amos Jeffries
Hi Amos, At 00:04 20/02/2008, Amos Jeffries wrote: Hi, What about to release squid 3.0 STABLE2 ? I think that there are many patches already applied to HEAD-3 that could be applied also to SQUID_3_0. If needed, I could try to contribute in the back port of some patch. I've

Re: Time for squid 3.0 STABLE2 ?

2008-02-20 Thread Amos Jeffries
On Wed, 2008-02-20 at 12:04 +1300, Amos Jeffries wrote: What about to release squid 3.0 STABLE2 ? I think that there are many patches already applied to HEAD-3 that could be applied also to SQUID_3_0. If needed, I could try to contribute in the back port of some patch. I've been

Re: Time for squid 3.0 STABLE2 ?

2008-02-21 Thread Amos Jeffries
Alex Rousskov wrote: On Thu, 2008-02-21 at 14:46 +1300, Amos Jeffries wrote: - include directive. Being a very minor feature, and existing in 2.x. I'm undecide if it should be back-ported early to ease future upgrades from 2.6/2.7. I would be happy to see it backported to 3.0. It does

Re: Time for squid 3.0 STABLE2 ?

2008-02-22 Thread Amos Jeffries
Henrik Nordström wrote: ons 2008-02-20 klockan 12:04 +1300 skrev Amos Jeffries: Henrik: It was suggested I ask you about how-to for editing the changesets. Seeing as I have stood up for 3.1 maintainer, I think I might get have some practice on 3.0. There is no editing, just classification

Re: Time for squid 3.0 STABLE2 ?

2008-02-23 Thread Amos Jeffries
Amos Jeffries wrote: Henrik Nordström wrote: ons 2008-02-20 klockan 12:04 +1300 skrev Amos Jeffries: Henrik: It was suggested I ask you about how-to for editing the changesets. Seeing as I have stood up for 3.1 maintainer, I think I might get have some practice on 3.0

Re: 3.0.STABLE2 patch candidates

2008-02-23 Thread Amos Jeffries
Guido Serassio wrote: Hi Henrik, At 14:35 23/02/2008, Henrik Nordström wrote: The first pass of grouping and classifying the 3 HEAD changesets since 3.0 branches has now been completed by me and Amos. Please go to http://www.squid-cache.org/Versions/v3/HEAD/changesets/merge.html and inspect

Re: 3.0.STABLE2 patch candidates

2008-02-23 Thread Amos Jeffries
Henrik Nordström wrote: lör 2008-02-23 klockan 18:35 +0100 skrev Guido Serassio: Hi Henrik, At 14:35 23/02/2008, Henrik Nordström wrote: The first pass of grouping and classifying the 3 HEAD changesets since 3.0 branches has now been completed by me and Amos. Please go to

Re: 3.0.STABLE2 patch candidates

2008-02-24 Thread Amos Jeffries
Henrik Nordström wrote: The first pass of grouping and classifying the 3 HEAD changesets since 3.0 branches has now been completed by me and Amos. Please go to http://www.squid-cache.org/Versions/v3/HEAD/changesets/merge.html and inspect the list of patches to merge and not merge and give your

Re: Time for squid 3.0 STABLE2 ?

2008-02-24 Thread Amos Jeffries
Hi Amos, At 12:33 23/02/2008, Amos Jeffries wrote: Some weirdness: The following patches to 3.0 appear not to have been applied to 3-HEAD: 11456 Windows Port: call fdc_open() when opening IPC sockets. If I'm not wrong, this should not be needed in HEAD-3 (while is needed in SQUID_3_0

Re: 3.0.STABLE2 patch candidates

2008-02-25 Thread Amos Jeffries
On Sat, 2008-02-23 at 14:35 +0100, Henrik Nordström wrote: Please go to http://www.squid-cache.org/Versions/v3/HEAD/changesets/merge.html and inspect the list of patches to merge and not merge and give your opinion if you think some patch is should be given another priority or if there is

Re: 3.0.STABLE2 patch candidates

2008-02-25 Thread Amos Jeffries
tis 2008-02-26 klockan 01:08 +0100 skrev Henrik Nordström: tis 2008-02-26 klockan 13:01 +1300 skrev Amos Jeffries: Henrik: is there something special to do with individual patches not to be merged from a group of patches which as a whole are? The include directive group which I

Re: 3.0.STABLE2 patch candidates

2008-02-26 Thread Amos Jeffries
Amos Jeffries wrote: Henrik Nordström wrote: The first pass of grouping and classifying the 3 HEAD changesets since 3.0 branches has now been completed by me and Amos. Please go to http://www.squid-cache.org/Versions/v3/HEAD/changesets/merge.html and inspect the list of patches to merge

Re: Time for squid 3.0 STABLE2 ?

2008-02-27 Thread Amos Jeffries
Henrik Nordström wrote: tis 2008-02-19 klockan 23:00 +0100 skrev Guido Serassio: Hi, What about to release squid 3.0 STABLE2 ? Probably, even if I prefer to fix forwarding of large response headers first.. but it should not be a blocker for STABLE2.. I think that there are many patches

Re: Time for squid 3.0 STABLE2 ?

2008-02-27 Thread Amos Jeffries
Just a few issues remaining before 3.0.STABLE-2. * patch 11467 back-porting. * Close more bugs? http://www.squid-cache.org/bugs/show_bug.cgi?id=2127 http://www.squid-cache.org/bugs/show_bug.cgi?id=2124 why is this not 2.6??

Re: Time for squid 3.0 STABLE2 ?

2008-02-27 Thread Amos Jeffries
On Thu, 2008-02-28 at 01:04 +1300, Amos Jeffries wrote: Just a few issues remaining before 3.0.STABLE-2. snip done * Close more bugs? Booger: stub time| COSS block-size = 512 bytes stub time| COSS largest file offset = -1 KB stub time| COSS cache_dir size = 102400 KB stub time| Fatal

Re: Time for squid 3.0 STABLE2 ?

2008-02-28 Thread Amos Jeffries
Robert Collins wrote: On Thu, 2008-02-28 at 12:41 +0900, Adrian Chadd wrote: On Thu, Feb 28, 2008, Amos Jeffries wrote: * Close more bugs? Booger: stub time| COSS block-size = 512 bytes stub time| COSS largest file offset = -1 KB stub time| COSS cache_dir size = 102400 KB stub time| Fatal

Re: Initial patch for file suffix acl

2008-03-02 Thread Amos Jeffries
Lucas Brasilino wrote: Hi Some time ago Henrik asked for volunteer to some beginner squid developer task. Due some time constraint problems (working on my final project), I couldn't work on it as I desired. But now I have more time (I hope :) ). Well, here comes a initial patch against squid-2

Re: bzr cutover timetable

2008-03-02 Thread Amos Jeffries
Hi, At 13:47 02/03/2008, Robert Collins wrote: Henrik and I have been fine tuning the bzr configuration instructions and checking everything is sufficiently good to migrate across to. We propose to cut across on Tuesday; if there are no objections, then at 1200 UTC Tuesday, squid3 CVS will be

Re: cleanup squid3/src dlink.cc,NONE,1.1.2.1 AuthConfig.h,1.3.26.1, 1.3.26.2 AuthUser.cci,1.3,1.3.26.1 AuthUser.h,1.6.4.2, 1.6.4.3 Makefile.am,1.138.2.7,1.138.2.8 client_side_reply.cc, 1.1

2008-03-03 Thread Amos Jeffries
object boundaries. Memory management itself should be part of common/core later too and the crossover disappears then. Amos Adrian On Tue, Mar 04, 2008, Amos Jeffries wrote: Update of cvs.devel.squid-cache.org:/cvsroot/squid/squid3/src Modified Files: Tag: cleanup AuthConfig.h

PONG! Re: test -ignore

2008-03-04 Thread Amos Jeffries
Robert Collins wrote:

Re: Time for squid 3.0 STABLE2 ?

2008-03-04 Thread Amos Jeffries
Guido Serassio wrote: Hi Amos, At 11:35 01/03/2008, Amos Jeffries wrote: The above is only solved by manually removing the swap.state file. There is something funky going on with the permissions before these high-level swap.state operations. I've seen it here in HEAD and thought

Re: Time for squid 3.0 STABLE2 ?

2008-03-04 Thread Amos Jeffries
Henrik Nordstrom wrote: On Thu, 2008-02-28 at 01:04 +1300, Amos Jeffries wrote: Just a few issues remaining before 3.0.STABLE-2. * patch 11467 back-porting. cd English ls ERR_* ../list * Close more bugs? http://www.squid-cache.org/bugs/show_bug.cgi?id=2127 Is closed

Re: squid3 CVS down for the migration

2008-03-04 Thread Amos Jeffries
I'm doing the CVS-bzr migration now, any future squid3 commits will be ignored. -Rob -- GPG key available at: http://www.robertcollins.net/keys.txt. Oh darn, I got my date conversion wrong. Oh well this afternoons commits weren't much. Amos

Re: TProxy support

2008-03-05 Thread Amos Jeffries
Laszlo Attila Toth wrote: Hello, We only supports TProxy version 4.1 but in the squid --enable-tproxy requires version 2 which is obsolete for a while. Current implementation doesn't require kernel support, only a new socket option, IP_TRANSPARENT, also I made a patch which drops

Re: TProxy support

2008-03-05 Thread Amos Jeffries
Adrian Chadd wrote: On Wed, Mar 05, 2008, Laszlo Attila Toth wrote: Okay, I simply add other hunks to squid code as Amos wrote: - migrate defined LINUX_TPROXY - LINUX_TPROXY2 - add defined LINUX_TPROXY4 Well, LINUX_TPROXY defines a whole bunch of stuff relevant to generic full transparency

Squid sub-libs

2008-03-07 Thread Amos Jeffries
In line with the 3.1 cleanup and re-arranging I'd like to propose a change to the naming scheme of the *.la files squid produces. Namely that they get called libsquid-X.la instead of just libX.la. This would mean: libsquid-auth.la, libsquid-fs.la, libsquid-icap.la, libsquid-esi.la,

Re: Squid sub-libs

2008-03-07 Thread Amos Jeffries
Alex Rousskov wrote: On Sat, 2008-03-08 at 10:52 +1300, Amos Jeffries wrote: In line with the 3.1 cleanup and re-arranging I'd like to propose a change to the naming scheme of the *.la files squid produces. Namely that they get called libsquid-X.la instead of just libX.la. This would mean

Re: Time for squid 3.0 STABLE2 ?

2008-03-09 Thread Amos Jeffries
Amos Jeffries wrote: Henrik Nordstrom wrote: On Thu, 2008-02-28 at 01:04 +1300, Amos Jeffries wrote: Just a few issues remaining before 3.0.STABLE-2. * patch 11467 back-porting. cd English ls ERR_* ../list * Close more bugs? http://www.squid-cache.org/bugs/show_bug.cgi?id=2127

Re: [MERGE] Remove old .h file tests from unit-testing

2008-03-09 Thread Amos Jeffries
On Sun, 2008-03-09 at 11:23 -0600, Alex Rousskov wrote: IMO, virtually all Squid sources should include (directly or indirectly) squid.h as the first include file. In my experience, this design is very useful for portability and other hacks. We have two such files include/config.h

Re: Time for squid 3.0 STABLE2 ?

2008-03-09 Thread Amos Jeffries
On Sun, 2008-03-09 at 21:28 +1300, Amos Jeffries wrote: 1) I don't have write access to the FTP area to copy the files in. I think its /server/ftp/pub/squid-3/STABLE/ anyway. Fixed. (The STABLE1 signature files and diff appear to be missing too) I have now copied the STABLE1

Re: Time for squid 3.0 STABLE2 ?

2008-03-09 Thread Amos Jeffries
On Fri, 2008-02-29 at 01:13 +1300, Amos Jeffries wrote: Hm, yes. Henrik, is there a report somewhere that lgroups the merged changesets the same way the maintainer merge.html lists the un-merged and non-merged ones? There is a merge.html in 2.7 showing what's unique for 2.7 and not merged

Re: [MERGE] Remove old .h file tests from unit-testing

2008-03-09 Thread Amos Jeffries
Alex Rousskov wrote: On Sun, 2008-03-09 at 22:23 +0100, Henrik Nordstrom wrote: Or we could consider squid.h the dirty one, moving out the little tweaks which is there to config.h or better places. IMO, at the end of the cleanup, squid.h should be the file that all sources are guaranteed to

Re: [MERGE] Remove old .h file tests from unit-testing

2008-03-10 Thread Amos Jeffries
Alex Rousskov wrote: On Mon, 2008-03-10 at 18:59 +1300, Amos Jeffries wrote: Alex Rousskov wrote: IMO, at the end of the cleanup, squid.h should be the file that all sources are guaranteed to include first simply because it is called squid.h. Config.h has, by name, a much narrower scope. I

Squid-3.0.STABLE2 is available

2008-03-10 Thread Amos Jeffries
://www.squid-cache.org/Download/http-mirrors.dyn http://www.squid-cache.org/Download/mirrors.dyn Amos Jeffries

[MERGE] Bug 2252: Build failure on Mac OSX 10.5

2008-03-11 Thread Amos Jeffries
Bug 2252: Build failure on Mac OSX 10.5 # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: [EMAIL PROTECTED] # target_branch: file:///src/bzr/squid-repo/trunk/ # testament_sha1: 5051b3d7f938c0af347bcdc527fa72d67ac9095d # timestamp: 2008-03-12 14:15:12 +1300 # message: Bug 2252: Build

Re: [MERGE] Bug 2252: Build failure on Mac OSX 10.5

2008-03-12 Thread Amos Jeffries
Robert Collins wrote: On Wed, 2008-03-12 at 14:15 +1300, Amos Jeffries wrote: === modified file 'src/ACLBrowser.cc' --- src/ACLBrowser.cc 2004-12-20 23:30:12 + +++ src/ACLBrowser.cc 2008-03-12 01:10:46 + @@ -41,11 +41,7 @@ /* explicit template instantiation required for some

Re: Squid-3.0.STABLE2 is available

2008-03-12 Thread Amos Jeffries
Guido Serassio wrote: Hi Amos, At 23:58 10/03/2008, Amos Jeffries wrote: The Squid HTTP Proxy team is pleased to announce the availability of the Squid-3.0.STABLE2 release! The versions page still needs to be updated: http://www.squid-cache.org/Versions/ Regards Guido Oops. Done. Thanks

Re: bzr commit stuff?

2008-03-13 Thread Amos Jeffries
Adrian Chadd wrote: Has anyone actually committed to the bzr tree? I haven't seen any commit messages. Henrik and Robert committed the release script updates before messages were done. Since Robert said the commit messages were supposed to be done I don't think anyone has. Amos -- Please

Re: bzr commit stuff?

2008-03-13 Thread Amos Jeffries
Amos Jeffries wrote: Adrian Chadd wrote: Has anyone actually committed to the bzr tree? I haven't seen any commit messages. Henrik and Robert committed the release script updates before messages were done. Since Robert said the commit messages were supposed to be done I don't think anyone

Re: [MERGE] Squid 3.1 .h Automated Testing

2008-03-16 Thread Amos Jeffries
bb:approve

Re: bzr actions

2008-03-17 Thread Amos Jeffries
Henrik Nordstrom wrote: On Mon, 2008-03-10 at 15:32 +1300, Amos Jeffries wrote: Is there a nice easy way in bzr of retrieving the -r # (of the ancestor!) when the branch was last 'branched'/updated off its ancestor? suitable for a bzr revert -r # ./Makefile.in (and others) -r submit

Re: [squid-core] v3 roadmap

2008-03-18 Thread Amos Jeffries
Amos Jeffries wrote: Alex Rousskov wrote: On Wed, 2008-03-19 at 00:25 +1300, Amos Jeffries wrote: I'm looking forward a few weeks to 3.0.STABLE3 by march 31st Great! Possibly even a 3.1.DEVEL0 at the same time. This should probably be discussed on squid-dev, but there are currently

Re: [squid-core] v3 roadmap

2008-03-18 Thread Amos Jeffries
Alex Rousskov wrote: On Wed, 2008-03-19 at 11:15 +1300, Amos Jeffries wrote: The file re-arranging polish: - I'm kind of in favour of it as a pure file-movements-only alteration. 3.2 has no feature-requests yet and back-porting across a file-re-arranged setup is likely to be more trouble

Re: Including build tag in daily snapshots

2008-03-20 Thread Amos Jeffries
Alex Rousskov wrote: Hello, From http://www.squid-cache.org/bugs/show_bug.cgi?id=2275: User: squid-3.0.STABLE2 compile error. Troubleshooter: Where did you get this 3.0.STABLE2 tree? User: squid-3.0.STABLE2-20080319.tar.gz Troubleshooter: 3.0.STABLE2 does not have this

Re: download pages review

2008-03-20 Thread Amos Jeffries
Henrik Nordstrom wrote: On Thu, 2008-03-20 at 09:20 -0600, Alex Rousskov wrote: Hello, Should we remove Obsolete releases from http://www.squid-cache.org/Versions/v3/3.0/ which looks scary enough without them? Should say Older, not Obsolete.. It's only PRE releases, which by definiton

Re: intro/subscription request

2008-03-20 Thread Amos Jeffries
Matt Benjamin wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, I'd like to quietly join squid-dev. I'm a a Squid user/administrator, with some experience in Squid 2.x and 3.x source. I've run into things I'd like to discuss/fix, and this seems to be the place to be... Welcome

Re: download pages review

2008-03-21 Thread Amos Jeffries
Henrik Nordstrom wrote: On Fri, 2008-03-21 at 15:35 +1300, Amos Jeffries wrote: While we are at it what about the text and links following the releases table. * The Pending bugs link might be useful for 2.x. Maybe. We had that for 2.5, but I never found that link to give any really

Re: [squid-core] v3 roadmap

2008-03-22 Thread Amos Jeffries
Henrik Nordstrom wrote: On Wed, 2008-03-19 at 11:15 +1300, Amos Jeffries wrote: - I'm kind of in favour of it as a pure file-movements-only alteration. 3.2 has no feature-requests yet and back-porting across a file-re-arranged setup is likely to be more trouble than its worth. bzr tracks

Valgrind results

2008-03-23 Thread Amos Jeffries
Just doing a quick check with valgrind I'm seeing a lot of errors in the event system. Syscall param epoll_ctl(event) points to uninitialised byte(s) with a wide range of events like: ==25761==at 0x4559A59: epoll_ctl (in /lib/libc-2.7.so) ==25761==by 0x8171C2F: comm_read(int, char*,

Re: Valgrind results

2008-03-23 Thread Amos Jeffries
Adrian Chadd wrote: You can ignore that. If you care that much about the epoll error then just bzero() the data being passed into epoll_ctl() before its called. I care about every potential cause of trouble in squid. Particularly avoidable ones that pop up all the time. 'Zero errors' policy

[MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage

2008-03-23 Thread Amos Jeffries
Fix memory leak in Linux builds. # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: [EMAIL PROTECTED] # target_branch: file:///src/squid/bzr/trunk/ # testament_sha1: 17d43699f1813e00a034e95f491c5dbb84d791c3 # timestamp: 2008-03-23 23:19:37 +1200 # base_revision_id: [EMAIL PROTECTED] #

Re: Valgrind results

2008-03-23 Thread Amos Jeffries
Adrian Chadd wrote: On Mon, Mar 24, 2008, Amos Jeffries wrote: Adrian Chadd wrote: You can ignore that. If you care that much about the epoll error then just bzero() the data being passed into epoll_ctl() before its called. I care about every potential cause of trouble in squid. Particularly

Re: v3 roadmap

2008-03-24 Thread Amos Jeffries
Alex Rousskov wrote: On Sun, 2008-03-23 at 15:24 +1300, Amos Jeffries wrote: Henrik Nordstrom wrote: On Wed, 2008-03-19 at 11:15 +1300, Amos Jeffries wrote: - I'm kind of in favour of it as a pure file-movements-only alteration. 3.2 has no feature-requests yet and back-porting across

Re: [MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage

2008-03-24 Thread Amos Jeffries
Bernhard Schmidt wrote: Amos Jeffries [EMAIL PROTECTED] wrote: Fix memory leak in Linux builds. This one seems to break outgoing IPv4 connects (on a dualstacked Squid) bzr trunk revision 8902 fails with | While trying to retrieve the URL: http://www.heise.de/ | | The following error

Re: Valgrind results

2008-03-24 Thread Amos Jeffries
Henrik Nordstrom wrote: On Mon, 2008-03-24 at 00:16 +1300, Amos Jeffries wrote: I care about every potential cause of trouble in squid. Particularly avoidable ones that pop up all the time. 'Zero errors' policy and all that. It may be that this is fixable by setting the first byte

Re: Features/SourceLayout

2008-03-24 Thread Amos Jeffries
Alex Rousskov wrote: The following page has been changed by Amos Jeffries: http://wiki.squid-cache.org/Features/SourceLayout?action=diffrev2=9rev1=8 Original: Question: Can we remove Foo prefix from FOO/!FooSomething.h file names? The prefix carries no additional information and is probably

bzr revert

2008-03-24 Thread Amos Jeffries
Robert Henrik, Some of us have found a knowledge-hole in the bzr revert process. We can easily reverse a patch using for example: bzr revert -r 8902 But then when its fixed we don't know how to undo the undo. The local branch is left with code apparently up-to-date but is actually

Re: [MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage

2008-03-24 Thread Amos Jeffries
Bernhard Schmidt wrote: Hi, Oh drat. I mis-configured my new test setup. Sorry. Revision 8903 has had a more careful set of tests done and fixes that problem. Confirmed. At least I think so, there was quite some trial and error involved to force the dreaded bzr to sync the trees again

Re: Features/SourceLayout

2008-03-25 Thread Amos Jeffries
Alex Rousskov wrote: On Tue, 2008-03-25 at 10:29 +1300, Amos Jeffries wrote: Alex Rousskov wrote: The following page has been changed by Amos Jeffries: http://wiki.squid-cache.org/Features/SourceLayout?action=diffrev2=9rev1=8 Original: Question: Can we remove Foo prefix from FOO

Re: 3.1 steps forward

2008-03-25 Thread Amos Jeffries
Adrian Chadd wrote: On Fri, Feb 15, 2008, Amos Jeffries wrote: Sorry if I was obtuse. I meant that you are the expert on this one. Are you able to re-locate that mysterious branch and estimate when you will have time to sync and push it to HEAD? squid3_logdaemon have you fixed the AddrInfo

[MERGE] Replace a URN handling set of gotos' with a sub-function.

2008-03-25 Thread Amos Jeffries
Replace a URN handling set of gotos' with a sub-function. # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: [EMAIL PROTECTED] # target_branch: file:///src/squid/bzr/cleanup/ # testament_sha1: 23ceddad39c635fcb80fa6d71378c39220fb9f2a # timestamp: 2008-03-25 13:13:05 +1200 #

Re: adaptation sections

2008-03-25 Thread Amos Jeffries
Alex Rousskov wrote: Hello, Should I use the same debugging sections for ICAP, eCAP, and the code they share? Or should we have three distinct debugging sections for those three areas? I think 2 areas for the unique code at least. Preferrably numerically close. How much of the shared

Re: Valgrind results

2008-03-25 Thread Amos Jeffries
Henrik Nordstrom wrote: On Tue, 2008-03-25 at 10:23 +1300, Amos Jeffries wrote: I found that in 3.x as well. It turns out those bits of valgrind code only occur if both --enable-leakfinder and --with-valgrind-debug are enabled. My test script only had --with-valgrind which wasn't doing even

<    1   2   3   4   5   6   7   8   9   10   >