[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129711#comment-14129711
 ] 

Rakesh R commented on BOOKKEEPER-773:
-------------------------------------

bq.you pulled all ledgers into a list, which doesn't work if your cluster have 
a lot of ledgers. 
Actually I pulled all the ledgers to find the total number of ledgers. Is there 
any single API to know the total number of ledgers, otw I've to first iterate 
over all the ledgers and get the total count. Then secondly will get the 
iterator again and then iterate over all the ledgers asynchronously(as I 
mentioned earlier will have bandwidth in place to control the concurrency).
If I understood correctly you are suggesting to go with one-by-one ledger 
rename (sequential execution). FYI - Initially I done the same way, but 
[[email protected]] has given a [comment | 
https://issues.apache.org/jira/browse/BOOKKEEPER-634?focusedCommentId=14010999&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14010999]
 to make it concurrent and I also felt it would be useful one.

bq. one is using your current solution, while the other one is using ledger 
iterator. so people could choose what to use. although I don't suggest to have 
two implementation on this, it would make code maintenance become hard.
I also prefer to implement one good solution. Both are not required.



> Provide admin tool to rename bookie identifier in Cookies
> ---------------------------------------------------------
>
>                 Key: BOOKKEEPER-773
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-server
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 4.3.0
>
>         Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 
> 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 
> 003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 
> 004-BOOKKEEPER-773-rename-bookieid.patch, 
> 005-BOOKKEEPER-773-rename-bookieid.patch
>
>
> The idea of this JIRA to implement a mechanism to efficiently rename the 
> bookie identifier present in the Cookies. Cookie information will be present 
> in:
> - ledger & journal directories in each Bookie server
> - cookies znode in ZooKeeper



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to