[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129898#comment-14129898
]
Rakesh R commented on BOOKKEEPER-773:
-------------------------------------
Thanks [~hustlmsp] for your time and quick replies.
bq.in general, all class variables in Cookie should be final. please use a
Builder pattern to generate a new Cookie object when modifying it. DONT modify
the field in-place, which would usually introduce bugs.
I've raised separate JIRA BOOKKEEPER-782 to modify Cookie.java. Kindly review
it. Thanks!
bq.it is much clear and easier for reviewing and get things checked in faster.
Attached a patch which only talks about rename cookie. This patch has to be
applied on top of BOOKKEEPER-782
> Provide admin tool to rename bookie identifier in Cookies
> ---------------------------------------------------------
>
> Key: BOOKKEEPER-773
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.3.0
>
> Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 004-BOOKKEEPER-773-rename-bookieid.patch,
> 005-BOOKKEEPER-773-rename-bookieid.patch,
> 006-BOOKKEEPER-773-rename-bookieid.patch
>
>
> The idea of this JIRA to implement a mechanism to efficiently rename the
> bookie identifier present in the Cookies. Cookie information will be present
> in:
> - ledger & journal directories in each Bookie server
> - cookies znode in ZooKeeper
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
