James Fowler <boost_list <at> openseaconsulting.com> writes:
>
> merging replies to a few different messages here...
Thanks. I'm having trouble keeping up!
[snip]
> Thanks for the suggestion, but I'd much rather see you continue taking
> the lead on the dynamic highlighting! You've done great so far, and
> you've put some serious work into it. The only thing I've added to the
> dynamic highlighting system is the space/nbsp;/newline patch. Other
> than that, I simply merged your code in with the other varied bits I've
> added, which was pretty easy since you did a great job keeping the bulk
> of the implementation in new source files.
Thanks. I'm certainly happy to document the dynamic highlighting once we've
sorted out how to do it.
I have a few comments on the zip archive I picked up from your website (which I
suspect is out of date now)
1) compile error (GCC 3.3.3)
detail/utils.cpp:95: error: no matching function for call to `
std::vector<std::string, std::allocator<std::string> >::insert(int, const
char[1])'
/usr/include/c++/3.3.3/bits/vector.tcc:89: error: candidates are:
__gnu_cxx::__normal_iterator<_Tp*, std::vector<_Tp, _Alloc> >
std::vector<_Tp, _Alloc>::insert(__gnu_cxx::__normal_iterator<_Tp*,
std::vector<_Tp, _Alloc> >, const _Tp&) [with _Tp = std::string, _Alloc =
std::allocator<std::string>]
/usr/include/c++/3.3.3/bits/stl_vector.h:671: error: void
std::vector<_Tp, _Alloc>::insert(__gnu_cxx::__normal_iterator<_Tp*,
std::vector<_Tp, _Alloc> >, unsigned int, const _Tp&) [with _Tp =
std::string, _Alloc = std::allocator<std::string>]
2) CLI help looks a bit funny.
$ ./quickbook.exe --help
Allowed options:
--help produce help message
-v [ --version ] print version string
-I [ --include-path ] arginclude path
^^^
3) Run time exception:
$ ./quickbook.exe doc/quickbook.qbk
Error: attempt to create string with null pointer
I think this is caused by work-in-progress in alternate_process_name.
4) extra newlines when loading a file
detail::load(...) appends a couple of extra newlines. This is OK when
parsing highlight files, qbk files but may cause unwanted whitespace when
source files for highlighting are loaded in this way?
5) new code in utils.cpp doesn't match current style. E.g tabs instead
of spaces, different layout of braces. Use of file statics in
utils.cpp (typically QuickBook passes a struct around by reference to
hold working variables in a scoped manner).
Not sure how much of an issue this is, but I thought I should point it
out. I leave it in the hands of the QuickBook moderators. I have also
tweaked the house style by introducing some Doxygen style comments, so
I hope this is OK.
Regards,
Thomas
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Boost-docs mailing list
[email protected]
Unsubscribe and other administrative requests:
https://lists.sourceforge.net/lists/listinfo/boost-docs
