VVildVVolf commented on code in PR #31118:
URL: https://github.com/apache/airflow/pull/31118#discussion_r1187895107


##########
airflow/providers/google/cloud/hooks/vertex_ai/batch_prediction_job.py:
##########
@@ -114,6 +114,8 @@ def create_batch_prediction_job(
         labels: dict[str, str] | None = None,
         encryption_spec_key_name: str | None = None,
         sync: bool = True,
+        create_request_timeout: float | None = None,
+        batch_size: int | None = None,

Review Comment:
   BTW, [Google's 
implementation](https://github.com/googleapis/python-aiplatform/blob/main/google/cloud/aiplatform/jobs.py#L402)
 has `None` as default value (possibly due to not sending default one over 
network).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to