hussein-awala commented on code in PR #31118:
URL: https://github.com/apache/airflow/pull/31118#discussion_r1186860967
##########
airflow/providers/google/cloud/operators/vertex_ai/batch_prediction_job.py:
##########
@@ -181,6 +189,8 @@ def __init__(
labels: dict[str, str] | None = None,
encryption_spec_key_name: str | None = None,
sync: bool = True,
+ create_request_timeout: float | None = None,
+ batch_size: int | None = None,
Review Comment:
same here
##########
airflow/providers/google/cloud/hooks/vertex_ai/batch_prediction_job.py:
##########
@@ -114,6 +114,8 @@ def create_batch_prediction_job(
labels: dict[str, str] | None = None,
encryption_spec_key_name: str | None = None,
sync: bool = True,
+ create_request_timeout: float | None = None,
+ batch_size: int | None = None,
Review Comment:
Since the google API client replace the None value by 64, why we don't
provide a 64 as default value to make it clearer (and maybe avoid auto-updating
the default value if the client updates it in the next versions)
```suggestion
batch_size: int = 64,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
