VVildVVolf commented on code in PR #31118:
URL: https://github.com/apache/airflow/pull/31118#discussion_r1186877921
##########
airflow/providers/google/cloud/hooks/vertex_ai/batch_prediction_job.py:
##########
@@ -114,6 +114,8 @@ def create_batch_prediction_job(
labels: dict[str, str] | None = None,
encryption_spec_key_name: str | None = None,
sync: bool = True,
+ create_request_timeout: float | None = None,
+ batch_size: int | None = None,
Review Comment:
To be honest I don't think it is a good idea to duplicate existing external
code. The description says actual defaults on the final end and we can rely on
Google's implementation.
If google would ever change it - we would not need update every wrap of
their SDK. But if we will keep default value on our side - we will need to
check these points every time when we update of sdk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
