potiuk commented on code in PR #31118:
URL: https://github.com/apache/airflow/pull/31118#discussion_r1188142545
##########
airflow/providers/google/cloud/hooks/vertex_ai/batch_prediction_job.py:
##########
@@ -114,6 +114,8 @@ def create_batch_prediction_job(
labels: dict[str, str] | None = None,
encryption_spec_key_name: str | None = None,
sync: bool = True,
+ create_request_timeout: float | None = None,
+ batch_size: int | None = None,
Review Comment:
Yeah. Having None there is good, and I would say we should simply refer to
the default value from the original API - we don't have to specify it here, we
can get description "Default is the same as in the BatchPredictionJob from
aiplaatform API and we are good.
Honestly - do we care what is the default in this operator in this case?
Not relly, should we describe what it is - yes. Does it have to be a constant?
not really - we can defer to the original API. This way it will be both -
correct and future-prof.
##########
airflow/providers/google/cloud/hooks/vertex_ai/batch_prediction_job.py:
##########
@@ -114,6 +114,8 @@ def create_batch_prediction_job(
labels: dict[str, str] | None = None,
encryption_spec_key_name: str | None = None,
sync: bool = True,
+ create_request_timeout: float | None = None,
+ batch_size: int | None = None,
Review Comment:
Yeah. Having None there is good, and I would say we should simply refer to
the default value from the original API - we don't have to specify it here, we
can get description "Default is the same as in the BatchPredictionJob from
aiplaatform API and we are good.
Honestly - do we care what is the default in this operator in this case?
Not relly, should we describe what it is - yes. Does it have to be a constant?
not really - we can defer to the original API. This way it will be both -
correct and future-proof.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
