hussein-awala commented on code in PR #31118:
URL: https://github.com/apache/airflow/pull/31118#discussion_r1186864055
##########
airflow/providers/google/cloud/hooks/vertex_ai/batch_prediction_job.py:
##########
@@ -114,6 +114,8 @@ def create_batch_prediction_job(
labels: dict[str, str] | None = None,
encryption_spec_key_name: str | None = None,
sync: bool = True,
+ create_request_timeout: float | None = None,
+ batch_size: int | None = None,
Review Comment:
IMHO, changing the default value is a breaking change, they will list it in
their release notes when they change it, but when we upgrade the client version
(like you do in this PR), we don't check all these changes and duplicate them.
I have no objection. @potiuk @pankajkoti WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
