VVildVVolf commented on code in PR #31118:
URL: https://github.com/apache/airflow/pull/31118#discussion_r1186862722
##########
airflow/providers/google/cloud/hooks/vertex_ai/batch_prediction_job.py:
##########
@@ -114,6 +114,8 @@ def create_batch_prediction_job(
labels: dict[str, str] | None = None,
encryption_spec_key_name: str | None = None,
sync: bool = True,
+ create_request_timeout: float | None = None,
+ batch_size: int | None = None,
Review Comment:
Looks like it is their responsibility, do you think would be better
duplicate it, or we can trust in Google's implementation? There were a bug
once, related to extra copying default value of param
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
