pankajkoti commented on code in PR #31118:
URL: https://github.com/apache/airflow/pull/31118#discussion_r1186870267
##########
airflow/providers/google/cloud/hooks/vertex_ai/batch_prediction_job.py:
##########
@@ -114,6 +114,8 @@ def create_batch_prediction_job(
labels: dict[str, str] | None = None,
encryption_spec_key_name: str | None = None,
sync: bool = True,
+ create_request_timeout: float | None = None,
+ batch_size: int | None = None,
Review Comment:
I had the same question initially, that the docstring says the default is
64, but we set it to None. Later realised that the Google library will set the
default to 64 even though we send as None. If we do not want to set the default
to 64, IMO, we could still provide more details in the docstring param that the
library sets it to 64 even though we set it None.
If I was developing this, I would set the default to 64 here itself, but
that's just my opinion and I maybe wrong :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
